* [PATCH] video: fbdev: s3c-fb: fix platform_get_irq.cocci warning
@ 2022-03-02 3:44 Yihao Han
2022-03-03 10:15 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Yihao Han @ 2022-03-02 3:44 UTC (permalink / raw)
To: Jingoo Han, Helge Deller, linux-fbdev, dri-devel, linux-kernel
Cc: kernel, Yihao Han
Remove dev_err() messages after platform_get_irq*() failures.
platform_get_irq() already prints an error.
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
drivers/video/fbdev/s3c-fb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
index 208514054c23..3abbc5737c3b 100644
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c
@@ -1418,7 +1418,6 @@ static int s3c_fb_probe(struct platform_device *pdev)
sfb->irq_no = platform_get_irq(pdev, 0);
if (sfb->irq_no < 0) {
- dev_err(dev, "failed to acquire irq resource\n");
ret = -ENOENT;
goto err_lcd_clk;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: s3c-fb: fix platform_get_irq.cocci warning
2022-03-02 3:44 [PATCH] video: fbdev: s3c-fb: fix platform_get_irq.cocci warning Yihao Han
@ 2022-03-03 10:15 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2022-03-03 10:15 UTC (permalink / raw)
To: Yihao Han, Jingoo Han, linux-fbdev, dri-devel, linux-kernel; +Cc: kernel
On 3/2/22 04:44, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
applied to the fbdev for-next git tree.
Thanks!
Helge
> ---
> drivers/video/fbdev/s3c-fb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
> index 208514054c23..3abbc5737c3b 100644
> --- a/drivers/video/fbdev/s3c-fb.c
> +++ b/drivers/video/fbdev/s3c-fb.c
> @@ -1418,7 +1418,6 @@ static int s3c_fb_probe(struct platform_device *pdev)
>
> sfb->irq_no = platform_get_irq(pdev, 0);
> if (sfb->irq_no < 0) {
> - dev_err(dev, "failed to acquire irq resource\n");
> ret = -ENOENT;
> goto err_lcd_clk;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-03 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02 3:44 [PATCH] video: fbdev: s3c-fb: fix platform_get_irq.cocci warning Yihao Han
2022-03-03 10:15 ` Helge Deller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.