All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] docs: proc.rst: fix wrong time unit
@ 2022-03-02 16:11 YI
  2022-03-09 23:26 ` Jonathan Corbet
  0 siblings, 1 reply; 2+ messages in thread
From: YI @ 2022-03-02 16:11 UTC (permalink / raw)
  To: trivial
  Cc: YI, Jonathan Corbet, Andrew Morton, Christoph Anton Mitterer,
	Kalesh Singh, Matthew Wilcox (Oracle),
	Colin Cross, Mike Rapoport, Peter Xu, linux-kernel,
	linux-fsdevel, linux-doc

From: YI <afctgo@gmail.com>

Dear Trivial Patch Monkey, 

This commit fixes a small documentaion problem reported in
https://bugzilla.kernel.org/show_bug.cgi?id=194593.

Some fields in the file /proc/$pid/stat represent time.
Their units are clock_t, not jiffies as stated in the documentation.
This commit fixes https://bugzilla.kernel.org/show_bug.cgi?id=194593.

Reported-by: hujunjie
Signed-off-by: YI <afctgo@gmail.com>
---
 Documentation/filesystems/proc.rst | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
index 061744c436d9..433ad4623630 100644
--- a/Documentation/filesystems/proc.rst
+++ b/Documentation/filesystems/proc.rst
@@ -340,10 +340,10 @@ It's slow but very precise.
   cmin_flt      number of minor faults with child's
   maj_flt       number of major faults
   cmaj_flt      number of major faults with child's
-  utime         user mode jiffies
-  stime         kernel mode jiffies
-  cutime        user mode jiffies with child's
-  cstime        kernel mode jiffies with child's
+  utime         user mode processor time (clock_t)
+  stime         kernel mode processor time (clock_t)
+  cutime        user mode processor time (clock_t) with child's
+  cstime        kernel mode processor time (clock_t) with child's
   priority      priority level
   nice          nice level
   num_threads   number of threads
@@ -370,8 +370,8 @@ It's slow but very precise.
   rt_priority   realtime priority
   policy        scheduling policy (man sched_setscheduler)
   blkio_ticks   time spent waiting for block IO
-  gtime         guest time of the task in jiffies
-  cgtime        guest time of the task children in jiffies
+  gtime         guest time of the task in processor time (clock_t)
+  cgtime        guest time of the task children in processor time (clock_t)
   start_data    address above which program data+bss is placed
   end_data      address below which program data+bss is placed
   start_brk     address above which program heap can be expanded with brk()
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] docs: proc.rst: fix wrong time unit
  2022-03-02 16:11 [PATCH] docs: proc.rst: fix wrong time unit YI
@ 2022-03-09 23:26 ` Jonathan Corbet
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Corbet @ 2022-03-09 23:26 UTC (permalink / raw)
  To: YI, trivial
  Cc: YI, Andrew Morton, Christoph Anton Mitterer, Kalesh Singh,
	Matthew Wilcox (Oracle),
	Colin Cross, Mike Rapoport, Peter Xu, linux-kernel,
	linux-fsdevel, linux-doc

YI <afctgo@gmail.com> writes:

> From: YI <afctgo@gmail.com>
>
> Dear Trivial Patch Monkey, 

The trivial patch monkey has gone into retirement, I'm as close as
you're going to get.

> This commit fixes a small documentaion problem reported in
> https://bugzilla.kernel.org/show_bug.cgi?id=194593.
>
> Some fields in the file /proc/$pid/stat represent time.
> Their units are clock_t, not jiffies as stated in the documentation.
> This commit fixes https://bugzilla.kernel.org/show_bug.cgi?id=194593.

We certainly don't need to give the bugzilla URL twice; I'm not
convinced it's needed even once.  The changelog should just say what the
patch does, please.

Also, "clock_t" isn't really a unit type; what are the actual units of
the field?

> Reported-by: hujunjie

This isn't a valid reported-by line

> Signed-off-by: YI <afctgo@gmail.com>

...and the signoff need to have your full name, please.

Thanks,

jon

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-09 23:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02 16:11 [PATCH] docs: proc.rst: fix wrong time unit YI
2022-03-09 23:26 ` Jonathan Corbet

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.