All of lore.kernel.org
 help / color / mirror / Atom feed
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: borntraeger@de.ibm.com, frankja@linux.ibm.com, thuth@redhat.com,
	pasic@linux.ibm.com, david@redhat.com,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	scgl@linux.ibm.com, mimu@linux.ibm.com, nrb@linux.ibm.com
Subject: [PATCH v8 06/17] KVM: s390: pv: add export before import
Date: Wed,  2 Mar 2022 19:11:32 +0100	[thread overview]
Message-ID: <20220302181143.188283-7-imbrenda@linux.ibm.com> (raw)
In-Reply-To: <20220302181143.188283-1-imbrenda@linux.ibm.com>

Due to upcoming changes, it will be possible to temporarily have
multiple protected VMs in the same address space, although only one
will be actually active.

In that scenario, it is necessary to perform an export of every page
that is to be imported, since the hardware does not allow a page
belonging to a protected guest to be imported into a different
protected guest.

This also applies to pages that are shared, and thus accessible by the
host.

Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
---
 arch/s390/kernel/uv.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
index 2754471cc789..e358b8bd864b 100644
--- a/arch/s390/kernel/uv.c
+++ b/arch/s390/kernel/uv.c
@@ -234,6 +234,12 @@ static int make_secure_pte(pte_t *ptep, unsigned long addr,
 	return uvcb->rc == 0x10a ? -ENXIO : -EINVAL;
 }
 
+static bool should_export_before_import(struct uv_cb_header *uvcb, struct mm_struct *mm)
+{
+	return uvcb->cmd != UVC_CMD_UNPIN_PAGE_SHARED &&
+		atomic_read(&mm->context.protected_count) > 1;
+}
+
 /*
  * Requests the Ultravisor to make a page accessible to a guest.
  * If it's brought in the first time, it will be cleared. If
@@ -277,6 +283,8 @@ int gmap_make_secure(struct gmap *gmap, unsigned long gaddr, void *uvcb)
 
 	lock_page(page);
 	ptep = get_locked_pte(gmap->mm, uaddr, &ptelock);
+	if (should_export_before_import(uvcb, gmap->mm))
+		uv_convert_from_secure(page_to_phys(page));
 	rc = make_secure_pte(ptep, uaddr, page, uvcb);
 	pte_unmap_unlock(ptep, ptelock);
 	unlock_page(page);
-- 
2.34.1


  parent reply	other threads:[~2022-03-02 18:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-02 18:11 [PATCH v8 00/17] KVM: s390: pv: implement lazy destroy for reboot Claudio Imbrenda
2022-03-02 18:11 ` [PATCH v8 01/17] KVM: s390: pv: leak the topmost page table when destroy fails Claudio Imbrenda
2022-03-03 14:40   ` Janis Schoetterl-Glausch
2022-03-03 15:05     ` Claudio Imbrenda
2022-03-03 16:34       ` Janis Schoetterl-Glausch
2022-03-02 18:11 ` [PATCH v8 02/17] KVM: s390: pv: handle secure storage violations for protected guests Claudio Imbrenda
2022-03-02 18:11 ` [PATCH v8 03/17] KVM: s390: pv: handle secure storage exceptions for normal guests Claudio Imbrenda
2022-03-02 18:11 ` [PATCH v8 04/17] KVM: s390: pv: refactor s390_reset_acc Claudio Imbrenda
2022-03-02 18:11 ` [PATCH v8 05/17] KVM: s390: pv: usage counter instead of flag Claudio Imbrenda
2022-03-02 18:11 ` Claudio Imbrenda [this message]
2022-03-02 18:11 ` [PATCH v8 07/17] KVM: s390: pv: module parameter to fence lazy destroy Claudio Imbrenda
2022-03-02 18:11 ` [PATCH v8 08/17] KVM: s390: pv: clear the state without memset Claudio Imbrenda
2022-03-02 18:11 ` [PATCH v8 09/17] KVM: s390: pv: Add kvm_s390_cpus_from_pv to kvm-s390.h and add documentation Claudio Imbrenda
2022-03-02 18:11 ` [PATCH v8 10/17] KVM: s390: pv: add mmu_notifier Claudio Imbrenda
2022-03-03  3:12   ` kernel test robot
2022-03-03  3:12   ` kernel test robot
2022-03-02 18:11 ` [PATCH v8 11/17] s390/mm: KVM: pv: when tearing down, try to destroy protected pages Claudio Imbrenda
2022-03-02 18:11 ` [PATCH v8 12/17] KVM: s390: pv: refactoring of kvm_s390_pv_deinit_vm Claudio Imbrenda
2022-03-02 18:11 ` [PATCH v8 13/17] KVM: s390: pv: cleanup leftover protected VMs if needed Claudio Imbrenda
2022-03-02 18:11 ` [PATCH v8 14/17] KVM: s390: pv: asynchronous destroy for reboot Claudio Imbrenda
2022-03-02 18:11 ` [PATCH v8 15/17] KVM: s390: pv: api documentation for asynchronous destroy Claudio Imbrenda
2022-03-02 18:11 ` [PATCH v8 16/17] KVM: s390: pv: add KVM_CAP_S390_PROTECTED_ASYNC_DISABLE Claudio Imbrenda
2022-03-02 18:11 ` [PATCH v8 17/17] KVM: s390: pv: avoid export before import if possible Claudio Imbrenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220302181143.188283-7-imbrenda@linux.ibm.com \
    --to=imbrenda@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mimu@linux.ibm.com \
    --cc=nrb@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=scgl@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.