From: "Michael S. Tsirkin" <mst@redhat.com>
To: Bobby Eshleman <beshleman.devbox@gmail.com>
Cc: cong.wang@bytedance.com, duanxiongchun@bytedance.com,
bobby.eshleman@bytedance.com, jiang.wang@bytedance.com,
cohuck@redhat.com, virtualization@lists.linux-foundation.org,
xieyongji@bytedance.com, chaiwen.cc@bytedance.com,
stefanha@redhat.com, virtio-comment@lists.oasis-open.org,
asias@redhat.com, arseny.krasnov@kaspersky.com,
jhansen@vmware.com
Subject: Re: [virtio-comment] [PATCH v5 1/2] virtio-vsock: add description for datagram type
Date: Thu, 3 Mar 2022 06:41:11 -0500 [thread overview]
Message-ID: <20220303063001-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220303032801.yvlfu5vqqibu7eyo@ip-10-100-118-60.ec2.internal>
On Thu, Mar 03, 2022 at 03:29:31AM +0000, Bobby Eshleman wrote:
> On Wed, Mar 02, 2022 at 05:09:58PM +0100, Stefano Garzarella wrote:
> > Hi Bobby,
> > Sorry for the delay, but I saw these patches today.
> > Please, can you keep me in CC?
> >
>
> Hey Stefano, sorry about that. I'm not sure how I lost your CC on this
> one. I'll make sure you are there moving forward.
>
> I want to mention that I'm taking a look at
> https://gitlab.com/vsock/vsock/-/issues/1 in parallel with my dgram work
> here. After sending out this series we noticed potential overlap between
> the two issues. The additional dgram queues may become redundant if a
> fairness mechanism that solves issue #1 above also applies to
> connection-less protocols (similar to how the TC subsystem works). I've
> just begun sorting out potential solutions so no hard results yet. Just
> putting on your radar that the proposal here in v5 may be impacted if my
> investigation into issue #1 yields something adequate.
With respect to datagram, there is actually another issue which also
exists for stream but is smaller there - per message overhead is not
accounted for. For stream we can work around that by copying payload
data. For datagram we can't as we need to preserve message boundaries.
One way to address that is to add config for host/guest per-message
overhead, and have sender decrement fwd counter by that value for
each message sent.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Bobby Eshleman <beshleman.devbox@gmail.com>
Cc: Stefano Garzarella <sgarzare@redhat.com>,
cohuck@redhat.com, virtio-comment@lists.oasis-open.org,
cong.wang@bytedance.com, duanxiongchun@bytedance.com,
jiang.wang@bytedance.com,
virtualization@lists.linux-foundation.org,
xieyongji@bytedance.com, chaiwen.cc@bytedance.com,
stefanha@redhat.com, asias@redhat.com,
arseny.krasnov@kaspersky.com, jhansen@vmware.com,
bobby.eshleman@bytedance.com
Subject: Re: [virtio-comment] [PATCH v5 1/2] virtio-vsock: add description for datagram type
Date: Thu, 3 Mar 2022 06:41:11 -0500 [thread overview]
Message-ID: <20220303063001-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220303032801.yvlfu5vqqibu7eyo@ip-10-100-118-60.ec2.internal>
On Thu, Mar 03, 2022 at 03:29:31AM +0000, Bobby Eshleman wrote:
> On Wed, Mar 02, 2022 at 05:09:58PM +0100, Stefano Garzarella wrote:
> > Hi Bobby,
> > Sorry for the delay, but I saw these patches today.
> > Please, can you keep me in CC?
> >
>
> Hey Stefano, sorry about that. I'm not sure how I lost your CC on this
> one. I'll make sure you are there moving forward.
>
> I want to mention that I'm taking a look at
> https://gitlab.com/vsock/vsock/-/issues/1 in parallel with my dgram work
> here. After sending out this series we noticed potential overlap between
> the two issues. The additional dgram queues may become redundant if a
> fairness mechanism that solves issue #1 above also applies to
> connection-less protocols (similar to how the TC subsystem works). I've
> just begun sorting out potential solutions so no hard results yet. Just
> putting on your radar that the proposal here in v5 may be impacted if my
> investigation into issue #1 yields something adequate.
With respect to datagram, there is actually another issue which also
exists for stream but is smaller there - per message overhead is not
accounted for. For stream we can work around that by copying payload
data. For datagram we can't as we need to preserve message boundaries.
One way to address that is to add config for host/guest per-message
overhead, and have sender decrement fwd counter by that value for
each message sent.
--
MST
next prev parent reply other threads:[~2022-03-03 11:41 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 4:01 [RFC v4] virtio-vsock: add description for datagram type Jiang Wang
2021-05-28 4:01 ` [virtio-comment] " Jiang Wang
2021-06-07 18:45 ` Jiang Wang .
2021-06-07 18:45 ` [virtio-comment] " Jiang Wang .
2021-06-08 13:46 ` Stefano Garzarella
2021-06-08 13:46 ` [virtio-comment] " Stefano Garzarella
2021-06-09 4:22 ` [External] " Jiang Wang .
2021-06-09 4:22 ` [virtio-comment] " Jiang Wang .
2021-06-09 7:17 ` Stefano Garzarella
2021-06-09 7:17 ` [virtio-comment] " Stefano Garzarella
2021-06-10 3:31 ` Jiang Wang .
2021-06-10 3:31 ` [virtio-comment] " Jiang Wang .
2021-06-10 6:56 ` Stefano Garzarella
2021-06-10 6:56 ` [virtio-comment] " Stefano Garzarella
2022-02-24 21:57 ` [PATCH v5 0/2] Support vsock datagram and mergeable buffers beshleman.devbox
2022-02-24 21:57 ` [PATCH v5 1/2] virtio-vsock: add description for datagram type beshleman.devbox
2022-02-24 21:57 ` [PATCH v5 2/2] virtio-vsock: add mergeable buffer feature bit beshleman.devbox
2022-02-24 22:15 ` [PATCH v5 0/2] Support vsock datagram and mergeable buffers beshleman.devbox
2022-02-24 22:15 ` [PATCH v5 1/2] virtio-vsock: add description for datagram type beshleman.devbox
2022-03-02 16:09 ` [virtio-comment] " Stefano Garzarella
2022-03-02 16:09 ` Stefano Garzarella
2022-03-03 3:29 ` Bobby Eshleman
2022-03-03 7:15 ` Michael S. Tsirkin
2022-03-03 7:15 ` Michael S. Tsirkin
2022-03-05 1:25 ` Bobby Eshleman
2022-03-06 10:17 ` Michael S. Tsirkin
2022-03-06 10:17 ` Michael S. Tsirkin
2022-03-03 10:23 ` Stefano Garzarella
2022-03-03 10:23 ` Stefano Garzarella
2022-03-05 1:25 ` Bobby Eshleman
2022-03-03 11:41 ` Michael S. Tsirkin [this message]
2022-03-03 11:41 ` Michael S. Tsirkin
2022-03-07 17:41 ` Bobby Eshleman
2022-02-24 22:15 ` [PATCH v5 2/2] virtio-vsock: add mergeable buffer feature bit beshleman.devbox
2022-03-02 16:19 ` [virtio-comment] " Stefano Garzarella
2022-03-02 16:19 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220303063001-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=arseny.krasnov@kaspersky.com \
--cc=asias@redhat.com \
--cc=beshleman.devbox@gmail.com \
--cc=bobby.eshleman@bytedance.com \
--cc=chaiwen.cc@bytedance.com \
--cc=cohuck@redhat.com \
--cc=cong.wang@bytedance.com \
--cc=duanxiongchun@bytedance.com \
--cc=jhansen@vmware.com \
--cc=jiang.wang@bytedance.com \
--cc=stefanha@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.