From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>
Subject: [PATCH 0/2] target/arm: Check Neon VLD1/VST1 stride bits are zero
Date: Thu, 3 Mar 2022 11:37:39 +0000 [thread overview]
Message-ID: <20220303113741.2156877-1-peter.maydell@linaro.org> (raw)
In the Neon VLD*/VST* "load/store single N-element structure to/from
one lane" instructions the encodings include bits to specify a
"stride" value, which specifies the separation between the Neon
registers which hold the different elements of the structure. For
VLD1/VST1 there is only a single element and thus only one Neon
register is involved. This means "stride" is not meaningful, and the
architecture requires that the bits that would encode it must be zero
(which is to say, must encode a stride value of 1). We weren't
making this encoding check, so would incorrectly treat some
instruction patterns as being a VLD1/VST1 when they should UNDEF.
(https://gitlab.com/qemu-project/qemu/-/issues/890)
Patch 1 fixes that bug. Patch 2 is a minor cleanup of the align bits
check for VLD3/VST3 -- we had this logically correct (all the align
bits must be zero) but wrote it in a confusing way.
Richard: I tested this against your simple test case in the bug
report; if you could run it through your risu tests as well that
would be great.
thanks
-- PMM
Peter Maydell (2):
target/arm/translate-neon: UNDEF if VLD1/VST1 stride bits are non-zero
target/arm/translate-neon: Simplify align field check for VLD3
target/arm/translate-neon.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
--
2.25.1
next reply other threads:[~2022-03-03 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 11:37 Peter Maydell [this message]
2022-03-03 11:37 ` [PATCH 1/2] target/arm/translate-neon: UNDEF if VLD1/VST1 stride bits are non-zero Peter Maydell
2022-03-03 11:43 ` Peter Maydell
2022-03-03 16:10 ` Richard Henderson
2022-03-03 11:37 ` [PATCH 2/2] target/arm/translate-neon: Simplify align field check for VLD3 Peter Maydell
2022-03-03 16:11 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220303113741.2156877-1-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.