* [PATCH] ASoC: qcom: select correct WCD938X config for SC7280
@ 2022-03-04 16:09 ` Srinivas Kandagatla
0 siblings, 0 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2022-03-04 16:09 UTC (permalink / raw)
To: broonie
Cc: lgirdwood, perex, tiwai, pierre-louis.bossart, alsa-devel,
linux-kernel, quic_srivasam, Srinivas Kandagatla, Randy Dunlap
SC7280 config selected WCD938X instead of WCD938X_SDW Soundwire codecs.
WCD938X_SDW actually selects WCD938X, so directly selecting WCD938X results
in unmet dependencies and below warning
WARNING: unmet direct dependencies detected for SND_SOC_WCD938X
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=m]
&& SND_SOC_WCD938X_SDW [=n] && (SOUNDWIRE [=n] || !SOUNDWIRE [=n])
Selected by [m]:
- SND_SOC_SC7280 [=m] && SOUND [=y] && !UML && SND [=y]
&& SND_SOC [=m] && SND_SOC_QCOM [=m] && (I2C [=y] && SOUNDWIRE [=n] ||
COMPILE_TEST [=y])
Fix this issue by selecting WCD SoundWire codecs instead of component driver.
Fixes: 57350bd41c3a ("ASoC: qcom: SC7280: Add machine driver")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
sound/soc/qcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
index 0cd0dae5c545..82f5eafb2f6c 100644
--- a/sound/soc/qcom/Kconfig
+++ b/sound/soc/qcom/Kconfig
@@ -193,7 +193,7 @@ config SND_SOC_SC7280
select SND_SOC_QCOM_COMMON
select SND_SOC_LPASS_SC7280
select SND_SOC_MAX98357A
- select SND_SOC_WCD938X
+ select SND_SOC_WCD938X_SDW
select SND_SOC_LPASS_MACRO_COMMON
select SND_SOC_LPASS_RX_MACRO
select SND_SOC_LPASS_TX_MACRO
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ASoC: qcom: select correct WCD938X config for SC7280
@ 2022-03-04 16:09 ` Srinivas Kandagatla
0 siblings, 0 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2022-03-04 16:09 UTC (permalink / raw)
To: broonie
Cc: alsa-devel, lgirdwood, linux-kernel, Randy Dunlap,
pierre-louis.bossart, tiwai, Srinivas Kandagatla, quic_srivasam
SC7280 config selected WCD938X instead of WCD938X_SDW Soundwire codecs.
WCD938X_SDW actually selects WCD938X, so directly selecting WCD938X results
in unmet dependencies and below warning
WARNING: unmet direct dependencies detected for SND_SOC_WCD938X
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=m]
&& SND_SOC_WCD938X_SDW [=n] && (SOUNDWIRE [=n] || !SOUNDWIRE [=n])
Selected by [m]:
- SND_SOC_SC7280 [=m] && SOUND [=y] && !UML && SND [=y]
&& SND_SOC [=m] && SND_SOC_QCOM [=m] && (I2C [=y] && SOUNDWIRE [=n] ||
COMPILE_TEST [=y])
Fix this issue by selecting WCD SoundWire codecs instead of component driver.
Fixes: 57350bd41c3a ("ASoC: qcom: SC7280: Add machine driver")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
sound/soc/qcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
index 0cd0dae5c545..82f5eafb2f6c 100644
--- a/sound/soc/qcom/Kconfig
+++ b/sound/soc/qcom/Kconfig
@@ -193,7 +193,7 @@ config SND_SOC_SC7280
select SND_SOC_QCOM_COMMON
select SND_SOC_LPASS_SC7280
select SND_SOC_MAX98357A
- select SND_SOC_WCD938X
+ select SND_SOC_WCD938X_SDW
select SND_SOC_LPASS_MACRO_COMMON
select SND_SOC_LPASS_RX_MACRO
select SND_SOC_LPASS_TX_MACRO
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: qcom: select correct WCD938X config for SC7280
2022-03-04 16:09 ` Srinivas Kandagatla
@ 2022-03-07 20:39 ` Mark Brown
-1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-03-07 20:39 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: pierre-louis.bossart, lgirdwood, linux-kernel, quic_srivasam,
tiwai, alsa-devel, Randy Dunlap, perex
On Fri, 4 Mar 2022 16:09:34 +0000, Srinivas Kandagatla wrote:
> SC7280 config selected WCD938X instead of WCD938X_SDW Soundwire codecs.
> WCD938X_SDW actually selects WCD938X, so directly selecting WCD938X results
> in unmet dependencies and below warning
>
> WARNING: unmet direct dependencies detected for SND_SOC_WCD938X
> Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=m]
> && SND_SOC_WCD938X_SDW [=n] && (SOUNDWIRE [=n] || !SOUNDWIRE [=n])
> Selected by [m]:
> - SND_SOC_SC7280 [=m] && SOUND [=y] && !UML && SND [=y]
> && SND_SOC [=m] && SND_SOC_QCOM [=m] && (I2C [=y] && SOUNDWIRE [=n] ||
> COMPILE_TEST [=y])
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: qcom: select correct WCD938X config for SC7280
commit: 6ed5dbba6c971fe644f5c2b4aae436b39da99f18
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: qcom: select correct WCD938X config for SC7280
@ 2022-03-07 20:39 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-03-07 20:39 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: pierre-louis.bossart, alsa-devel, lgirdwood, Randy Dunlap,
linux-kernel, tiwai, quic_srivasam
On Fri, 4 Mar 2022 16:09:34 +0000, Srinivas Kandagatla wrote:
> SC7280 config selected WCD938X instead of WCD938X_SDW Soundwire codecs.
> WCD938X_SDW actually selects WCD938X, so directly selecting WCD938X results
> in unmet dependencies and below warning
>
> WARNING: unmet direct dependencies detected for SND_SOC_WCD938X
> Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=m]
> && SND_SOC_WCD938X_SDW [=n] && (SOUNDWIRE [=n] || !SOUNDWIRE [=n])
> Selected by [m]:
> - SND_SOC_SC7280 [=m] && SOUND [=y] && !UML && SND [=y]
> && SND_SOC [=m] && SND_SOC_QCOM [=m] && (I2C [=y] && SOUNDWIRE [=n] ||
> COMPILE_TEST [=y])
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: qcom: select correct WCD938X config for SC7280
commit: 6ed5dbba6c971fe644f5c2b4aae436b39da99f18
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-07 20:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-04 16:09 [PATCH] ASoC: qcom: select correct WCD938X config for SC7280 Srinivas Kandagatla
2022-03-04 16:09 ` Srinivas Kandagatla
2022-03-07 20:39 ` Mark Brown
2022-03-07 20:39 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.