* [PATCH] arm64: dts: rockchip: firefly: Fix SDIO regulator supply properties
@ 2022-03-04 20:25 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-03-04 20:25 UTC (permalink / raw)
To: Krzysztof Kozlowski, Heiko Stuebner
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
A label reference without brackets is a path string, not a phandle as
intended. Add the missing brackets.
Signed-off-by: Rob Herring <robh@kernel.org>
---
arch/arm64/boot/dts/rockchip/rk3399-firefly.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
index c4dd2a6b4836..f81ce3240342 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
@@ -770,8 +770,8 @@ &sdio0 {
sd-uhs-sdr104;
/* Power supply */
- vqmmc-supply = &vcc1v8_s3; /* IO line */
- vmmc-supply = &vcc_sdio; /* card's power */
+ vqmmc-supply = <&vcc1v8_s3>; /* IO line */
+ vmmc-supply = <&vcc_sdio>; /* card's power */
#address-cells = <1>;
#size-cells = <0>;
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: rockchip: firefly: Fix SDIO regulator supply properties
@ 2022-03-04 20:25 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-03-04 20:25 UTC (permalink / raw)
To: Krzysztof Kozlowski, Heiko Stuebner
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
A label reference without brackets is a path string, not a phandle as
intended. Add the missing brackets.
Signed-off-by: Rob Herring <robh@kernel.org>
---
arch/arm64/boot/dts/rockchip/rk3399-firefly.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
index c4dd2a6b4836..f81ce3240342 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
@@ -770,8 +770,8 @@ &sdio0 {
sd-uhs-sdr104;
/* Power supply */
- vqmmc-supply = &vcc1v8_s3; /* IO line */
- vmmc-supply = &vcc_sdio; /* card's power */
+ vqmmc-supply = <&vcc1v8_s3>; /* IO line */
+ vmmc-supply = <&vcc_sdio>; /* card's power */
#address-cells = <1>;
#size-cells = <0>;
--
2.32.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: rockchip: firefly: Fix SDIO regulator supply properties
@ 2022-03-04 20:25 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-03-04 20:25 UTC (permalink / raw)
To: Krzysztof Kozlowski, Heiko Stuebner
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
A label reference without brackets is a path string, not a phandle as
intended. Add the missing brackets.
Signed-off-by: Rob Herring <robh@kernel.org>
---
arch/arm64/boot/dts/rockchip/rk3399-firefly.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
index c4dd2a6b4836..f81ce3240342 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts
@@ -770,8 +770,8 @@ &sdio0 {
sd-uhs-sdr104;
/* Power supply */
- vqmmc-supply = &vcc1v8_s3; /* IO line */
- vmmc-supply = &vcc_sdio; /* card's power */
+ vqmmc-supply = <&vcc1v8_s3>; /* IO line */
+ vmmc-supply = <&vcc_sdio>; /* card's power */
#address-cells = <1>;
#size-cells = <0>;
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: firefly: Fix SDIO regulator supply properties
2022-03-04 20:25 ` Rob Herring
(?)
@ 2022-03-05 17:35 ` Heiko Stuebner
-1 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2022-03-05 17:35 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring
Cc: Heiko Stuebner, linux-arm-kernel, linux-kernel, linux-rockchip,
devicetree
On Fri, 4 Mar 2022 14:25:58 -0600, Rob Herring wrote:
> A label reference without brackets is a path string, not a phandle as
> intended. Add the missing brackets.
Applied, thanks!
[1/1] arm64: dts: rockchip: firefly: Fix SDIO regulator supply properties
commit: 37cbd3c522869247ed4525b5042ff4c6a276c813
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: firefly: Fix SDIO regulator supply properties
@ 2022-03-05 17:35 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2022-03-05 17:35 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring
Cc: Heiko Stuebner, linux-arm-kernel, linux-kernel, linux-rockchip,
devicetree
On Fri, 4 Mar 2022 14:25:58 -0600, Rob Herring wrote:
> A label reference without brackets is a path string, not a phandle as
> intended. Add the missing brackets.
Applied, thanks!
[1/1] arm64: dts: rockchip: firefly: Fix SDIO regulator supply properties
commit: 37cbd3c522869247ed4525b5042ff4c6a276c813
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: firefly: Fix SDIO regulator supply properties
@ 2022-03-05 17:35 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2022-03-05 17:35 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring
Cc: Heiko Stuebner, linux-arm-kernel, linux-kernel, linux-rockchip,
devicetree
On Fri, 4 Mar 2022 14:25:58 -0600, Rob Herring wrote:
> A label reference without brackets is a path string, not a phandle as
> intended. Add the missing brackets.
Applied, thanks!
[1/1] arm64: dts: rockchip: firefly: Fix SDIO regulator supply properties
commit: 37cbd3c522869247ed4525b5042ff4c6a276c813
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-05 17:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-04 20:25 [PATCH] arm64: dts: rockchip: firefly: Fix SDIO regulator supply properties Rob Herring
2022-03-04 20:25 ` Rob Herring
2022-03-04 20:25 ` Rob Herring
2022-03-05 17:35 ` Heiko Stuebner
2022-03-05 17:35 ` Heiko Stuebner
2022-03-05 17:35 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.