* [dunfell/master PATCH] pruss-fw: am57xx: Update hsr/prp/sw/dual-emac firmware
@ 2022-03-04 19:15 praneeth
2022-03-04 19:17 ` praneeth
2022-03-04 19:25 ` Ryan Eatmon
0 siblings, 2 replies; 7+ messages in thread
From: praneeth @ 2022-03-04 19:15 UTC (permalink / raw)
To: Praneeth Bajjuri, Ryan Eatmon, Denys Dmytriyenko, Yogesh Siraswar
Cc: Denys Dmytriyenko, meta-ti
commit 5a05d0b ("ti-pruss: Update AM57x PRP firmware to 002.020.035")
commit d88ee87 ("ti-pruss: Update AM57x HSR firmware to 002.020.035")
commit bc428f2 ("ti-pruss: Update AM57x Switch firmware to 003.002.012")
commit f154d9e ("ti-pruss: Update AM57x Dual-EMAC firmware to 005.006.018")
has updated hsr/prp/sw/dual-emac pruss firmware version for am57xx.
This fix is to update the version for am57xx and while at it
rename the recipes and capture the fix version for am335x, am437x and am57xx
in ti-linux-fw.inc.
Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
---
.../{prueth-fw_5.6.15.bb => prueth-fw.bb} | 3 +++
.../{pruhsr-fw_2.17.25.bb => pruhsr-fw.bb} | 3 +++
.../{pruprp-fw_2.17.25.bb => pruprp-fw.bb} | 3 +++
.../prusw-fw/{prusw-fw_3.2.9.bb => prusw-fw.bb} | 3 +++
recipes-bsp/ti-linux-fw/ti-linux-fw.inc | 14 +++++++++++++-
5 files changed, 25 insertions(+), 1 deletion(-)
rename recipes-bsp/prueth-fw/{prueth-fw_5.6.15.bb => prueth-fw.bb} (88%)
rename recipes-bsp/pruhsr-fw/{pruhsr-fw_2.17.25.bb => pruhsr-fw.bb} (88%)
rename recipes-bsp/pruprp-fw/{pruprp-fw_2.17.25.bb => pruprp-fw.bb} (88%)
rename recipes-bsp/prusw-fw/{prusw-fw_3.2.9.bb => prusw-fw.bb} (88%)
diff --git a/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb b/recipes-bsp/prueth-fw/prueth-fw.bb
similarity index 88%
rename from recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
rename to recipes-bsp/prueth-fw/prueth-fw.bb
index f7336fb1..e41bb3c0 100644
--- a/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
+++ b/recipes-bsp/prueth-fw/prueth-fw.bb
@@ -2,6 +2,9 @@ SUMMARY = "PRU Ethernet firmware for AM57xx, AM437x and AM335x"
require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
+PV = "${PRUETH_FW_AM335X_VERSION}"
+PV = "${PRUETH_FW_AM437X_VERSION}"
+PV = "${PRUETH_FW_AM57XX_VERSION}"
PR = "${INC_PR}.0"
CLEANBROKEN = "1"
diff --git a/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb b/recipes-bsp/pruhsr-fw/pruhsr-fw.bb
similarity index 88%
rename from recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb
rename to recipes-bsp/pruhsr-fw/pruhsr-fw.bb
index 507a500b..1decd3d6 100644
--- a/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb
+++ b/recipes-bsp/pruhsr-fw/pruhsr-fw.bb
@@ -3,6 +3,9 @@ SUMMARY = "PRU HSR firmware for AM335x/AM437x/AM57xx"
require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
PE = "1"
+PV = "${PRUHSR_FW_AM335X_VERSION}"
+PV = "${PRUHSR_FW_AM437X_VERSION}"
+PV = "${PRUHSR_FW_AM57XX_VERSION}"
PR = "${INC_PR}.0"
CLEANBROKEN = "1"
diff --git a/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb b/recipes-bsp/pruprp-fw/pruprp-fw.bb
similarity index 88%
rename from recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb
rename to recipes-bsp/pruprp-fw/pruprp-fw.bb
index ba203948..656a640b 100644
--- a/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb
+++ b/recipes-bsp/pruprp-fw/pruprp-fw.bb
@@ -3,6 +3,9 @@ SUMMARY = "PRU PRP firmware for AM335x/AM437x/AM57xx"
require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
PE = "1"
+PV = "${PRUPRP_FW_AM335X_VERSION}"
+PV = "${PRUPRP_FW_AM437X_VERSION}"
+PV = "${PRUPRP_FW_AM57XX_VERSION}"
PR = "${INC_PR}.0"
CLEANBROKEN = "1"
diff --git a/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb b/recipes-bsp/prusw-fw/prusw-fw.bb
similarity index 88%
rename from recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb
rename to recipes-bsp/prusw-fw/prusw-fw.bb
index ec0a15f4..ce0e5013 100644
--- a/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb
+++ b/recipes-bsp/prusw-fw/prusw-fw.bb
@@ -2,6 +2,9 @@ SUMMARY = "PRU Switch firmware for AM57xx, AM437x and AM335x"
require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
+PV = "${PRUSW_FW_AM335X_VERSION}"
+PV = "${PRUSW_FW_AM437X_VERSION}"
+PV = "${PRUSW_FW_AM57XX_VERSION}"
PR = "${INC_PR}.0"
CLEANBROKEN = "1"
diff --git a/recipes-bsp/ti-linux-fw/ti-linux-fw.inc b/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
index fced78fd..368b203f 100644
--- a/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
+++ b/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
@@ -12,14 +12,26 @@ SERDES_FW_VERSION = "3.3.0.2c"
NETCP_SA_FW_VERSION = "1.0.0"
NETCP_PA_FW_VERSION = "3.0.2.3"
QMSS_PDSP_FW_VERSION = "1.0.0.9"
+PRUETH_FW_AM335X_VERSION = "REL.PDK_ICSS_EMAC_FW_08.01.00"
+PRUETH_FW_AM437X_VERSION "REL.PDK_ICSS_EMAC_FW_08.01.00"
+PRUETH_FW_AM57XX_VERSION = "5.6.18"
PRUETH_FW_AM65X_VERSION = "08.00.00.20"
PRUETH_FW_AM65X_SR2_VERSION = "02.02.09.07"
+PRUHSR_FW_AM335X_VERSION = "2.17.25"
+PRUHSR_FW_AM437X_VERSION = "2.17.25"
+PRUHSR_FW_AM57XX_VERSION = "2.20.35"
+PRUPRP_FW_AM335X_VERSION = "2.17.25"
+PRUPRP_FW_AM437X_VERSION = "2.17.25"
+PRUPRP_FW_AM57XX_VERSION = "2.20.35"
+PRUSW_FW_AM335X_VERSION = "3.2.7"
+PRUSW_FW_AM437X_VERSION = "3.2.7"
+PRUSW_FW_AM57XX_VERSION = "3.2.12"
GOODIX_FW_VERSION = "1.0.0.0"
CADENCE_MHDP_FW_VERSION = "1.2.17"
IMG_DEC_FW_VERSION = "1.0"
CNM_WAVE521_FW_VERSION = "1.0.00"
-TI_LINUX_FW_SRCREV ?= "8810faf0c51a80554150e185122e43bee1553c37"
+TI_LINUX_FW_SRCREV ?= "0f4905088d24e474063f33777559149e11538be5"
SRCREV = "${TI_LINUX_FW_SRCREV}"
BRANCH ?= "ti-linux-firmware"
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [dunfell/master PATCH] pruss-fw: am57xx: Update hsr/prp/sw/dual-emac firmware
2022-03-04 19:15 [dunfell/master PATCH] pruss-fw: am57xx: Update hsr/prp/sw/dual-emac firmware praneeth
@ 2022-03-04 19:17 ` praneeth
2022-03-04 19:25 ` Ryan Eatmon
1 sibling, 0 replies; 7+ messages in thread
From: praneeth @ 2022-03-04 19:17 UTC (permalink / raw)
To: Ryan Eatmon, Denys Dmytriyenko, Yogesh Siraswar
Cc: Denys Dmytriyenko, meta-ti
On 3/4/2022 1:15 PM, Praneeth Bajjuri wrote:
> commit 5a05d0b ("ti-pruss: Update AM57x PRP firmware to 002.020.035")
> commit d88ee87 ("ti-pruss: Update AM57x HSR firmware to 002.020.035")
> commit bc428f2 ("ti-pruss: Update AM57x Switch firmware to 003.002.012")
> commit f154d9e ("ti-pruss: Update AM57x Dual-EMAC firmware to 005.006.018")
>
> has updated hsr/prp/sw/dual-emac pruss firmware version for am57xx.
>
> This fix is to update the version for am57xx and while at it
> rename the recipes and capture the fix version for am335x, am437x and am57xx
> in ti-linux-fw.inc.
>
Ryan,
Have not chance to test this patch. Please review and verify.
> Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
> ---
> .../{prueth-fw_5.6.15.bb => prueth-fw.bb} | 3 +++
> .../{pruhsr-fw_2.17.25.bb => pruhsr-fw.bb} | 3 +++
> .../{pruprp-fw_2.17.25.bb => pruprp-fw.bb} | 3 +++
> .../prusw-fw/{prusw-fw_3.2.9.bb => prusw-fw.bb} | 3 +++
> recipes-bsp/ti-linux-fw/ti-linux-fw.inc | 14 +++++++++++++-
> 5 files changed, 25 insertions(+), 1 deletion(-)
> rename recipes-bsp/prueth-fw/{prueth-fw_5.6.15.bb => prueth-fw.bb} (88%)
> rename recipes-bsp/pruhsr-fw/{pruhsr-fw_2.17.25.bb => pruhsr-fw.bb} (88%)
> rename recipes-bsp/pruprp-fw/{pruprp-fw_2.17.25.bb => pruprp-fw.bb} (88%)
> rename recipes-bsp/prusw-fw/{prusw-fw_3.2.9.bb => prusw-fw.bb} (88%)
>
> diff --git a/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb b/recipes-bsp/prueth-fw/prueth-fw.bb
> similarity index 88%
> rename from recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
> rename to recipes-bsp/prueth-fw/prueth-fw.bb
> index f7336fb1..e41bb3c0 100644
> --- a/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
> +++ b/recipes-bsp/prueth-fw/prueth-fw.bb
> @@ -2,6 +2,9 @@ SUMMARY = "PRU Ethernet firmware for AM57xx, AM437x and AM335x"
>
> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>
> +PV = "${PRUETH_FW_AM335X_VERSION}"
> +PV = "${PRUETH_FW_AM437X_VERSION}"
> +PV = "${PRUETH_FW_AM57XX_VERSION}"
> PR = "${INC_PR}.0"
>
> CLEANBROKEN = "1"
> diff --git a/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb b/recipes-bsp/pruhsr-fw/pruhsr-fw.bb
> similarity index 88%
> rename from recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb
> rename to recipes-bsp/pruhsr-fw/pruhsr-fw.bb
> index 507a500b..1decd3d6 100644
> --- a/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb
> +++ b/recipes-bsp/pruhsr-fw/pruhsr-fw.bb
> @@ -3,6 +3,9 @@ SUMMARY = "PRU HSR firmware for AM335x/AM437x/AM57xx"
> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>
> PE = "1"
> +PV = "${PRUHSR_FW_AM335X_VERSION}"
> +PV = "${PRUHSR_FW_AM437X_VERSION}"
> +PV = "${PRUHSR_FW_AM57XX_VERSION}"
> PR = "${INC_PR}.0"
>
> CLEANBROKEN = "1"
> diff --git a/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb b/recipes-bsp/pruprp-fw/pruprp-fw.bb
> similarity index 88%
> rename from recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb
> rename to recipes-bsp/pruprp-fw/pruprp-fw.bb
> index ba203948..656a640b 100644
> --- a/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb
> +++ b/recipes-bsp/pruprp-fw/pruprp-fw.bb
> @@ -3,6 +3,9 @@ SUMMARY = "PRU PRP firmware for AM335x/AM437x/AM57xx"
> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>
> PE = "1"
> +PV = "${PRUPRP_FW_AM335X_VERSION}"
> +PV = "${PRUPRP_FW_AM437X_VERSION}"
> +PV = "${PRUPRP_FW_AM57XX_VERSION}"
> PR = "${INC_PR}.0"
>
> CLEANBROKEN = "1"
> diff --git a/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb b/recipes-bsp/prusw-fw/prusw-fw.bb
> similarity index 88%
> rename from recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb
> rename to recipes-bsp/prusw-fw/prusw-fw.bb
> index ec0a15f4..ce0e5013 100644
> --- a/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb
> +++ b/recipes-bsp/prusw-fw/prusw-fw.bb
> @@ -2,6 +2,9 @@ SUMMARY = "PRU Switch firmware for AM57xx, AM437x and AM335x"
>
> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>
> +PV = "${PRUSW_FW_AM335X_VERSION}"
> +PV = "${PRUSW_FW_AM437X_VERSION}"
> +PV = "${PRUSW_FW_AM57XX_VERSION}"
> PR = "${INC_PR}.0"
>
> CLEANBROKEN = "1"
> diff --git a/recipes-bsp/ti-linux-fw/ti-linux-fw.inc b/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> index fced78fd..368b203f 100644
> --- a/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> +++ b/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> @@ -12,14 +12,26 @@ SERDES_FW_VERSION = "3.3.0.2c"
> NETCP_SA_FW_VERSION = "1.0.0"
> NETCP_PA_FW_VERSION = "3.0.2.3"
> QMSS_PDSP_FW_VERSION = "1.0.0.9"
> +PRUETH_FW_AM335X_VERSION = "REL.PDK_ICSS_EMAC_FW_08.01.00"
> +PRUETH_FW_AM437X_VERSION "REL.PDK_ICSS_EMAC_FW_08.01.00"
> +PRUETH_FW_AM57XX_VERSION = "5.6.18"
> PRUETH_FW_AM65X_VERSION = "08.00.00.20"
> PRUETH_FW_AM65X_SR2_VERSION = "02.02.09.07"
> +PRUHSR_FW_AM335X_VERSION = "2.17.25"
> +PRUHSR_FW_AM437X_VERSION = "2.17.25"
> +PRUHSR_FW_AM57XX_VERSION = "2.20.35"
> +PRUPRP_FW_AM335X_VERSION = "2.17.25"
> +PRUPRP_FW_AM437X_VERSION = "2.17.25"
> +PRUPRP_FW_AM57XX_VERSION = "2.20.35"
> +PRUSW_FW_AM335X_VERSION = "3.2.7"
> +PRUSW_FW_AM437X_VERSION = "3.2.7"
> +PRUSW_FW_AM57XX_VERSION = "3.2.12"
> GOODIX_FW_VERSION = "1.0.0.0"
> CADENCE_MHDP_FW_VERSION = "1.2.17"
> IMG_DEC_FW_VERSION = "1.0"
> CNM_WAVE521_FW_VERSION = "1.0.00"
>
> -TI_LINUX_FW_SRCREV ?= "8810faf0c51a80554150e185122e43bee1553c37"
> +TI_LINUX_FW_SRCREV ?= "0f4905088d24e474063f33777559149e11538be5"
> SRCREV = "${TI_LINUX_FW_SRCREV}"
>
> BRANCH ?= "ti-linux-firmware"
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dunfell/master PATCH] pruss-fw: am57xx: Update hsr/prp/sw/dual-emac firmware
2022-03-04 19:15 [dunfell/master PATCH] pruss-fw: am57xx: Update hsr/prp/sw/dual-emac firmware praneeth
2022-03-04 19:17 ` praneeth
@ 2022-03-04 19:25 ` Ryan Eatmon
2022-03-04 19:40 ` praneeth
1 sibling, 1 reply; 7+ messages in thread
From: Ryan Eatmon @ 2022-03-04 19:25 UTC (permalink / raw)
To: Praneeth Bajjuri, Denys Dmytriyenko, Yogesh Siraswar
Cc: Denys Dmytriyenko, meta-ti
On 3/4/2022 13:15, Praneeth Bajjuri wrote:
> commit 5a05d0b ("ti-pruss: Update AM57x PRP firmware to 002.020.035")
> commit d88ee87 ("ti-pruss: Update AM57x HSR firmware to 002.020.035")
> commit bc428f2 ("ti-pruss: Update AM57x Switch firmware to 003.002.012")
> commit f154d9e ("ti-pruss: Update AM57x Dual-EMAC firmware to 005.006.018")
>
> has updated hsr/prp/sw/dual-emac pruss firmware version for am57xx.
>
> This fix is to update the version for am57xx and while at it
> rename the recipes and capture the fix version for am335x, am437x and am57xx
> in ti-linux-fw.inc.
>
> Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
> ---
> .../{prueth-fw_5.6.15.bb => prueth-fw.bb} | 3 +++
> .../{pruhsr-fw_2.17.25.bb => pruhsr-fw.bb} | 3 +++
> .../{pruprp-fw_2.17.25.bb => pruprp-fw.bb} | 3 +++
> .../prusw-fw/{prusw-fw_3.2.9.bb => prusw-fw.bb} | 3 +++
> recipes-bsp/ti-linux-fw/ti-linux-fw.inc | 14 +++++++++++++-
> 5 files changed, 25 insertions(+), 1 deletion(-)
> rename recipes-bsp/prueth-fw/{prueth-fw_5.6.15.bb => prueth-fw.bb} (88%)
> rename recipes-bsp/pruhsr-fw/{pruhsr-fw_2.17.25.bb => pruhsr-fw.bb} (88%)
> rename recipes-bsp/pruprp-fw/{pruprp-fw_2.17.25.bb => pruprp-fw.bb} (88%)
> rename recipes-bsp/prusw-fw/{prusw-fw_3.2.9.bb => prusw-fw.bb} (88%)
>
> diff --git a/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb b/recipes-bsp/prueth-fw/prueth-fw.bb
> similarity index 88%
> rename from recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
> rename to recipes-bsp/prueth-fw/prueth-fw.bb
> index f7336fb1..e41bb3c0 100644
> --- a/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
> +++ b/recipes-bsp/prueth-fw/prueth-fw.bb
> @@ -2,6 +2,9 @@ SUMMARY = "PRU Ethernet firmware for AM57xx, AM437x and AM335x"
>
> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>
> +PV = "${PRUETH_FW_AM335X_VERSION}"
> +PV = "${PRUETH_FW_AM437X_VERSION}"
> +PV = "${PRUETH_FW_AM57XX_VERSION}"
> PR = "${INC_PR}.0"
I think you need to uniquify the PV variable for each platform. Right
now you are just resetting each time and not overriding it.
PV_am335x-evm = "${PRUETH_FW_AM335X_VERSION}"
etc...
> CLEANBROKEN = "1"
> diff --git a/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb b/recipes-bsp/pruhsr-fw/pruhsr-fw.bb
> similarity index 88%
> rename from recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb
> rename to recipes-bsp/pruhsr-fw/pruhsr-fw.bb
> index 507a500b..1decd3d6 100644
> --- a/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb
> +++ b/recipes-bsp/pruhsr-fw/pruhsr-fw.bb
> @@ -3,6 +3,9 @@ SUMMARY = "PRU HSR firmware for AM335x/AM437x/AM57xx"
> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>
> PE = "1"
> +PV = "${PRUHSR_FW_AM335X_VERSION}"
> +PV = "${PRUHSR_FW_AM437X_VERSION}"
> +PV = "${PRUHSR_FW_AM57XX_VERSION}"
> PR = "${INC_PR}.0"
Same here.
> CLEANBROKEN = "1"
> diff --git a/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb b/recipes-bsp/pruprp-fw/pruprp-fw.bb
> similarity index 88%
> rename from recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb
> rename to recipes-bsp/pruprp-fw/pruprp-fw.bb
> index ba203948..656a640b 100644
> --- a/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb
> +++ b/recipes-bsp/pruprp-fw/pruprp-fw.bb
> @@ -3,6 +3,9 @@ SUMMARY = "PRU PRP firmware for AM335x/AM437x/AM57xx"
> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>
> PE = "1"
> +PV = "${PRUPRP_FW_AM335X_VERSION}"
> +PV = "${PRUPRP_FW_AM437X_VERSION}"
> +PV = "${PRUPRP_FW_AM57XX_VERSION}"
> PR = "${INC_PR}.0"
Same here.
> CLEANBROKEN = "1"
> diff --git a/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb b/recipes-bsp/prusw-fw/prusw-fw.bb
> similarity index 88%
> rename from recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb
> rename to recipes-bsp/prusw-fw/prusw-fw.bb
> index ec0a15f4..ce0e5013 100644
> --- a/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb
> +++ b/recipes-bsp/prusw-fw/prusw-fw.bb
> @@ -2,6 +2,9 @@ SUMMARY = "PRU Switch firmware for AM57xx, AM437x and AM335x"
>
> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>
> +PV = "${PRUSW_FW_AM335X_VERSION}"
> +PV = "${PRUSW_FW_AM437X_VERSION}"
> +PV = "${PRUSW_FW_AM57XX_VERSION}"
> PR = "${INC_PR}.0"
Same here.
> CLEANBROKEN = "1"
> diff --git a/recipes-bsp/ti-linux-fw/ti-linux-fw.inc b/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> index fced78fd..368b203f 100644
> --- a/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> +++ b/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> @@ -12,14 +12,26 @@ SERDES_FW_VERSION = "3.3.0.2c"
> NETCP_SA_FW_VERSION = "1.0.0"
> NETCP_PA_FW_VERSION = "3.0.2.3"
> QMSS_PDSP_FW_VERSION = "1.0.0.9"
> +PRUETH_FW_AM335X_VERSION = "REL.PDK_ICSS_EMAC_FW_08.01.00"
> +PRUETH_FW_AM437X_VERSION "REL.PDK_ICSS_EMAC_FW_08.01.00"
> +PRUETH_FW_AM57XX_VERSION = "5.6.18"
> PRUETH_FW_AM65X_VERSION = "08.00.00.20"
> PRUETH_FW_AM65X_SR2_VERSION = "02.02.09.07"
> +PRUHSR_FW_AM335X_VERSION = "2.17.25"
> +PRUHSR_FW_AM437X_VERSION = "2.17.25"
> +PRUHSR_FW_AM57XX_VERSION = "2.20.35"
> +PRUPRP_FW_AM335X_VERSION = "2.17.25"
> +PRUPRP_FW_AM437X_VERSION = "2.17.25"
> +PRUPRP_FW_AM57XX_VERSION = "2.20.35"
> +PRUSW_FW_AM335X_VERSION = "3.2.7"
> +PRUSW_FW_AM437X_VERSION = "3.2.7"
> +PRUSW_FW_AM57XX_VERSION = "3.2.12"
> GOODIX_FW_VERSION = "1.0.0.0"
> CADENCE_MHDP_FW_VERSION = "1.2.17"
> IMG_DEC_FW_VERSION = "1.0"
> CNM_WAVE521_FW_VERSION = "1.0.00"
>
> -TI_LINUX_FW_SRCREV ?= "8810faf0c51a80554150e185122e43bee1553c37"
> +TI_LINUX_FW_SRCREV ?= "0f4905088d24e474063f33777559149e11538be5"
> SRCREV = "${TI_LINUX_FW_SRCREV}"
>
> BRANCH ?= "ti-linux-firmware"
--
Ryan Eatmon
reatmon@ti.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dunfell/master PATCH] pruss-fw: am57xx: Update hsr/prp/sw/dual-emac firmware
2022-03-04 19:25 ` Ryan Eatmon
@ 2022-03-04 19:40 ` praneeth
2022-03-04 20:06 ` Ryan Eatmon
0 siblings, 1 reply; 7+ messages in thread
From: praneeth @ 2022-03-04 19:40 UTC (permalink / raw)
To: Ryan Eatmon, Denys Dmytriyenko, Yogesh Siraswar
Cc: Denys Dmytriyenko, meta-ti, Priya N S, Kishon Vijay Abraham,
Vignesh Raghavendra
On 3/4/2022 1:25 PM, Ryan Eatmon wrote:
>> diff --git a/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
>> b/recipes-bsp/prueth-fw/prueth-fw.bb
>> similarity index 88%
>> rename from recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
>> rename to recipes-bsp/prueth-fw/prueth-fw.bb
>> index f7336fb1..e41bb3c0 100644
>> --- a/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
>> +++ b/recipes-bsp/prueth-fw/prueth-fw.bb
>> @@ -2,6 +2,9 @@ SUMMARY = "PRU Ethernet firmware for AM57xx, AM437x
>> and AM335x"
>> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>> +PV = "${PRUETH_FW_AM335X_VERSION}"
>> +PV = "${PRUETH_FW_AM437X_VERSION}"
>> +PV = "${PRUETH_FW_AM57XX_VERSION}"
>> PR = "${INC_PR}.0"
>
> I think you need to uniquify the PV variable for each platform. Right
> now you are just resetting each time and not overriding it.
>
> PV_am335x-evm = "${PRUETH_FW_AM335X_VERSION}"
> etc...
Thanks for the quick review,
Does this work instead? PV_ti-soc?
The FW version for each platform could be different as the mentioned
commit in commitmessage points to updating the firmware only for am57xx
but not for am335x/am437x.
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dunfell/master PATCH] pruss-fw: am57xx: Update hsr/prp/sw/dual-emac firmware
2022-03-04 19:40 ` praneeth
@ 2022-03-04 20:06 ` Ryan Eatmon
2022-03-04 20:24 ` Denys Dmytriyenko
[not found] ` <16D94741C899AE2B.14701@lists.yoctoproject.org>
0 siblings, 2 replies; 7+ messages in thread
From: Ryan Eatmon @ 2022-03-04 20:06 UTC (permalink / raw)
To: Bajjuri, Praneeth, Denys Dmytriyenko, Yogesh Siraswar
Cc: Denys Dmytriyenko, meta-ti, Priya N S, Kishon Vijay Abraham,
Vignesh Raghavendra
On 3/4/2022 13:40, Bajjuri, Praneeth wrote:
>
>
> On 3/4/2022 1:25 PM, Ryan Eatmon wrote:
>>> diff --git a/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
>>> b/recipes-bsp/prueth-fw/prueth-fw.bb
>>> similarity index 88%
>>> rename from recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
>>> rename to recipes-bsp/prueth-fw/prueth-fw.bb
>>> index f7336fb1..e41bb3c0 100644
>>> --- a/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
>>> +++ b/recipes-bsp/prueth-fw/prueth-fw.bb
>>> @@ -2,6 +2,9 @@ SUMMARY = "PRU Ethernet firmware for AM57xx, AM437x
>>> and AM335x"
>>> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
>>> +PV = "${PRUETH_FW_AM335X_VERSION}"
>>> +PV = "${PRUETH_FW_AM437X_VERSION}"
>>> +PV = "${PRUETH_FW_AM57XX_VERSION}"
>>> PR = "${INC_PR}.0"
>>
>> I think you need to uniquify the PV variable for each platform. Right
>> now you are just resetting each time and not overriding it.
>>
>> PV_am335x-evm = "${PRUETH_FW_AM335X_VERSION}"
>> etc...
>
> Thanks for the quick review,
> Does this work instead? PV_ti-soc?
>
> The FW version for each platform could be different as the mentioned
> commit in commitmessage points to updating the firmware only for am57xx
> but not for am335x/am437x.
While I think that might technically work, there are only three machines
that come into these recipes. I think it would be more confusing for
someone reading the recipe to wonder what all makes up ti-soc, rather
than just seeing the three specific variables called out. Plus you
created three variables in the ti-linux-fw.inc. It would fit more in
line with other things in the same recipe to just list them out:
TARGET = ""
TARGET_ti33x = "am335x-pru0-prueth-fw.elf am335x-pru1-prueth-fw.elf"
TARGET_ti43x = "am437x-pru0-prueth-fw.elf am437x-pru1-prueth-fw.elf"
TARGET_am57xx-evm = "am57xx-pru0-prueth-fw.elf am57xx-pru1-prueth-fw.elf"
TARGET_am57xx-hs-evm = "am57xx-pru0-prueth-fw.elf am57xx-pru1-prueth-fw.elf"
and
PV = ""
PV_ti33x = "${PRUETH_FW_AM335X_VERSION}"
PV_ti43x = "${PRUETH_FW_AM437X_VERSION}"
PV_am57xx-evm = "${PRUETH_FW_AM57XX_VERSION}"
PV_am57xx-hs-evm = "${PRUETH_FW_AM57XX_VERSION}"
>
>>
--
Ryan Eatmon
reatmon@ti.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dunfell/master PATCH] pruss-fw: am57xx: Update hsr/prp/sw/dual-emac firmware
2022-03-04 20:06 ` Ryan Eatmon
@ 2022-03-04 20:24 ` Denys Dmytriyenko
[not found] ` <16D94741C899AE2B.14701@lists.yoctoproject.org>
1 sibling, 0 replies; 7+ messages in thread
From: Denys Dmytriyenko @ 2022-03-04 20:24 UTC (permalink / raw)
To: Ryan Eatmon
Cc: Bajjuri, Praneeth, Yogesh Siraswar, Denys Dmytriyenko, meta-ti,
Priya N S, Kishon Vijay Abraham, Vignesh Raghavendra
On Fri, Mar 04, 2022 at 02:06:47PM -0600, Ryan Eatmon wrote:
>
>
> On 3/4/2022 13:40, Bajjuri, Praneeth wrote:
> >
> >
> >On 3/4/2022 1:25 PM, Ryan Eatmon wrote:
> >>>diff --git a/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
> >>>b/recipes-bsp/prueth-fw/prueth-fw.bb
> >>>similarity index 88%
> >>>rename from recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
> >>>rename to recipes-bsp/prueth-fw/prueth-fw.bb
> >>>index f7336fb1..e41bb3c0 100644
> >>>--- a/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
> >>>+++ b/recipes-bsp/prueth-fw/prueth-fw.bb
> >>>@@ -2,6 +2,9 @@ SUMMARY = "PRU Ethernet firmware for AM57xx,
> >>>AM437x and AM335x"
> >>> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> >>>+PV = "${PRUETH_FW_AM335X_VERSION}"
> >>>+PV = "${PRUETH_FW_AM437X_VERSION}"
> >>>+PV = "${PRUETH_FW_AM57XX_VERSION}"
> >>> PR = "${INC_PR}.0"
> >>
> >>I think you need to uniquify the PV variable for each platform.
> >>Right now you are just resetting each time and not overriding
> >>it.
> >>
> >>PV_am335x-evm = "${PRUETH_FW_AM335X_VERSION}"
> >>etc...
> >
> >Thanks for the quick review,
> >Does this work instead? PV_ti-soc?
> >
> >The FW version for each platform could be different as the
> >mentioned commit in commitmessage points to updating the firmware
> >only for am57xx but not for am335x/am437x.
>
> While I think that might technically work, there are only three
> machines that come into these recipes. I think it would be more
> confusing for someone reading the recipe to wonder what all makes up
> ti-soc, rather than just seeing the three specific variables called
> out. Plus you created three variables in the ti-linux-fw.inc. It
> would fit more in line with other things in the same recipe to just
> list them out:
>
>
> TARGET = ""
> TARGET_ti33x = "am335x-pru0-prueth-fw.elf am335x-pru1-prueth-fw.elf"
> TARGET_ti43x = "am437x-pru0-prueth-fw.elf am437x-pru1-prueth-fw.elf"
> TARGET_am57xx-evm = "am57xx-pru0-prueth-fw.elf am57xx-pru1-prueth-fw.elf"
> TARGET_am57xx-hs-evm = "am57xx-pru0-prueth-fw.elf am57xx-pru1-prueth-fw.elf"
>
> and
>
> PV = ""
> PV_ti33x = "${PRUETH_FW_AM335X_VERSION}"
> PV_ti43x = "${PRUETH_FW_AM437X_VERSION}"
> PV_am57xx-evm = "${PRUETH_FW_AM57XX_VERSION}"
> PV_am57xx-hs-evm = "${PRUETH_FW_AM57XX_VERSION}"
No, PV_ti-soc won't work, it will be the same as plain PV and won't use the
correct value per platform.
What Ryan explains is correct - need an override per platform.
BTW, master uses a different override syntax, so this won't apply to master or
kirkstone and would need to be updated...
--
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186 6D76 4209 0272 9A92 C964
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti] [dunfell/master PATCH] pruss-fw: am57xx: Update hsr/prp/sw/dual-emac firmware
[not found] ` <16D94741C899AE2B.14701@lists.yoctoproject.org>
@ 2022-03-04 20:30 ` Denys Dmytriyenko
0 siblings, 0 replies; 7+ messages in thread
From: Denys Dmytriyenko @ 2022-03-04 20:30 UTC (permalink / raw)
To: Ryan Eatmon
Cc: Bajjuri, Praneeth, Yogesh Siraswar, Denys Dmytriyenko, meta-ti,
Priya N S, Kishon Vijay Abraham, Vignesh Raghavendra
On Fri, Mar 04, 2022 at 03:24:37PM -0500, Denys Dmytriyenko wrote:
> On Fri, Mar 04, 2022 at 02:06:47PM -0600, Ryan Eatmon wrote:
> >
> >
> > On 3/4/2022 13:40, Bajjuri, Praneeth wrote:
> > >
> > >
> > >On 3/4/2022 1:25 PM, Ryan Eatmon wrote:
> > >>>diff --git a/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
> > >>>b/recipes-bsp/prueth-fw/prueth-fw.bb
Also, might want to name it prueth-fw_git.bb - not required, just a naming
convention to indicate it is pulled from git and version is set by recipe.
> > >>>similarity index 88%
> > >>>rename from recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
> > >>>rename to recipes-bsp/prueth-fw/prueth-fw.bb
> > >>>index f7336fb1..e41bb3c0 100644
> > >>>--- a/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
> > >>>+++ b/recipes-bsp/prueth-fw/prueth-fw.bb
> > >>>@@ -2,6 +2,9 @@ SUMMARY = "PRU Ethernet firmware for AM57xx,
> > >>>AM437x and AM335x"
> > >>> require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> > >>>+PV = "${PRUETH_FW_AM335X_VERSION}"
> > >>>+PV = "${PRUETH_FW_AM437X_VERSION}"
> > >>>+PV = "${PRUETH_FW_AM57XX_VERSION}"
> > >>> PR = "${INC_PR}.0"
> > >>
> > >>I think you need to uniquify the PV variable for each platform.
> > >>Right now you are just resetting each time and not overriding
> > >>it.
> > >>
> > >>PV_am335x-evm = "${PRUETH_FW_AM335X_VERSION}"
> > >>etc...
> > >
> > >Thanks for the quick review,
> > >Does this work instead? PV_ti-soc?
> > >
> > >The FW version for each platform could be different as the
> > >mentioned commit in commitmessage points to updating the firmware
> > >only for am57xx but not for am335x/am437x.
> >
> > While I think that might technically work, there are only three
> > machines that come into these recipes. I think it would be more
> > confusing for someone reading the recipe to wonder what all makes up
> > ti-soc, rather than just seeing the three specific variables called
> > out. Plus you created three variables in the ti-linux-fw.inc. It
> > would fit more in line with other things in the same recipe to just
> > list them out:
> >
> >
> > TARGET = ""
> > TARGET_ti33x = "am335x-pru0-prueth-fw.elf am335x-pru1-prueth-fw.elf"
> > TARGET_ti43x = "am437x-pru0-prueth-fw.elf am437x-pru1-prueth-fw.elf"
> > TARGET_am57xx-evm = "am57xx-pru0-prueth-fw.elf am57xx-pru1-prueth-fw.elf"
> > TARGET_am57xx-hs-evm = "am57xx-pru0-prueth-fw.elf am57xx-pru1-prueth-fw.elf"
> >
> > and
> >
> > PV = ""
> > PV_ti33x = "${PRUETH_FW_AM335X_VERSION}"
> > PV_ti43x = "${PRUETH_FW_AM437X_VERSION}"
> > PV_am57xx-evm = "${PRUETH_FW_AM57XX_VERSION}"
> > PV_am57xx-hs-evm = "${PRUETH_FW_AM57XX_VERSION}"
>
> No, PV_ti-soc won't work, it will be the same as plain PV and won't use the
> correct value per platform.
>
> What Ryan explains is correct - need an override per platform.
>
> BTW, master uses a different override syntax, so this won't apply to master or
> kirkstone and would need to be updated...
--
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186 6D76 4209 0272 9A92 C964
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-03-04 20:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-04 19:15 [dunfell/master PATCH] pruss-fw: am57xx: Update hsr/prp/sw/dual-emac firmware praneeth
2022-03-04 19:17 ` praneeth
2022-03-04 19:25 ` Ryan Eatmon
2022-03-04 19:40 ` praneeth
2022-03-04 20:06 ` Ryan Eatmon
2022-03-04 20:24 ` Denys Dmytriyenko
[not found] ` <16D94741C899AE2B.14701@lists.yoctoproject.org>
2022-03-04 20:30 ` [meta-ti] " Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.