All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>,
	axboe@kernel.dk, sagi@grimberg.me, kbusch@kernel.org,
	song@kernel.org, linux-block@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] block: remove the per-bio/request write hint
Date: Sat, 5 Mar 2022 06:19:29 +0100	[thread overview]
Message-ID: <20220305051929.GA24696@lst.de> (raw)
In-Reply-To: <20220304221255.GL3927073@dread.disaster.area>

On Sat, Mar 05, 2022 at 09:12:55AM +1100, Dave Chinner wrote:
> AFAICT, all the filesystem/IO path passthrough plumbing for hints is
> now gone, and no hardware will ever receive hints.  Doesn't this
> mean that file_write_hint(), file->f_write_hint and iocb->ki_hint
> are now completely unused, too?

No, for the reason tha you state below.  f2fs still uses it.

> AFAICT, this patch leaves just the f2fs allocator usage of
> inode->i_rw_hint to select a segment to allocate from as the
> remaining consumer of this entire plumbing and user API. Is that
> used by applications anywhere, or can that be removed and so the
> rest of the infrastructure get removed and the fcntl()s no-op'd or
> -EOPNOTSUPP?

I was told it is used quite heavily in android.

  reply	other threads:[~2022-03-05  5:19 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04 17:55 [PATCH 1/2] nvme: remove support or stream based temperature hint Christoph Hellwig
2022-03-04 17:55 ` [PATCH 2/2] block: remove the per-bio/request write hint Christoph Hellwig
2022-03-04 19:24   ` Jens Axboe
2022-03-04 22:12   ` Dave Chinner
2022-03-05  5:19     ` Christoph Hellwig [this message]
2022-03-05  6:09       ` Number of parity disks Kengo.M
2022-03-05  8:56         ` Piergiorgio Sartor
2022-03-05 21:40       ` [PATCH 2/2] block: remove the per-bio/request write hint Dave Chinner
2022-03-05 23:55         ` Bart Van Assche
2022-03-06 17:11         ` Jens Axboe
2022-03-06 18:01           ` Christoph Hellwig
2022-03-06 18:06             ` Jens Axboe
2022-03-06 23:17               ` Dave Chinner
     [not found]                 ` <CGME20220309042324epcas1p111312e20f4429dc3a17172458284a923@epcas1p1.samsung.com>
2022-03-09 13:31                   ` Manjong Lee
2022-03-09  8:24                     ` Paul Menzel
2022-03-10 11:34                     ` [EXT] " Luca Porzio (lporzio)
2022-03-10 12:15                       ` Jens Axboe
2022-03-10 18:50                         ` Luca Porzio (lporzio)
2022-03-10 19:10                           ` Jens Axboe
2022-03-10 19:34                             ` Bart Van Assche
2022-03-10 21:52                               ` Bean Huo (beanhuo)
2022-03-10 22:10                                 ` Jens Axboe
2022-03-11 16:45                                   ` Bart Van Assche
2022-03-11 16:56                                     ` Jens Axboe
2022-03-14  7:40                                       ` Avi Shchislowski
2022-03-14  8:00                                         ` hch
2022-03-14 19:50                                         ` Eric Biggers
2022-03-14 19:58                                         ` [EXT] " Jens Axboe
2022-03-15 15:36                                           ` Luca Porzio (lporzio)
2022-03-15 15:44                                             ` Jens Axboe
2022-03-10 22:18                                 ` Bart Van Assche
2022-03-11  5:31                                   ` Eric Biggers
2022-03-11  5:31                                     ` [f2fs-dev] " Eric Biggers
2022-03-11  9:21                                   ` Luca Porzio (lporzio)
2022-03-10 14:21                       ` hch
2022-03-10 18:51                         ` Luca Porzio (lporzio)
2022-03-10 19:14                           ` hch
2022-03-11  5:06                           ` Eric Biggers
2022-03-11  9:23                             ` Luca Porzio (lporzio)
2022-03-04 19:34 ` [PATCH 1/2] nvme: remove support or stream based temperature hint Keith Busch
2022-03-04 19:36   ` Christoph Hellwig
2022-03-04 19:38     ` Jens Axboe
2022-03-04 20:20 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220305051929.GA24696@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=david@fromorbit.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=sagi@grimberg.me \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.