From: Manjong Lee <mj0123.lee@samsung.com>
To: david@fromorbit.com
Cc: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-raid@vger.kernel.org,
sagi@grimberg.me, song@kernel.org, seunghwan.hyun@samsung.com,
sookwan7.kim@samsung.com, nanich.lee@samsung.com,
woosung2.lee@samsung.com, yt0928.kim@samsung.com,
junho89.kim@samsung.com, jisoo2146.oh@samsung.com
Subject: Re: [PATCH 2/2] block: remove the per-bio/request write hint.
Date: Wed, 9 Mar 2022 22:31:19 +0900 [thread overview]
Message-ID: <20220309133119.6915-1-mj0123.lee@samsung.com> (raw)
In-Reply-To: <20220306231727.GP3927073@dread.disaster.area>
>On Sun, ddMar 06, 2022 at 11:06:12AM -0700, Jens Axboe wrote:
>> On 3/6/22 11:01 AM, Christoph Hellwig wrote:
>> > On Sun, Mar 06, 2022 at 10:11:46AM -0700, Jens Axboe wrote:
>> >> Yes, I think we should kill it. If we retain the inode hint, the f2fs
>> >> doesn't need a any changes. And it should be safe to make the per-file
>> >> fcntl hints return EINVAL, which they would on older kernels anyway.
>> >> Untested, but something like the below.
>> >
>> > I've sent this off to the testing farm this morning, but EINVAL might
>> > be even better:
>> >
>> > http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/more-hint-removal
>
>Yup, I like that.
>
>> I do think EINVAL is better, as it just tells the app it's not available
>> like we would've done before. With just doing zeroes, that might break
>> applications that set-and-verify. Of course there's also the risk of
>> that since we retain inode hints (so they work), but fail file hints.
>> That's a lesser risk though, and we only know of the inode hints being
>> used.
>
>Agreed, I think EINVAL would be better here - jsut make it behave
>like it would on a kernel that never supported this functionality in
>the first place. Seems simpler to me for user applications if we do
>that.
>
>Cheers,
>
>Dave.
>--
>Dave Chinner
>david@fromorbit.com
>
Currently, UFS device also supports hot/cold data separation
and uses existing write_hint code.
In other words, the function is also being used in storage other than NVMe,
and if it is removed, it is thought that there will be an operation problem.
If the code is removed, I am worried about how other devices
that use the function.
Is there a good alternative?
next prev parent reply other threads:[~2022-03-09 4:23 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 17:55 [PATCH 1/2] nvme: remove support or stream based temperature hint Christoph Hellwig
2022-03-04 17:55 ` [PATCH 2/2] block: remove the per-bio/request write hint Christoph Hellwig
2022-03-04 19:24 ` Jens Axboe
2022-03-04 22:12 ` Dave Chinner
2022-03-05 5:19 ` Christoph Hellwig
2022-03-05 6:09 ` Number of parity disks Kengo.M
2022-03-05 8:56 ` Piergiorgio Sartor
2022-03-05 21:40 ` [PATCH 2/2] block: remove the per-bio/request write hint Dave Chinner
2022-03-05 23:55 ` Bart Van Assche
2022-03-06 17:11 ` Jens Axboe
2022-03-06 18:01 ` Christoph Hellwig
2022-03-06 18:06 ` Jens Axboe
2022-03-06 23:17 ` Dave Chinner
[not found] ` <CGME20220309042324epcas1p111312e20f4429dc3a17172458284a923@epcas1p1.samsung.com>
2022-03-09 13:31 ` Manjong Lee [this message]
2022-03-09 8:24 ` Paul Menzel
2022-03-10 11:34 ` [EXT] " Luca Porzio (lporzio)
2022-03-10 12:15 ` Jens Axboe
2022-03-10 18:50 ` Luca Porzio (lporzio)
2022-03-10 19:10 ` Jens Axboe
2022-03-10 19:34 ` Bart Van Assche
2022-03-10 21:52 ` Bean Huo (beanhuo)
2022-03-10 22:10 ` Jens Axboe
2022-03-11 16:45 ` Bart Van Assche
2022-03-11 16:56 ` Jens Axboe
2022-03-14 7:40 ` Avi Shchislowski
2022-03-14 8:00 ` hch
2022-03-14 19:50 ` Eric Biggers
2022-03-14 19:58 ` [EXT] " Jens Axboe
2022-03-15 15:36 ` Luca Porzio (lporzio)
2022-03-15 15:44 ` Jens Axboe
2022-03-10 22:18 ` Bart Van Assche
2022-03-11 5:31 ` Eric Biggers
2022-03-11 5:31 ` [f2fs-dev] " Eric Biggers
2022-03-11 9:21 ` Luca Porzio (lporzio)
2022-03-10 14:21 ` hch
2022-03-10 18:51 ` Luca Porzio (lporzio)
2022-03-10 19:14 ` hch
2022-03-11 5:06 ` Eric Biggers
2022-03-11 9:23 ` Luca Porzio (lporzio)
2022-03-04 19:34 ` [PATCH 1/2] nvme: remove support or stream based temperature hint Keith Busch
2022-03-04 19:36 ` Christoph Hellwig
2022-03-04 19:38 ` Jens Axboe
2022-03-04 20:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220309133119.6915-1-mj0123.lee@samsung.com \
--to=mj0123.lee@samsung.com \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jisoo2146.oh@samsung.com \
--cc=junho89.kim@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=nanich.lee@samsung.com \
--cc=sagi@grimberg.me \
--cc=seunghwan.hyun@samsung.com \
--cc=song@kernel.org \
--cc=sookwan7.kim@samsung.com \
--cc=woosung2.lee@samsung.com \
--cc=yt0928.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.