All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] po: Un-transliterate the %zu format code
@ 2022-03-07 18:15 Glenn Washburn
  2022-03-09 16:10 ` Daniel Kiper
  0 siblings, 1 reply; 4+ messages in thread
From: Glenn Washburn @ 2022-03-07 18:15 UTC (permalink / raw)
  To: Daniel Kiper, grub-devel; +Cc: Glenn Washburn

Commit 45bffae13 uses the %zu format specifier which has not been used in
any translated strings yet. So the sed scripts used for tranliterating
certain languages need to be updated otherwise creation of the message
indexes will fail on an unknown format code. This is essentially the same
issue fixed for the %m format code in commit 2e246b6f.

Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 po/arabic.sed   | 3 ++-
 po/cyrillic.sed | 3 ++-
 po/greek.sed    | 3 ++-
 po/hebrew.sed   | 3 ++-
 4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/po/arabic.sed b/po/arabic.sed
index 21dc8b6db2..3fbee72480 100644
--- a/po/arabic.sed
+++ b/po/arabic.sed
@@ -74,9 +74,10 @@ s,%\([0-9]*\)للد,%\1lld,g
 
 s,%\([0-9\.\*]*\)س,%\1s,g
 s,%\([0-9\.\*]*\)م,%\1m,g
-s,%\([0-9]*\)لو,%\1lu,g
 s,%\([0-9]*\)و,%\1u,g
+s,%\([0-9]*\)لو,%\1lu,g
 s,%\([0-9]*\)للو,%\1llu,g
+s,%\([0-9]*\)زو,%\1zu,g
 s,%\([0-9]*\)كس,%\1x,g
 s,%\([0-9]*\)لكس,%\1lx,g
 s,%\([0-9]*\)للكس,%\1llx,g
diff --git a/po/cyrillic.sed b/po/cyrillic.sed
index 2e3e6655d6..472f095295 100644
--- a/po/cyrillic.sed
+++ b/po/cyrillic.sed
@@ -97,9 +97,10 @@ s,%\([0-9]*\)ллд,%\1lld,g
 
 s,%\([0-9\.\*]*\)с,%\1s,g
 s,%\([0-9\.\*]*\)м,%\1m,g
-s,%\([0-9]*\)лу,%\1lu,g
 s,%\([0-9]*\)у,%\1u,g
+s,%\([0-9]*\)лу,%\1lu,g
 s,%\([0-9]*\)ллу,%\1llu,g
+s,%\([0-9]*\)зу,%\1zu,g
 s,%\([0-9]*\)ѯ,%\1x,g
 s,%\([0-9]*\)лѯ,%\1lx,g
 s,%\([0-9]*\)ллѯ,%\1llx,g
diff --git a/po/greek.sed b/po/greek.sed
index 3543f6aac3..0e81625fbb 100644
--- a/po/greek.sed
+++ b/po/greek.sed
@@ -99,9 +99,10 @@ s,%\([0-9]*\)λλδ,%\1lld,g
 
 s,%\([0-9\.\*]*\)σ,%\1s,g
 s,%\([0-9\.\*]*\)μ,%\1m,g
-s,%\([0-9]*\)λυ,%\1lu,g
 s,%\([0-9]*\)υ,%\1u,g
+s,%\([0-9]*\)λυ,%\1lu,g
 s,%\([0-9]*\)λλυ,%\1llu,g
+s,%\([0-9]*\)ζυ,%\1zu,g
 s,%\([0-9]*\)ξ,%\1x,g
 s,%\([0-9]*\)λξ,%\1lx,g
 s,%\([0-9]*\)λλξ,%\1llx,g
diff --git a/po/hebrew.sed b/po/hebrew.sed
index 9210014bc3..33174bbdcc 100644
--- a/po/hebrew.sed
+++ b/po/hebrew.sed
@@ -82,9 +82,10 @@ s,%\([0-9]*\)ללד,%\1lld,g
 
 s,%\([0-9\.\*]*\)ש,%\1s,g
 s,%\([0-9\.\*]*\)מ,%\1m,g
-s,%\([0-9]*\)לוּ,%\1lu,g
 s,%\([0-9]*\)וּ,%\1u,g
+s,%\([0-9]*\)לוּ,%\1lu,g
 s,%\([0-9]*\)ללוּ,%\1llu,g
+s,%\([0-9]*\)זוּ,%\1zu,g
 s,%\([0-9]*\)כּס,%\1x,g
 s,%\([0-9]*\)לכּס,%\1lx,g
 s,%\([0-9]*\)ללכּס,%\1llx,g
-- 
2.27.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] po: Un-transliterate the %zu format code
  2022-03-07 18:15 [PATCH] po: Un-transliterate the %zu format code Glenn Washburn
@ 2022-03-09 16:10 ` Daniel Kiper
  2022-03-10  0:10   ` Glenn Washburn
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Kiper @ 2022-03-09 16:10 UTC (permalink / raw)
  To: Glenn Washburn; +Cc: grub-devel

On Mon, Mar 07, 2022 at 12:15:36PM -0600, Glenn Washburn wrote:
> Commit 45bffae13 uses the %zu format specifier which has not been used in

If you mention a commit please use the following format:
  commit 45bffae13 (util/resolve: Bail with error if moddep.lst file line is too long)

> any translated strings yet. So the sed scripts used for tranliterating
> certain languages need to be updated otherwise creation of the message
> indexes will fail on an unknown format code. This is essentially the same
> issue fixed for the %m format code in commit 2e246b6f.

Ditto.

> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
>  po/arabic.sed   | 3 ++-
>  po/cyrillic.sed | 3 ++-
>  po/greek.sed    | 3 ++-
>  po/hebrew.sed   | 3 ++-
>  4 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/po/arabic.sed b/po/arabic.sed
> index 21dc8b6db2..3fbee72480 100644
> --- a/po/arabic.sed
> +++ b/po/arabic.sed
> @@ -74,9 +74,10 @@ s,%\([0-9]*\)للد,%\1lld,g
>
>  s,%\([0-9\.\*]*\)س,%\1s,g
>  s,%\([0-9\.\*]*\)م,%\1m,g
> -s,%\([0-9]*\)لو,%\1lu,g
>  s,%\([0-9]*\)و,%\1u,g
> +s,%\([0-9]*\)لو,%\1lu,g

I am OK with this move but please mention it in the commit message.

>  s,%\([0-9]*\)للو,%\1llu,g
> +s,%\([0-9]*\)زو,%\1zu,g
>  s,%\([0-9]*\)كس,%\1x,g
>  s,%\([0-9]*\)لكس,%\1lx,g
>  s,%\([0-9]*\)للكس,%\1llx,g
> diff --git a/po/cyrillic.sed b/po/cyrillic.sed
> index 2e3e6655d6..472f095295 100644
> --- a/po/cyrillic.sed
> +++ b/po/cyrillic.sed
> @@ -97,9 +97,10 @@ s,%\([0-9]*\)ллд,%\1lld,g
>
>  s,%\([0-9\.\*]*\)с,%\1s,g
>  s,%\([0-9\.\*]*\)м,%\1m,g
> -s,%\([0-9]*\)лу,%\1lu,g
>  s,%\([0-9]*\)у,%\1u,g
> +s,%\([0-9]*\)лу,%\1lu,g

Ditto and below...

Daniel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] po: Un-transliterate the %zu format code
  2022-03-09 16:10 ` Daniel Kiper
@ 2022-03-10  0:10   ` Glenn Washburn
  2022-03-10 23:07     ` Daniel Kiper
  0 siblings, 1 reply; 4+ messages in thread
From: Glenn Washburn @ 2022-03-10  0:10 UTC (permalink / raw)
  To: Daniel Kiper; +Cc: grub-devel

On Wed, 9 Mar 2022 17:10:01 +0100
Daniel Kiper <dkiper@net-space.pl> wrote:

> On Mon, Mar 07, 2022 at 12:15:36PM -0600, Glenn Washburn wrote:
> > Commit 45bffae13 uses the %zu format specifier which has not been used in
> 
> If you mention a commit please use the following format:
>   commit 45bffae13 (util/resolve: Bail with error if moddep.lst file line is too long)

Ok, I'm not clear if this is just for the future, or you want me to
resend this patch. I have no problem resending.

Glenn

> 
> > any translated strings yet. So the sed scripts used for tranliterating
> > certain languages need to be updated otherwise creation of the message
> > indexes will fail on an unknown format code. This is essentially the same
> > issue fixed for the %m format code in commit 2e246b6f.
> 
> Ditto.
> 
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
> > ---
> >  po/arabic.sed   | 3 ++-
> >  po/cyrillic.sed | 3 ++-
> >  po/greek.sed    | 3 ++-
> >  po/hebrew.sed   | 3 ++-
> >  4 files changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/po/arabic.sed b/po/arabic.sed
> > index 21dc8b6db2..3fbee72480 100644
> > --- a/po/arabic.sed
> > +++ b/po/arabic.sed
> > @@ -74,9 +74,10 @@ s,%\([0-9]*\)للد,%\1lld,g
> >
> >  s,%\([0-9\.\*]*\)س,%\1s,g
> >  s,%\([0-9\.\*]*\)م,%\1m,g
> > -s,%\([0-9]*\)لو,%\1lu,g
> >  s,%\([0-9]*\)و,%\1u,g
> > +s,%\([0-9]*\)لو,%\1lu,g
> 
> I am OK with this move but please mention it in the commit message.
> 
> >  s,%\([0-9]*\)للو,%\1llu,g
> > +s,%\([0-9]*\)زو,%\1zu,g
> >  s,%\([0-9]*\)كس,%\1x,g
> >  s,%\([0-9]*\)لكس,%\1lx,g
> >  s,%\([0-9]*\)للكس,%\1llx,g
> > diff --git a/po/cyrillic.sed b/po/cyrillic.sed
> > index 2e3e6655d6..472f095295 100644
> > --- a/po/cyrillic.sed
> > +++ b/po/cyrillic.sed
> > @@ -97,9 +97,10 @@ s,%\([0-9]*\)ллд,%\1lld,g
> >
> >  s,%\([0-9\.\*]*\)с,%\1s,g
> >  s,%\([0-9\.\*]*\)м,%\1m,g
> > -s,%\([0-9]*\)лу,%\1lu,g
> >  s,%\([0-9]*\)у,%\1u,g
> > +s,%\([0-9]*\)лу,%\1lu,g
> 
> Ditto and below...
> 
> Daniel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] po: Un-transliterate the %zu format code
  2022-03-10  0:10   ` Glenn Washburn
@ 2022-03-10 23:07     ` Daniel Kiper
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Kiper @ 2022-03-10 23:07 UTC (permalink / raw)
  To: Glenn Washburn; +Cc: grub-devel

On Wed, Mar 09, 2022 at 06:10:12PM -0600, Glenn Washburn wrote:
> On Wed, 9 Mar 2022 17:10:01 +0100
> Daniel Kiper <dkiper@net-space.pl> wrote:
>
> > On Mon, Mar 07, 2022 at 12:15:36PM -0600, Glenn Washburn wrote:
> > > Commit 45bffae13 uses the %zu format specifier which has not been used in
> >
> > If you mention a commit please use the following format:
> >   commit 45bffae13 (util/resolve: Bail with error if moddep.lst file line is too long)
>
> Ok, I'm not clear if this is just for the future, or you want me to
> resend this patch. I have no problem resending.

Yes, please resend because commit message should be extended as I said below.

Daniel


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-03-10 23:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-07 18:15 [PATCH] po: Un-transliterate the %zu format code Glenn Washburn
2022-03-09 16:10 ` Daniel Kiper
2022-03-10  0:10   ` Glenn Washburn
2022-03-10 23:07     ` Daniel Kiper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.