* [PATCH] mmc: mtk-msdc: change a log level
@ 2022-03-08 9:49 ` Alexandre Bailon
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Bailon @ 2022-03-08 9:49 UTC (permalink / raw)
To: chaotian.jing, ulf.hansson, matthias.bgg
Cc: linux-mmc, linux-arm-kernel, linux-mediatek, linux-kernel,
Alexandre Bailon
We write data to RPMB, we get many time the following log:
mtk-msdc 11230000.mmc: phase: [map:ffffffff] [maxlen:32] [final:10]
dev_info is used to print that log but it seems that log is only
useful for debbuging. Use dev_dbg instead of dev_info.
Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
---
drivers/mmc/host/mtk-sd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index d5a9c269d492..05c8b4de46f3 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -1914,8 +1914,8 @@ static struct msdc_delay_phase get_best_delay(struct msdc_host *host, u32 delay)
final_phase = (start_final + len_final / 3) % PAD_DELAY_MAX;
else
final_phase = (start_final + len_final / 2) % PAD_DELAY_MAX;
- dev_info(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
- delay, len_final, final_phase);
+ dev_dbg(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
+ delay, len_final, final_phase);
delay_phase.maxlen = len_final;
delay_phase.start = start_final;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] mmc: mtk-msdc: change a log level
@ 2022-03-08 9:49 ` Alexandre Bailon
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Bailon @ 2022-03-08 9:49 UTC (permalink / raw)
To: chaotian.jing, ulf.hansson, matthias.bgg
Cc: linux-mmc, linux-arm-kernel, linux-mediatek, linux-kernel,
Alexandre Bailon
We write data to RPMB, we get many time the following log:
mtk-msdc 11230000.mmc: phase: [map:ffffffff] [maxlen:32] [final:10]
dev_info is used to print that log but it seems that log is only
useful for debbuging. Use dev_dbg instead of dev_info.
Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
---
drivers/mmc/host/mtk-sd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index d5a9c269d492..05c8b4de46f3 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -1914,8 +1914,8 @@ static struct msdc_delay_phase get_best_delay(struct msdc_host *host, u32 delay)
final_phase = (start_final + len_final / 3) % PAD_DELAY_MAX;
else
final_phase = (start_final + len_final / 2) % PAD_DELAY_MAX;
- dev_info(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
- delay, len_final, final_phase);
+ dev_dbg(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
+ delay, len_final, final_phase);
delay_phase.maxlen = len_final;
delay_phase.start = start_final;
--
2.34.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] mmc: mtk-msdc: change a log level
@ 2022-03-08 9:49 ` Alexandre Bailon
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Bailon @ 2022-03-08 9:49 UTC (permalink / raw)
To: chaotian.jing, ulf.hansson, matthias.bgg
Cc: linux-mmc, linux-arm-kernel, linux-mediatek, linux-kernel,
Alexandre Bailon
We write data to RPMB, we get many time the following log:
mtk-msdc 11230000.mmc: phase: [map:ffffffff] [maxlen:32] [final:10]
dev_info is used to print that log but it seems that log is only
useful for debbuging. Use dev_dbg instead of dev_info.
Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
---
drivers/mmc/host/mtk-sd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index d5a9c269d492..05c8b4de46f3 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -1914,8 +1914,8 @@ static struct msdc_delay_phase get_best_delay(struct msdc_host *host, u32 delay)
final_phase = (start_final + len_final / 3) % PAD_DELAY_MAX;
else
final_phase = (start_final + len_final / 2) % PAD_DELAY_MAX;
- dev_info(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
- delay, len_final, final_phase);
+ dev_dbg(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
+ delay, len_final, final_phase);
delay_phase.maxlen = len_final;
delay_phase.start = start_final;
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: mtk-msdc: change a log level
2022-03-08 9:49 ` Alexandre Bailon
(?)
@ 2022-03-09 9:50 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 6+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-03-09 9:50 UTC (permalink / raw)
To: Alexandre Bailon, chaotian.jing, ulf.hansson, matthias.bgg
Cc: linux-mmc, linux-arm-kernel, linux-mediatek, linux-kernel
Il 08/03/22 10:49, Alexandre Bailon ha scritto:
> We write data to RPMB, we get many time the following log:
> mtk-msdc 11230000.mmc: phase: [map:ffffffff] [maxlen:32] [final:10]
>
> dev_info is used to print that log but it seems that log is only
> useful for debbuging. Use dev_dbg instead of dev_info.
>
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
Hello Alexandre,
I definitely agree with this change, but the commit title is not clear enough;
can you please change it to something like
mmc: mtk-sd: Silence delay phase calculation debug log
After the change,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/mmc/host/mtk-sd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index d5a9c269d492..05c8b4de46f3 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1914,8 +1914,8 @@ static struct msdc_delay_phase get_best_delay(struct msdc_host *host, u32 delay)
> final_phase = (start_final + len_final / 3) % PAD_DELAY_MAX;
> else
> final_phase = (start_final + len_final / 2) % PAD_DELAY_MAX;
> - dev_info(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
> - delay, len_final, final_phase);
> + dev_dbg(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
> + delay, len_final, final_phase);
>
> delay_phase.maxlen = len_final;
> delay_phase.start = start_final;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: mtk-msdc: change a log level
@ 2022-03-09 9:50 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 6+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-03-09 9:50 UTC (permalink / raw)
To: Alexandre Bailon, chaotian.jing, ulf.hansson, matthias.bgg
Cc: linux-mmc, linux-arm-kernel, linux-mediatek, linux-kernel
Il 08/03/22 10:49, Alexandre Bailon ha scritto:
> We write data to RPMB, we get many time the following log:
> mtk-msdc 11230000.mmc: phase: [map:ffffffff] [maxlen:32] [final:10]
>
> dev_info is used to print that log but it seems that log is only
> useful for debbuging. Use dev_dbg instead of dev_info.
>
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
Hello Alexandre,
I definitely agree with this change, but the commit title is not clear enough;
can you please change it to something like
mmc: mtk-sd: Silence delay phase calculation debug log
After the change,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/mmc/host/mtk-sd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index d5a9c269d492..05c8b4de46f3 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1914,8 +1914,8 @@ static struct msdc_delay_phase get_best_delay(struct msdc_host *host, u32 delay)
> final_phase = (start_final + len_final / 3) % PAD_DELAY_MAX;
> else
> final_phase = (start_final + len_final / 2) % PAD_DELAY_MAX;
> - dev_info(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
> - delay, len_final, final_phase);
> + dev_dbg(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
> + delay, len_final, final_phase);
>
> delay_phase.maxlen = len_final;
> delay_phase.start = start_final;
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: mtk-msdc: change a log level
@ 2022-03-09 9:50 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 6+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-03-09 9:50 UTC (permalink / raw)
To: Alexandre Bailon, chaotian.jing, ulf.hansson, matthias.bgg
Cc: linux-mmc, linux-arm-kernel, linux-mediatek, linux-kernel
Il 08/03/22 10:49, Alexandre Bailon ha scritto:
> We write data to RPMB, we get many time the following log:
> mtk-msdc 11230000.mmc: phase: [map:ffffffff] [maxlen:32] [final:10]
>
> dev_info is used to print that log but it seems that log is only
> useful for debbuging. Use dev_dbg instead of dev_info.
>
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
Hello Alexandre,
I definitely agree with this change, but the commit title is not clear enough;
can you please change it to something like
mmc: mtk-sd: Silence delay phase calculation debug log
After the change,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/mmc/host/mtk-sd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index d5a9c269d492..05c8b4de46f3 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1914,8 +1914,8 @@ static struct msdc_delay_phase get_best_delay(struct msdc_host *host, u32 delay)
> final_phase = (start_final + len_final / 3) % PAD_DELAY_MAX;
> else
> final_phase = (start_final + len_final / 2) % PAD_DELAY_MAX;
> - dev_info(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
> - delay, len_final, final_phase);
> + dev_dbg(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
> + delay, len_final, final_phase);
>
> delay_phase.maxlen = len_final;
> delay_phase.start = start_final;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-09 9:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-08 9:49 [PATCH] mmc: mtk-msdc: change a log level Alexandre Bailon
2022-03-08 9:49 ` Alexandre Bailon
2022-03-08 9:49 ` Alexandre Bailon
2022-03-09 9:50 ` AngeloGioacchino Del Regno
2022-03-09 9:50 ` AngeloGioacchino Del Regno
2022-03-09 9:50 ` AngeloGioacchino Del Regno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.