[Buildroot] [PATCH 0/1] package/rpi-firmware: fix missing files in overlays

[Buildroot] [PATCH 0/1] package/rpi-firmware: fix missing files in overlays

[Sassen, Rutger]

[-- Attachment #1.1: Type: text/plain, Size: 1143 bytes --]

First of all, this is my first patch I submit for buildroot, or for
any git project for that matter, so please forgive me if it is not in
the expected format.

This patch fixes some files not being copied from the rpi-firmware
boot/overlays directory. I suspect it could also be backported to older
still supported branches, but from the documentation I'm not quite sure
how to specify this in the patch submission, since the package has been
bumped to newer versions in the mean time.

Also, git stripped the leading TAB character from the changed line in
the diff. I'm hesitant to manually edit this, since I'm not sure if this
is intended behavior.

Rutger Sassen (1):
  package/rpi-firmware: fix missing files in overlays

 package/rpi-firmware/rpi-firmware.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

This email communication is CONFIDENTIAL. If you are not the intended recipient, you may not use, copy or disclose to anyone the message or any information contained in the message and I ask that you please notify me by return email and delete this communication immediately. Thank you.

[-- Attachment #1.2: Type: text/html, Size: 1502 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 0/1] package/rpi-firmware: fix missing files in overlays

[Peter Seiderer]

Hello Rutger,

On Tue, 8 Mar 2022 12:39:51 +0000, "Sassen, Rutger" <rsassen@comecer.com> wrote:

> First of all, this is my first patch I submit for buildroot, or for
> any git project for that matter, so please forgive me if it is not in
> the expected format.

No problem, every patch (or hint about bugs/missing features) welcome...

>
> This patch fixes some files not being copied from the rpi-firmware
> boot/overlays directory. I suspect it could also be backported to older
> still supported branches, but from the documentation I'm not quite sure
> how to specify this in the patch submission, since the package has been
> bumped to newer versions in the mean time.

Should be no problem as the mentioned overlay_map.dtb file should be
already available in the older rpi-firmware releases (since April 2020)...

>
> Also, git stripped the leading TAB character from the changed line in
> the diff. I'm hesitant to manually edit this, since I'm not sure if this
> is intended behavior.

This should not happen, are you sure the tab is committed?

>
> Rutger Sassen (1):
>   package/rpi-firmware: fix missing files in overlays
>
>  package/rpi-firmware/rpi-firmware.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.20.1
>
> This email communication is CONFIDENTIAL. If you are not the intended recipient, you may not use, copy or disclose to anyone
> the message or any information contained in the message and I ask that you please notify me by return email and delete this
> communication immediately. Thank you.

According to the email footer I could not look further at your provided patch ;-)

Please try to re-send without it....

More comments in replay to your patch...

Regards,
Peter
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 0/1] package/rpi-firmware: fix missing files in overlays

[Sassen, Rutger]

[-- Attachment #1.1: Type: text/plain, Size: 1329 bytes --]

Hi Peter,

> > Also, git stripped the leading TAB character from the changed line in
> > the diff. I'm hesitant to manually edit this, since I'm not sure if
> > this is intended behavior.
> 
> This should not happen, are you sure the tab is committed?

I think it must have been a mistake on my side. I cannot reproduce it. I will fix it in a next revision for the patch.

> > This email communication is CONFIDENTIAL. If you are not the intended
> > recipient, you may not use, copy or disclose to anyone the message or
> > any information contained in the message and I ask that you please notify
> me by return email and delete this communication immediately. Thank you.
> 
> According to the email footer I could not look further at your provided patch
> ;-)
> 
> Please try to re-send without it....

Unfortunately I have no control over this. It is added automatically by our company email gateway. I have submitted a support ticket for it, but I won't hold my breath...

Thanks for the suggestions,

Rutger

This email communication is CONFIDENTIAL. If you are not the intended recipient, you may not use, copy or disclose to anyone the message or any information contained in the message and I ask that you please notify me by return email and delete this communication immediately. Thank you.

[-- Attachment #1.2: Type: text/html, Size: 1760 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot