From: kernel test robot <lkp@intel.com>
To: Byungchul Park <byungchul.park@lge.com>, torvalds@linux-foundation.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
mingo@redhat.com, linux-kernel@vger.kernel.org, will@kernel.org,
tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org,
sashal@kernel.org, daniel.vetter@ffwll.ch,
chris@chris-wilson.co.uk, duyuyang@gmail.com,
johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu,
willy@infradead.org, david@fromorbit.com, amir73il@gmail.com,
bfields@fieldses.org, gregkh@linuxfoundation.org,
kernel-team@lge.com, linux-mm@kvack.org,
akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org,
hannes@cmpxchg.org
Subject: Re: [PATCH v4 02/24] dept: Implement Dept(Dependency Tracker)
Date: Wed, 9 Mar 2022 15:21:54 +0800 [thread overview]
Message-ID: <202203091550.PnufQ7gO-lkp@intel.com> (raw)
In-Reply-To: <1646377603-19730-3-git-send-email-byungchul.park@lge.com>
Hi Byungchul,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/sched/core]
[also build test WARNING on linux/master linus/master v5.17-rc7]
[cannot apply to tip/locking/core hnaz-mm/master next-20220308]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Byungchul-Park/DEPT-Dependency-Tracker/20220304-150943
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 25795ef6299f07ce3838f3253a9cb34f64efcfae
config: hexagon-randconfig-r022-20220307 (https://download.01.org/0day-ci/archive/20220309/202203091550.PnufQ7gO-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/387c58f459c6eb2a17a99b6c42ad57512a917d5d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Byungchul-Park/DEPT-Dependency-Tracker/20220304-150943
git checkout 387c58f459c6eb2a17a99b6c42ad57512a917d5d
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/target/ kernel/dependency/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> kernel/dependency/dept.c:2093:6: warning: no previous prototype for function '__dept_wait' [-Wmissing-prototypes]
void __dept_wait(struct dept_map *m, unsigned long w_f, unsigned long ip,
^
kernel/dependency/dept.c:2093:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void __dept_wait(struct dept_map *m, unsigned long w_f, unsigned long ip,
^
static
In file included from kernel/dependency/dept.c:2532:
>> kernel/dependency/dept_hash.h:9:1: warning: format specifies type 'size_t' (aka 'unsigned int') but the argument has type 'unsigned long' [-Wformat]
HASH(dep, 12)
^~~~~~~~~~~~~
kernel/dependency/dept.c:2531:14: note: expanded from macro 'HASH'
#id, B2KB(sizeof(struct hlist_head) * (1UL << bits)));
~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/printk.h:519:34: note: expanded from macro 'pr_info'
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
include/linux/printk.h:446:60: note: expanded from macro 'printk'
#define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
_p_func(_fmt, ##__VA_ARGS__); \
~~~~ ^~~~~~~~~~~
kernel/dependency/dept.c:2497:17: note: expanded from macro 'B2KB'
#define B2KB(B) ((B) / 1024)
^~~~~~~~~~~~
In file included from kernel/dependency/dept.c:2532:
kernel/dependency/dept_hash.h:10:1: warning: format specifies type 'size_t' (aka 'unsigned int') but the argument has type 'unsigned long' [-Wformat]
HASH(class, 12)
^~~~~~~~~~~~~~~
kernel/dependency/dept.c:2531:14: note: expanded from macro 'HASH'
#id, B2KB(sizeof(struct hlist_head) * (1UL << bits)));
~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/printk.h:519:34: note: expanded from macro 'pr_info'
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
include/linux/printk.h:446:60: note: expanded from macro 'printk'
#define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
_p_func(_fmt, ##__VA_ARGS__); \
~~~~ ^~~~~~~~~~~
kernel/dependency/dept.c:2497:17: note: expanded from macro 'B2KB'
#define B2KB(B) ((B) / 1024)
^~~~~~~~~~~~
3 warnings generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for FRAME_POINTER
Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS
Selected by
- DEPT && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && !MIPS && !PPC && !ARM && !S390 && !MICROBLAZE && !ARC && !X86
vim +/__dept_wait +2093 kernel/dependency/dept.c
2092
> 2093 void __dept_wait(struct dept_map *m, unsigned long w_f, unsigned long ip,
2094 const char *w_fn, int ne)
2095 {
2096 int e;
2097
2098 /*
2099 * Be as conservative as possible. In case of mulitple waits for
2100 * a single dept_map, we are going to keep only the last wait's
2101 * wgen for simplicity - keeping all wgens seems overengineering.
2102 *
2103 * Of course, it might cause missing some dependencies that
2104 * would rarely, probabily never, happen but it helps avoid
2105 * false positive report.
2106 */
2107 for_each_set_bit(e, &w_f, DEPT_MAX_SUBCLASSES_EVT) {
2108 struct dept_class *c;
2109 struct dept_key *k;
2110
2111 k = m->keys ?: &m->keys_local;
2112 c = check_new_class(&m->keys_local, k,
2113 map_sub(m, e), m->name);
2114 if (!c)
2115 continue;
2116
2117 add_wait(c, ip, w_fn, ne);
2118 }
2119 }
2120
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2022-03-09 7:22 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 7:06 [PATCH v4 00/24] DEPT(Dependency Tracker) Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 01/24] llist: Move llist_{head,node} definition to types.h Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 02/24] dept: Implement Dept(Dependency Tracker) Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-09 7:21 ` kernel test robot [this message]
2022-03-09 23:43 ` kernel test robot
2022-03-04 7:06 ` [PATCH v4 03/24] dept: Embed Dept data in Lockdep Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 04/24] dept: Add a API for skipping dependency check temporarily Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 05/24] dept: Apply Dept to spinlock Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 06/24] dept: Apply Dept to mutex families Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 07/24] dept: Apply Dept to rwlock Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 08/24] dept: Apply Dept to wait_for_completion()/complete() Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 09/24] dept: Apply Dept to seqlock Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 10/24] dept: Apply Dept to rwsem Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 11/24] dept: Add proc knobs to show stats and dependency graph Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-10 7:43 ` kernel test robot
2022-03-04 7:06 ` [PATCH v4 12/24] dept: Introduce split map concept and new APIs for them Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 13/24] dept: Apply Dept to wait/event of PG_{locked,writeback} Byungchul Park
2022-03-04 7:06 ` [PATCH v4 13/24] dept: Apply Dept to wait/event of PG_{locked, writeback} Byungchul Park
2022-03-04 7:06 ` [PATCH v4 14/24] dept: Apply SDT to swait Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-09 9:14 ` kernel test robot
2022-03-04 7:06 ` [PATCH v4 15/24] dept: Apply SDT to wait(waitqueue) Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 16/24] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 19:28 ` Sergei Shtylyov
2022-03-04 19:28 ` Sergei Shtylyov
2022-03-04 23:36 ` Byungchul Park
2022-03-04 23:36 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 17/24] dept: Distinguish each syscall context from another Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 18/24] dept: Distinguish each work " Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 19/24] dept: Disable Dept within the wait_bit layer by default Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 20/24] dept: Add nocheck version of init_completion() Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 21/24] dept: Disable Dept on struct crypto_larval's completion for now Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 22/24] dept: Don't create dependencies between different depths in any case Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 11:39 ` Hyeonggon Yoo
2022-03-04 11:39 ` Hyeonggon Yoo
2022-03-04 23:38 ` Byungchul Park
2022-03-04 23:38 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 23/24] dept: Let it work with real sleeps in __schedule() Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-04 7:06 ` [PATCH v4 24/24] dept: Disable Dept on that map once it's been handled until next turn Byungchul Park
2022-03-04 7:06 ` Byungchul Park
2022-03-12 1:53 ` [PATCH v4 00/24] DEPT(Dependency Tracker) Hyeonggon Yoo
2022-03-12 1:53 ` Hyeonggon Yoo
2022-03-14 6:59 ` Byungchul Park
2022-03-14 6:59 ` Byungchul Park
2022-03-15 12:04 ` Hyeonggon Yoo
2022-03-15 12:04 ` Hyeonggon Yoo
2022-03-16 4:32 ` Byungchul Park
2022-03-16 4:32 ` Byungchul Park
2022-03-16 9:30 ` Hyeonggon Yoo
2022-03-16 9:30 ` Hyeonggon Yoo
2022-03-18 7:51 ` Byungchul Park
2022-03-18 7:51 ` Byungchul Park
2022-03-20 10:57 ` Byungchul Park
2022-03-20 10:57 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202203091550.PnufQ7gO-lkp@intel.com \
--to=lkp@intel.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=bfields@fieldses.org \
--cc=byungchul.park@lge.com \
--cc=chris@chris-wilson.co.uk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.vetter@ffwll.ch \
--cc=david@fromorbit.com \
--cc=duyuyang@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=joel@joelfernandes.org \
--cc=johannes.berg@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=kernel-team@lge.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=will@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.