From: Byungchul Park <byungchul.park@lge.com> To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org, peterz@infradead.org, will@kernel.org, tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, chris@chris-wilson.co.uk, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, bfields@fieldses.org, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, paolo.valente@linaro.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jack@suse.com, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com Subject: Re: [PATCH v4 00/24] DEPT(Dependency Tracker) Date: Sun, 20 Mar 2022 19:57:41 +0900 [thread overview] Message-ID: <20220320105740.GB11318@X58A-UD3R> (raw) In-Reply-To: <20220318075129.GB17484@X58A-UD3R> On Fri, Mar 18, 2022 at 04:51:29PM +0900, Byungchul Park wrote: > On Wed, Mar 16, 2022 at 09:30:02AM +0000, Hyeonggon Yoo wrote: > > On Wed, Mar 16, 2022 at 01:32:13PM +0900, Byungchul Park wrote: > > > On Sat, Mar 12, 2022 at 01:53:26AM +0000, Hyeonggon Yoo wrote: > > > > On Fri, Mar 04, 2022 at 04:06:19PM +0900, Byungchul Park wrote: > > > > > Hi Linus and folks, > > > > > > > > > > I've been developing a tool for detecting deadlock possibilities by > > > > > tracking wait/event rather than lock(?) acquisition order to try to > > > > > cover all synchonization machanisms. It's done on v5.17-rc1 tag. > > > > > > > > > > https://github.com/lgebyungchulpark/linux-dept/commits/dept1.14_on_v5.17-rc1 > > > > > > > > > > > > > Small feedback unrelated to thread: > > > > I'm not sure "Need to expand the ring buffer" is something to call > > > > WARN(). Is this stack trace useful for something? > > > > ======== > > > > > > > > Hello Byungchul. These are two warnings of DEPT on system. > > > > > > Hi Hyeonggon, > > > > > > Could you run scripts/decode_stacktrace.sh and share the result instead > > > of the raw format below if the reports still appear with PATCH v5? It'd > > > be appreciated (: > > > > > > > Hi Byungchul. > > > > on dept1.18_on_v5.17-rc7, the kernel_clone() warning has gone. > > There is one warning remaining on my system: > > > > It warns when running kunit-try-catch-test testcase. > > Hi Hyeonggon, > > I can reproduce it thanks to you. I will let you know on all works done. Hi Hyeonggon, All works wrt this issue have been done. I've just updated the same branch. https://github.com/lgebyungchulpark/linux-dept/commits/dept1.18_on_v5.17-rc7 This is just for your information. Thanks, Byungchul > > Thanks, > Byungchul > > > =================================================== > > DEPT: Circular dependency has been detected. > > 5.17.0-rc7+ #4 Not tainted > > --------------------------------------------------- > > summary > > --------------------------------------------------- > > *** AA DEADLOCK *** > > > > context A > > [S] (unknown)(&try_completion:0) > > [W] wait_for_completion_timeout(&try_completion:0) > > [E] complete(&try_completion:0) > > > > [S]: start of the event context > > [W]: the wait blocked > > [E]: the event not reachable > > --------------------------------------------------- > > context A's detail > > --------------------------------------------------- > > context A > > [S] (unknown)(&try_completion:0) > > [W] wait_for_completion_timeout(&try_completion:0) > > [E] complete(&try_completion:0) > > > > [S] (unknown)(&try_completion:0): > > (N/A) > > > > [W] wait_for_completion_timeout(&try_completion:0): > > kunit_try_catch_run (lib/kunit/try-catch.c:78 (discriminator 1)) > > stacktrace: > > dept_wait (kernel/dependency/dept.c:2149) > > wait_for_completion_timeout (kernel/sched/completion.c:119 (discriminator 4) kernel/sched/completion.c:165 (discriminator 4)) > > kunit_try_catch_run (lib/kunit/try-catch.c:78 (discriminator 1)) > > kunit_test_try_catch_successful_try_no_catch (lib/kunit/kunit-test.c:43) > > kunit_try_run_case (lib/kunit/test.c:333 lib/kunit/test.c:374) > > kunit_generic_run_threadfn_adapter (lib/kunit/try-catch.c:30) > > kthread (kernel/kthread.c:379) > > ret_from_fork (arch/arm64/kernel/entry.S:757) > > > > [E] complete(&try_completion:0): > > kthread_complete_and_exit (kernel/kthread.c:327) > > stacktrace: > > dept_event (kernel/dependency/dept.c:2376 (discriminator 2)) > > complete (kernel/sched/completion.c:33 (discriminator 4)) > > kthread_complete_and_exit (kernel/kthread.c:327) > > kunit_try_catch_throw (lib/kunit/try-catch.c:18) > > kthread (kernel/kthread.c:379) > > ret_from_fork (arch/arm64/kernel/entry.S:757) > > > > --------------------------------------------------- > > information that might be helpful > > --------------------------------------------------- > > Hardware name: linux,dummy-virt (DT) > > Call trace: > > dump_backtrace.part.0 (arch/arm64/kernel/stacktrace.c:186) > > show_stack (arch/arm64/kernel/stacktrace.c:193) > > dump_stack_lvl (lib/dump_stack.c:107 (discriminator 4)) > > dump_stack (lib/dump_stack.c:114) > > print_circle (./arch/arm64/include/asm/atomic_ll_sc.h:112 ./arch/arm64/include/asm/atomic.h:30 ./include/linux/atomic/atomic-arch-fallback.h:511 ./include/linux/atomic/atomic-instrumented.h:258 kernel/dependency/dept.c:140 kernel/dependency/dept.c:748) > > cb_check_dl (kernel/dependency/dept.c:1083 kernel/dependency/dept.c:1064) > > bfs (kernel/dependency/dept.c:833) > > add_dep (kernel/dependency/dept.c:1409) > > do_event (kernel/dependency/dept.c:175 kernel/dependency/dept.c:1644) > > dept_event (kernel/dependency/dept.c:2376 (discriminator 2)) > > complete (kernel/sched/completion.c:33 (discriminator 4)) > > kthread_complete_and_exit (kernel/kthread.c:327) > > kunit_try_catch_throw (lib/kunit/try-catch.c:18) > > kthread (kernel/kthread.c:379) > > ret_from_fork (arch/arm64/kernel/entry.S:757) > > > > -- > > Thank you, You are awesome! > > Hyeonggon :-) > > > > > https://lkml.org/lkml/2022/3/15/1277 > > > (or https://github.com/lgebyungchulpark/linux-dept/commits/dept1.18_on_v5.17-rc7) > > > > > > Thank you very much! > > > > > > -- > > > Byungchul > > > > > > > Both cases look similar. > > > > > > > > In what case DEPT says (unknown)? > > > > I'm not sure we can properly debug this. > > > > > > > > =================================================== > > > > DEPT: Circular dependency has been detected. > > > > 5.17.0-rc1+ #3 Tainted: G W > > > > --------------------------------------------------- > > > > summary > > > > --------------------------------------------------- > > > > *** AA DEADLOCK *** > > > > > > > > context A > > > > [S] (unknown)(&vfork:0) > > > > [W] wait_for_completion_killable(&vfork:0) > > > > [E] complete(&vfork:0) > > > > > > > > [S]: start of the event context > > > > [W]: the wait blocked > > > > [E]: the event not reachable > > > > --------------------------------------------------- > > > > context A's detail > > > > --------------------------------------------------- > > > > context A > > > > [S] (unknown)(&vfork:0) > > > > [W] wait_for_completion_killable(&vfork:0) > > > > [E] complete(&vfork:0) > > > > > > > > [S] (unknown)(&vfork:0): > > > > (N/A) > > > > > > > > [W] wait_for_completion_killable(&vfork:0): > > > > [<ffffffc00802204c>] kernel_clone+0x25c/0x2b8 > > > > stacktrace: > > > > dept_wait+0x74/0x88 > > > > wait_for_completion_killable+0x60/0xa0 > > > > kernel_clone+0x25c/0x2b8 > > > > __do_sys_clone+0x5c/0x74 > > > > __arm64_sys_clone+0x18/0x20 > > > > invoke_syscall.constprop.0+0x78/0xc4 > > > > do_el0_svc+0x98/0xd0 > > > > el0_svc+0x44/0xe4 > > > > el0t_64_sync_handler+0xb0/0x12c > > > > el0t_64_sync+0x158/0x15c > > > > > > > > [E] complete(&vfork:0): > > > > [<ffffffc00801f49c>] mm_release+0x7c/0x90 > > > > stacktrace: > > > > dept_event+0xe0/0x100 > > > > complete+0x48/0x98 > > > > mm_release+0x7c/0x90 > > > > exit_mm_release+0xc/0x14 > > > > do_exit+0x1b4/0x81c > > > > do_group_exit+0x30/0x9c > > > > __wake_up_parent+0x0/0x24 > > > > invoke_syscall.constprop.0+0x78/0xc4 > > > > do_el0_svc+0x98/0xd0 > > > > el0_svc+0x44/0xe4 > > > > el0t_64_sync_handler+0xb0/0x12c > > > > el0t_64_sync+0x158/0x15c > > > > --------------------------------------------------- > > > > information that might be helpful > > > > --------------------------------------------------- > > > > CPU: 6 PID: 229 Comm: start-stop-daem Tainted: G W 5.17.0-rc1+ #3 > > > > Hardware name: linux,dummy-virt (DT) > > > > Call trace: > > > > dump_backtrace.part.0+0x9c/0xc4 > > > > show_stack+0x14/0x28 > > > > dump_stack_lvl+0x9c/0xcc > > > > dump_stack+0x14/0x2c > > > > print_circle+0x2d4/0x438 > > > > cb_check_dl+0x44/0x70 > > > > bfs+0x60/0x168 > > > > add_dep+0x88/0x11c > > > > do_event.constprop.0+0x19c/0x2c0 > > > > dept_event+0xe0/0x100 > > > > complete+0x48/0x98 > > > > mm_release+0x7c/0x90 > > > > exit_mm_release+0xc/0x14 > > > > do_exit+0x1b4/0x81c > > > > do_group_exit+0x30/0x9c > > > > __wake_up_parent+0x0/0x24 > > > > invoke_syscall.constprop.0+0x78/0xc4 > > > > do_el0_svc+0x98/0xd0 > > > > el0_svc+0x44/0xe4 > > > > el0t_64_sync_handler+0xb0/0x12c > > > > el0t_64_sync+0x158/0x15c > > > > > > > > > > > > > > > > > > > > =================================================== > > > > DEPT: Circular dependency has been detected. > > > > 5.17.0-rc1+ #3 Tainted: G W > > > > --------------------------------------------------- > > > > summary > > > > --------------------------------------------------- > > > > *** AA DEADLOCK *** > > > > > > > > context A > > > > [S] (unknown)(&try_completion:0) > > > > [W] wait_for_completion_timeout(&try_completion:0) > > > > [E] complete(&try_completion:0) > > > > > > > > [S]: start of the event context > > > > [W]: the wait blocked > > > > [E]: the event not reachable > > > > --------------------------------------------------- > > > > context A's detail > > > > --------------------------------------------------- > > > > context A > > > > [S] (unknown)(&try_completion:0) > > > > [W] wait_for_completion_timeout(&try_completion:0) > > > > [E] complete(&try_completion:0) > > > > > > > > [S] (unknown)(&try_completion:0): > > > > (N/A) > > > > > > > > [W] wait_for_completion_timeout(&try_completion:0): > > > > [<ffffffc008166bf4>] kunit_try_catch_run+0xb4/0x160 > > > > stacktrace: > > > > dept_wait+0x74/0x88 > > > > wait_for_completion_timeout+0x64/0xa0 > > > > kunit_try_catch_run+0xb4/0x160 > > > > kunit_test_try_catch_successful_try_no_catch+0x3c/0x98 > > > > kunit_try_run_case+0x9c/0xa0 > > > > kunit_generic_run_threadfn_adapter+0x1c/0x28 > > > > kthread+0xd4/0xe4 > > > > ret_from_fork+0x10/0x20 > > > > > > > > [E] complete(&try_completion:0): > > > > [<ffffffc00803dce4>] kthread_complete_and_exit+0x18/0x20 > > > > stacktrace: > > > > dept_event+0xe0/0x100 > > > > complete+0x48/0x98 > > > > kthread_complete_and_exit+0x18/0x20 > > > > kunit_try_catch_throw+0x0/0x1c > > > > kthread+0xd4/0xe4 > > > > ret_from_fork+0x10/0x20 > > > > > > > > --------------------------------------------------- > > > > information that might be helpful > > > > --------------------------------------------------- > > > > CPU: 15 PID: 132 Comm: kunit_try_catch Tainted: G W 5.17.0-rc1+ #3 > > > > Hardware name: linux,dummy-virt (DT) > > > > Call trace: > > > > dump_backtrace.part.0+0x9c/0xc4 > > > > show_stack+0x14/0x28 > > > > dump_stack_lvl+0x9c/0xcc > > > > dump_stack+0x14/0x2c > > > > print_circle+0x2d4/0x438 > > > > cb_check_dl+0x44/0x70 > > > > bfs+0x60/0x168 > > > > add_dep+0x88/0x11c > > > > do_event.constprop.0+0x19c/0x2c0 > > > > dept_event+0xe0/0x100 > > > > complete+0x48/0x98 > > > > kthread_complete_and_exit+0x18/0x20 > > > > kunit_try_catch_throw+0x0/0x1c > > > > kthread+0xd4/0xe4 > > > > ret_from_fork+0x10/0x20 > > > > > > > > > > > > > Benifit: > > > > > > > > > > 0. Works with all lock primitives. > > > > > 1. Works with wait_for_completion()/complete(). > > > > > 2. Works with 'wait' on PG_locked. > > > > > 3. Works with 'wait' on PG_writeback. > > > > > 4. Works with swait/wakeup. > > > > > 5. Works with waitqueue. > > > > > 6. Multiple reports are allowed. > > > > > 7. Deduplication control on multiple reports. > > > > > 8. Withstand false positives thanks to 6. > > > > > 9. Easy to tag any wait/event. > > > > > > > > > > Future work: > > > > > > > > [...] > > > > > > > > > -- > > > > > 1.9.1 > > > > > > > > > > > > > -- > > > > Thank you, You are awesome! > > > > Hyeonggon :-)
WARNING: multiple messages have this Message-ID (diff)
From: Byungchul Park <byungchul.park@lge.com> To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: hamohammed.sa@gmail.com, jack@suse.cz, peterz@infradead.org, daniel.vetter@ffwll.ch, amir73il@gmail.com, david@fromorbit.com, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, bfields@fieldses.org, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, joel@joelfernandes.org, cl@linux.com, will@kernel.org, duyuyang@gmail.com, sashal@kernel.org, paolo.valente@linaro.org, damien.lemoal@opensource.wdc.com, willy@infradead.org, hch@infradead.org, airlied@linux.ie, mingo@redhat.com, djwong@kernel.org, vdavydov.dev@gmail.com, rientjes@google.com, dennis@kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, ngupta@vflare.org, johannes.berg@intel.com, jack@suse.com, dan.j.williams@intel.com, josef@toxicpanda.com, rostedt@goodmis.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, jglisse@redhat.com, viro@zeniv.linux.org.uk, tglx@linutronix.de, mhocko@kernel.org, vbabka@suse.cz, melissa.srw@gmail.com, sj@kernel.org, tytso@mit.edu, rodrigosiqueiramelo@gmail.com, kernel-team@lge.com, gregkh@linuxfoundation.org, jlayton@kernel.org, linux-kernel@vger.kernel.org, penberg@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, tj@kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org Subject: Re: [PATCH v4 00/24] DEPT(Dependency Tracker) Date: Sun, 20 Mar 2022 19:57:41 +0900 [thread overview] Message-ID: <20220320105740.GB11318@X58A-UD3R> (raw) In-Reply-To: <20220318075129.GB17484@X58A-UD3R> On Fri, Mar 18, 2022 at 04:51:29PM +0900, Byungchul Park wrote: > On Wed, Mar 16, 2022 at 09:30:02AM +0000, Hyeonggon Yoo wrote: > > On Wed, Mar 16, 2022 at 01:32:13PM +0900, Byungchul Park wrote: > > > On Sat, Mar 12, 2022 at 01:53:26AM +0000, Hyeonggon Yoo wrote: > > > > On Fri, Mar 04, 2022 at 04:06:19PM +0900, Byungchul Park wrote: > > > > > Hi Linus and folks, > > > > > > > > > > I've been developing a tool for detecting deadlock possibilities by > > > > > tracking wait/event rather than lock(?) acquisition order to try to > > > > > cover all synchonization machanisms. It's done on v5.17-rc1 tag. > > > > > > > > > > https://github.com/lgebyungchulpark/linux-dept/commits/dept1.14_on_v5.17-rc1 > > > > > > > > > > > > > Small feedback unrelated to thread: > > > > I'm not sure "Need to expand the ring buffer" is something to call > > > > WARN(). Is this stack trace useful for something? > > > > ======== > > > > > > > > Hello Byungchul. These are two warnings of DEPT on system. > > > > > > Hi Hyeonggon, > > > > > > Could you run scripts/decode_stacktrace.sh and share the result instead > > > of the raw format below if the reports still appear with PATCH v5? It'd > > > be appreciated (: > > > > > > > Hi Byungchul. > > > > on dept1.18_on_v5.17-rc7, the kernel_clone() warning has gone. > > There is one warning remaining on my system: > > > > It warns when running kunit-try-catch-test testcase. > > Hi Hyeonggon, > > I can reproduce it thanks to you. I will let you know on all works done. Hi Hyeonggon, All works wrt this issue have been done. I've just updated the same branch. https://github.com/lgebyungchulpark/linux-dept/commits/dept1.18_on_v5.17-rc7 This is just for your information. Thanks, Byungchul > > Thanks, > Byungchul > > > =================================================== > > DEPT: Circular dependency has been detected. > > 5.17.0-rc7+ #4 Not tainted > > --------------------------------------------------- > > summary > > --------------------------------------------------- > > *** AA DEADLOCK *** > > > > context A > > [S] (unknown)(&try_completion:0) > > [W] wait_for_completion_timeout(&try_completion:0) > > [E] complete(&try_completion:0) > > > > [S]: start of the event context > > [W]: the wait blocked > > [E]: the event not reachable > > --------------------------------------------------- > > context A's detail > > --------------------------------------------------- > > context A > > [S] (unknown)(&try_completion:0) > > [W] wait_for_completion_timeout(&try_completion:0) > > [E] complete(&try_completion:0) > > > > [S] (unknown)(&try_completion:0): > > (N/A) > > > > [W] wait_for_completion_timeout(&try_completion:0): > > kunit_try_catch_run (lib/kunit/try-catch.c:78 (discriminator 1)) > > stacktrace: > > dept_wait (kernel/dependency/dept.c:2149) > > wait_for_completion_timeout (kernel/sched/completion.c:119 (discriminator 4) kernel/sched/completion.c:165 (discriminator 4)) > > kunit_try_catch_run (lib/kunit/try-catch.c:78 (discriminator 1)) > > kunit_test_try_catch_successful_try_no_catch (lib/kunit/kunit-test.c:43) > > kunit_try_run_case (lib/kunit/test.c:333 lib/kunit/test.c:374) > > kunit_generic_run_threadfn_adapter (lib/kunit/try-catch.c:30) > > kthread (kernel/kthread.c:379) > > ret_from_fork (arch/arm64/kernel/entry.S:757) > > > > [E] complete(&try_completion:0): > > kthread_complete_and_exit (kernel/kthread.c:327) > > stacktrace: > > dept_event (kernel/dependency/dept.c:2376 (discriminator 2)) > > complete (kernel/sched/completion.c:33 (discriminator 4)) > > kthread_complete_and_exit (kernel/kthread.c:327) > > kunit_try_catch_throw (lib/kunit/try-catch.c:18) > > kthread (kernel/kthread.c:379) > > ret_from_fork (arch/arm64/kernel/entry.S:757) > > > > --------------------------------------------------- > > information that might be helpful > > --------------------------------------------------- > > Hardware name: linux,dummy-virt (DT) > > Call trace: > > dump_backtrace.part.0 (arch/arm64/kernel/stacktrace.c:186) > > show_stack (arch/arm64/kernel/stacktrace.c:193) > > dump_stack_lvl (lib/dump_stack.c:107 (discriminator 4)) > > dump_stack (lib/dump_stack.c:114) > > print_circle (./arch/arm64/include/asm/atomic_ll_sc.h:112 ./arch/arm64/include/asm/atomic.h:30 ./include/linux/atomic/atomic-arch-fallback.h:511 ./include/linux/atomic/atomic-instrumented.h:258 kernel/dependency/dept.c:140 kernel/dependency/dept.c:748) > > cb_check_dl (kernel/dependency/dept.c:1083 kernel/dependency/dept.c:1064) > > bfs (kernel/dependency/dept.c:833) > > add_dep (kernel/dependency/dept.c:1409) > > do_event (kernel/dependency/dept.c:175 kernel/dependency/dept.c:1644) > > dept_event (kernel/dependency/dept.c:2376 (discriminator 2)) > > complete (kernel/sched/completion.c:33 (discriminator 4)) > > kthread_complete_and_exit (kernel/kthread.c:327) > > kunit_try_catch_throw (lib/kunit/try-catch.c:18) > > kthread (kernel/kthread.c:379) > > ret_from_fork (arch/arm64/kernel/entry.S:757) > > > > -- > > Thank you, You are awesome! > > Hyeonggon :-) > > > > > https://lkml.org/lkml/2022/3/15/1277 > > > (or https://github.com/lgebyungchulpark/linux-dept/commits/dept1.18_on_v5.17-rc7) > > > > > > Thank you very much! > > > > > > -- > > > Byungchul > > > > > > > Both cases look similar. > > > > > > > > In what case DEPT says (unknown)? > > > > I'm not sure we can properly debug this. > > > > > > > > =================================================== > > > > DEPT: Circular dependency has been detected. > > > > 5.17.0-rc1+ #3 Tainted: G W > > > > --------------------------------------------------- > > > > summary > > > > --------------------------------------------------- > > > > *** AA DEADLOCK *** > > > > > > > > context A > > > > [S] (unknown)(&vfork:0) > > > > [W] wait_for_completion_killable(&vfork:0) > > > > [E] complete(&vfork:0) > > > > > > > > [S]: start of the event context > > > > [W]: the wait blocked > > > > [E]: the event not reachable > > > > --------------------------------------------------- > > > > context A's detail > > > > --------------------------------------------------- > > > > context A > > > > [S] (unknown)(&vfork:0) > > > > [W] wait_for_completion_killable(&vfork:0) > > > > [E] complete(&vfork:0) > > > > > > > > [S] (unknown)(&vfork:0): > > > > (N/A) > > > > > > > > [W] wait_for_completion_killable(&vfork:0): > > > > [<ffffffc00802204c>] kernel_clone+0x25c/0x2b8 > > > > stacktrace: > > > > dept_wait+0x74/0x88 > > > > wait_for_completion_killable+0x60/0xa0 > > > > kernel_clone+0x25c/0x2b8 > > > > __do_sys_clone+0x5c/0x74 > > > > __arm64_sys_clone+0x18/0x20 > > > > invoke_syscall.constprop.0+0x78/0xc4 > > > > do_el0_svc+0x98/0xd0 > > > > el0_svc+0x44/0xe4 > > > > el0t_64_sync_handler+0xb0/0x12c > > > > el0t_64_sync+0x158/0x15c > > > > > > > > [E] complete(&vfork:0): > > > > [<ffffffc00801f49c>] mm_release+0x7c/0x90 > > > > stacktrace: > > > > dept_event+0xe0/0x100 > > > > complete+0x48/0x98 > > > > mm_release+0x7c/0x90 > > > > exit_mm_release+0xc/0x14 > > > > do_exit+0x1b4/0x81c > > > > do_group_exit+0x30/0x9c > > > > __wake_up_parent+0x0/0x24 > > > > invoke_syscall.constprop.0+0x78/0xc4 > > > > do_el0_svc+0x98/0xd0 > > > > el0_svc+0x44/0xe4 > > > > el0t_64_sync_handler+0xb0/0x12c > > > > el0t_64_sync+0x158/0x15c > > > > --------------------------------------------------- > > > > information that might be helpful > > > > --------------------------------------------------- > > > > CPU: 6 PID: 229 Comm: start-stop-daem Tainted: G W 5.17.0-rc1+ #3 > > > > Hardware name: linux,dummy-virt (DT) > > > > Call trace: > > > > dump_backtrace.part.0+0x9c/0xc4 > > > > show_stack+0x14/0x28 > > > > dump_stack_lvl+0x9c/0xcc > > > > dump_stack+0x14/0x2c > > > > print_circle+0x2d4/0x438 > > > > cb_check_dl+0x44/0x70 > > > > bfs+0x60/0x168 > > > > add_dep+0x88/0x11c > > > > do_event.constprop.0+0x19c/0x2c0 > > > > dept_event+0xe0/0x100 > > > > complete+0x48/0x98 > > > > mm_release+0x7c/0x90 > > > > exit_mm_release+0xc/0x14 > > > > do_exit+0x1b4/0x81c > > > > do_group_exit+0x30/0x9c > > > > __wake_up_parent+0x0/0x24 > > > > invoke_syscall.constprop.0+0x78/0xc4 > > > > do_el0_svc+0x98/0xd0 > > > > el0_svc+0x44/0xe4 > > > > el0t_64_sync_handler+0xb0/0x12c > > > > el0t_64_sync+0x158/0x15c > > > > > > > > > > > > > > > > > > > > =================================================== > > > > DEPT: Circular dependency has been detected. > > > > 5.17.0-rc1+ #3 Tainted: G W > > > > --------------------------------------------------- > > > > summary > > > > --------------------------------------------------- > > > > *** AA DEADLOCK *** > > > > > > > > context A > > > > [S] (unknown)(&try_completion:0) > > > > [W] wait_for_completion_timeout(&try_completion:0) > > > > [E] complete(&try_completion:0) > > > > > > > > [S]: start of the event context > > > > [W]: the wait blocked > > > > [E]: the event not reachable > > > > --------------------------------------------------- > > > > context A's detail > > > > --------------------------------------------------- > > > > context A > > > > [S] (unknown)(&try_completion:0) > > > > [W] wait_for_completion_timeout(&try_completion:0) > > > > [E] complete(&try_completion:0) > > > > > > > > [S] (unknown)(&try_completion:0): > > > > (N/A) > > > > > > > > [W] wait_for_completion_timeout(&try_completion:0): > > > > [<ffffffc008166bf4>] kunit_try_catch_run+0xb4/0x160 > > > > stacktrace: > > > > dept_wait+0x74/0x88 > > > > wait_for_completion_timeout+0x64/0xa0 > > > > kunit_try_catch_run+0xb4/0x160 > > > > kunit_test_try_catch_successful_try_no_catch+0x3c/0x98 > > > > kunit_try_run_case+0x9c/0xa0 > > > > kunit_generic_run_threadfn_adapter+0x1c/0x28 > > > > kthread+0xd4/0xe4 > > > > ret_from_fork+0x10/0x20 > > > > > > > > [E] complete(&try_completion:0): > > > > [<ffffffc00803dce4>] kthread_complete_and_exit+0x18/0x20 > > > > stacktrace: > > > > dept_event+0xe0/0x100 > > > > complete+0x48/0x98 > > > > kthread_complete_and_exit+0x18/0x20 > > > > kunit_try_catch_throw+0x0/0x1c > > > > kthread+0xd4/0xe4 > > > > ret_from_fork+0x10/0x20 > > > > > > > > --------------------------------------------------- > > > > information that might be helpful > > > > --------------------------------------------------- > > > > CPU: 15 PID: 132 Comm: kunit_try_catch Tainted: G W 5.17.0-rc1+ #3 > > > > Hardware name: linux,dummy-virt (DT) > > > > Call trace: > > > > dump_backtrace.part.0+0x9c/0xc4 > > > > show_stack+0x14/0x28 > > > > dump_stack_lvl+0x9c/0xcc > > > > dump_stack+0x14/0x2c > > > > print_circle+0x2d4/0x438 > > > > cb_check_dl+0x44/0x70 > > > > bfs+0x60/0x168 > > > > add_dep+0x88/0x11c > > > > do_event.constprop.0+0x19c/0x2c0 > > > > dept_event+0xe0/0x100 > > > > complete+0x48/0x98 > > > > kthread_complete_and_exit+0x18/0x20 > > > > kunit_try_catch_throw+0x0/0x1c > > > > kthread+0xd4/0xe4 > > > > ret_from_fork+0x10/0x20 > > > > > > > > > > > > > Benifit: > > > > > > > > > > 0. Works with all lock primitives. > > > > > 1. Works with wait_for_completion()/complete(). > > > > > 2. Works with 'wait' on PG_locked. > > > > > 3. Works with 'wait' on PG_writeback. > > > > > 4. Works with swait/wakeup. > > > > > 5. Works with waitqueue. > > > > > 6. Multiple reports are allowed. > > > > > 7. Deduplication control on multiple reports. > > > > > 8. Withstand false positives thanks to 6. > > > > > 9. Easy to tag any wait/event. > > > > > > > > > > Future work: > > > > > > > > [...] > > > > > > > > > -- > > > > > 1.9.1 > > > > > > > > > > > > > -- > > > > Thank you, You are awesome! > > > > Hyeonggon :-)
next prev parent reply other threads:[~2022-03-20 10:58 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-04 7:06 [PATCH v4 00/24] DEPT(Dependency Tracker) Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 01/24] llist: Move llist_{head,node} definition to types.h Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 02/24] dept: Implement Dept(Dependency Tracker) Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-09 7:21 ` kernel test robot 2022-03-09 23:43 ` kernel test robot 2022-03-04 7:06 ` [PATCH v4 03/24] dept: Embed Dept data in Lockdep Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 04/24] dept: Add a API for skipping dependency check temporarily Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 05/24] dept: Apply Dept to spinlock Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 06/24] dept: Apply Dept to mutex families Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 07/24] dept: Apply Dept to rwlock Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 08/24] dept: Apply Dept to wait_for_completion()/complete() Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 09/24] dept: Apply Dept to seqlock Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 10/24] dept: Apply Dept to rwsem Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 11/24] dept: Add proc knobs to show stats and dependency graph Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-10 7:43 ` kernel test robot 2022-03-04 7:06 ` [PATCH v4 12/24] dept: Introduce split map concept and new APIs for them Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 13/24] dept: Apply Dept to wait/event of PG_{locked,writeback} Byungchul Park 2022-03-04 7:06 ` [PATCH v4 13/24] dept: Apply Dept to wait/event of PG_{locked, writeback} Byungchul Park 2022-03-04 7:06 ` [PATCH v4 14/24] dept: Apply SDT to swait Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-09 9:14 ` kernel test robot 2022-03-04 7:06 ` [PATCH v4 15/24] dept: Apply SDT to wait(waitqueue) Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 16/24] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 19:28 ` Sergei Shtylyov 2022-03-04 19:28 ` Sergei Shtylyov 2022-03-04 23:36 ` Byungchul Park 2022-03-04 23:36 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 17/24] dept: Distinguish each syscall context from another Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 18/24] dept: Distinguish each work " Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 19/24] dept: Disable Dept within the wait_bit layer by default Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 20/24] dept: Add nocheck version of init_completion() Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 21/24] dept: Disable Dept on struct crypto_larval's completion for now Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 22/24] dept: Don't create dependencies between different depths in any case Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 11:39 ` Hyeonggon Yoo 2022-03-04 11:39 ` Hyeonggon Yoo 2022-03-04 23:38 ` Byungchul Park 2022-03-04 23:38 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 23/24] dept: Let it work with real sleeps in __schedule() Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-04 7:06 ` [PATCH v4 24/24] dept: Disable Dept on that map once it's been handled until next turn Byungchul Park 2022-03-04 7:06 ` Byungchul Park 2022-03-12 1:53 ` [PATCH v4 00/24] DEPT(Dependency Tracker) Hyeonggon Yoo 2022-03-12 1:53 ` Hyeonggon Yoo 2022-03-14 6:59 ` Byungchul Park 2022-03-14 6:59 ` Byungchul Park 2022-03-15 12:04 ` Hyeonggon Yoo 2022-03-15 12:04 ` Hyeonggon Yoo 2022-03-16 4:32 ` Byungchul Park 2022-03-16 4:32 ` Byungchul Park 2022-03-16 9:30 ` Hyeonggon Yoo 2022-03-16 9:30 ` Hyeonggon Yoo 2022-03-18 7:51 ` Byungchul Park 2022-03-18 7:51 ` Byungchul Park 2022-03-20 10:57 ` Byungchul Park [this message] 2022-03-20 10:57 ` Byungchul Park
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220320105740.GB11318@X58A-UD3R \ --to=byungchul.park@lge.com \ --cc=42.hyeyoo@gmail.com \ --cc=adilger.kernel@dilger.ca \ --cc=airlied@linux.ie \ --cc=akpm@linux-foundation.org \ --cc=amir73il@gmail.com \ --cc=bfields@fieldses.org \ --cc=chris@chris-wilson.co.uk \ --cc=cl@linux.com \ --cc=damien.lemoal@opensource.wdc.com \ --cc=dan.j.williams@intel.com \ --cc=daniel.vetter@ffwll.ch \ --cc=david@fromorbit.com \ --cc=dennis@kernel.org \ --cc=djwong@kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=duyuyang@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=hamohammed.sa@gmail.com \ --cc=hannes@cmpxchg.org \ --cc=hch@infradead.org \ --cc=jack@suse.com \ --cc=jack@suse.cz \ --cc=jglisse@redhat.com \ --cc=jlayton@kernel.org \ --cc=joel@joelfernandes.org \ --cc=johannes.berg@intel.com \ --cc=josef@toxicpanda.com \ --cc=kernel-team@lge.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=melissa.srw@gmail.com \ --cc=mhocko@kernel.org \ --cc=minchan@kernel.org \ --cc=mingo@redhat.com \ --cc=ngupta@vflare.org \ --cc=paolo.valente@linaro.org \ --cc=penberg@kernel.org \ --cc=peterz@infradead.org \ --cc=rientjes@google.com \ --cc=rodrigosiqueiramelo@gmail.com \ --cc=rostedt@goodmis.org \ --cc=sashal@kernel.org \ --cc=sj@kernel.org \ --cc=tglx@linutronix.de \ --cc=tj@kernel.org \ --cc=torvalds@linux-foundation.org \ --cc=tytso@mit.edu \ --cc=vbabka@suse.cz \ --cc=vdavydov.dev@gmail.com \ --cc=viro@zeniv.linux.org.uk \ --cc=will@kernel.org \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.