[PATCH v2 0/2] AM64: Tick timer fixes

[PATCH v2 0/2] AM64: Tick timer fixes

[Vignesh Raghavendra]

Patch 1 switches AM64 to use armv8 per-cpu timer at A53 SPL/U-Boot
stage as done in other TI K3 platforms

Patch 2 corrects DM timer freq to be 200MHz (used at R5 SPL stage)

v2:
Update commit message 1/2 as per Nishanth's suggestion
Reword commit msg in 2/2 to be more readable.

v1: lore.kernel.org/r/20220307092059.669376-1-vigneshr@ti.com

Vignesh Raghavendra (2):
  configs: am64x_evm_a53_defconfig: Switch to per-cpu timer as tick
    provider
  ARM: dts: k3-am642: Correct timer frequency

 arch/arm/dts/k3-am642-evm-u-boot.dtsi | 2 +-
 arch/arm/dts/k3-am642-sk-u-boot.dtsi  | 2 +-
 configs/am64x_evm_a53_defconfig       | 3 ---
 3 files changed, 2 insertions(+), 5 deletions(-)

-- 
2.35.1

[PATCH v2 1/2] configs: am64x_evm_a53_defconfig: Switch to per-cpu timer as tick provider

[Vignesh Raghavendra]

On arm64 systems, recommendation is to use per-cpu timer for time
keeping. Currently AM64 ends up using DM timer as tick timer as driver
is enabled in the config. Drop OMAP DM Timer related configs, this will
switch to using armv8 per-cpu timer as tick timer for A53 SPL/U-Boot.

Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
 configs/am64x_evm_a53_defconfig | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/configs/am64x_evm_a53_defconfig b/configs/am64x_evm_a53_defconfig
index 7397436def..bceb35f5ec 100644
--- a/configs/am64x_evm_a53_defconfig
+++ b/configs/am64x_evm_a53_defconfig
@@ -135,9 +135,6 @@ CONFIG_CADENCE_QSPI=y
 CONFIG_SYSRESET=y
 CONFIG_SPL_SYSRESET=y
 CONFIG_SYSRESET_TI_SCI=y
-CONFIG_TIMER=y
-CONFIG_SPL_TIMER=y
-CONFIG_OMAP_TIMER=y
 CONFIG_USB=y
 CONFIG_DM_USB_GADGET=y
 CONFIG_SPL_DM_USB_GADGET=y
-- 
2.35.1

[PATCH v2 2/2] ARM: dts: k3-am642: Correct timer frequency

[Vignesh Raghavendra]

Timer0 runs at 200MHz,and the clock-frequency defined in DT is
incorrect. Fix it.

Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
 arch/arm/dts/k3-am642-evm-u-boot.dtsi | 2 +-
 arch/arm/dts/k3-am642-sk-u-boot.dtsi  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/dts/k3-am642-evm-u-boot.dtsi b/arch/arm/dts/k3-am642-evm-u-boot.dtsi
index 03688a51a3..0c2d973409 100644
--- a/arch/arm/dts/k3-am642-evm-u-boot.dtsi
+++ b/arch/arm/dts/k3-am642-evm-u-boot.dtsi
@@ -16,7 +16,7 @@
 		compatible = "ti,omap5430-timer";
 		reg = <0x0 0x2400000 0x0 0x80>;
 		ti,timer-alwon;
-		clock-frequency = <250000000>;
+		clock-frequency = <200000000>;
 		u-boot,dm-spl;
 	};
 };
diff --git a/arch/arm/dts/k3-am642-sk-u-boot.dtsi b/arch/arm/dts/k3-am642-sk-u-boot.dtsi
index e5c26b8326..afe5baba8c 100644
--- a/arch/arm/dts/k3-am642-sk-u-boot.dtsi
+++ b/arch/arm/dts/k3-am642-sk-u-boot.dtsi
@@ -20,7 +20,7 @@
 		compatible = "ti,omap5430-timer";
 		reg = <0x0 0x2400000 0x0 0x80>;
 		ti,timer-alwon;
-		clock-frequency = <250000000>;
+		clock-frequency = <200000000>;
 		u-boot,dm-spl;
 	};
 };
-- 
2.35.1

Re: [PATCH v2 0/2] AM64: Tick timer fixes

[Nishanth Menon]

On 21:23-20220311, Vignesh Raghavendra wrote:
> Patch 1 switches AM64 to use armv8 per-cpu timer at A53 SPL/U-Boot
> stage as done in other TI K3 platforms
> 
> Patch 2 corrects DM timer freq to be 200MHz (used at R5 SPL stage)
> 
> v2:
> Update commit message 1/2 as per Nishanth's suggestion
> Reword commit msg in 2/2 to be more readable.
> 
> v1: lore.kernel.org/r/20220307092059.669376-1-vigneshr@ti.com
> 
> Vignesh Raghavendra (2):
>   configs: am64x_evm_a53_defconfig: Switch to per-cpu timer as tick
>     provider
>   ARM: dts: k3-am642: Correct timer frequency
> 
>  arch/arm/dts/k3-am642-evm-u-boot.dtsi | 2 +-
>  arch/arm/dts/k3-am642-sk-u-boot.dtsi  | 2 +-
>  configs/am64x_evm_a53_defconfig       | 3 ---
>  3 files changed, 2 insertions(+), 5 deletions(-)
> 
> -- 
> 2.35.1
> 

Reviewed-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v2 1/2] configs: am64x_evm_a53_defconfig: Switch to per-cpu timer as tick provider

[Nishanth Menon]

On 21:23-20220311, Vignesh Raghavendra wrote:
> On arm64 systems, recommendation is to use per-cpu timer for time
> keeping. Currently AM64 ends up using DM timer as tick timer as driver
> is enabled in the config. Drop OMAP DM Timer related configs, this will
> switch to using armv8 per-cpu timer as tick timer for A53 SPL/U-Boot.
> 
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>

meh.. patchworks is still not smart[1] - so, responding per patch..

Reviewed-By: Nishanth Menon <nm@ti.com>

[1] https://github.com/getpatchwork/patchwork/issues/113

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v2 2/2] ARM: dts: k3-am642: Correct timer frequency

[Nishanth Menon]

On 21:23-20220311, Vignesh Raghavendra wrote:
> Timer0 runs at 200MHz,and the clock-frequency defined in DT is
> incorrect. Fix it.
> 
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>

Reviewed-By: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v2 1/2] configs: am64x_evm_a53_defconfig: Switch to per-cpu timer as tick provider

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

On Fri, Mar 11, 2022 at 09:23:21PM +0530, Vignesh Raghavendra wrote:

> On arm64 systems, recommendation is to use per-cpu timer for time
> keeping. Currently AM64 ends up using DM timer as tick timer as driver
> is enabled in the config. Drop OMAP DM Timer related configs, this will
> switch to using armv8 per-cpu timer as tick timer for A53 SPL/U-Boot.
> 
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> Reviewed-By: Nishanth Menon <nm@ti.com>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH v2 2/2] ARM: dts: k3-am642: Correct timer frequency

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

On Fri, Mar 11, 2022 at 09:23:22PM +0530, Vignesh Raghavendra wrote:

> Timer0 runs at 200MHz,and the clock-frequency defined in DT is
> incorrect. Fix it.
> 
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> Reviewed-By: Nishanth Menon <nm@ti.com>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]