* [PATCH] gpio: ts4900: Fix comment formatting and grammar
@ 2022-03-11 18:19 Kris Bahnsen
2022-03-12 13:06 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Kris Bahnsen @ 2022-03-11 18:19 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, linux-gpio, linux-kernel
Cc: Andy Shevchenko, Kris Bahnsen
The issues were pointed out after the prior commit was applied
Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>
---
drivers/gpio/gpio-ts4900.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpio-ts4900.c b/drivers/gpio/gpio-ts4900.c
index d918d2df4de2..ede605b8e098 100644
--- a/drivers/gpio/gpio-ts4900.c
+++ b/drivers/gpio/gpio-ts4900.c
@@ -55,8 +55,9 @@ static int ts4900_gpio_direction_input(struct gpio_chip *chip,
{
struct ts4900_gpio_priv *priv = gpiochip_get_data(chip);
- /* Only clear the OE bit here, requires a RMW. Prevents potential issue
- * with OE and data getting to the physical pin at different times.
+ /*
+ * Only clear the OE bit here, requires a RMW. Prevents a potential issue
+ * with OE and DAT getting to the physical pin at different times.
*/
return regmap_update_bits(priv->regmap, offset, TS4900_GPIO_OE, 0);
}
@@ -68,9 +69,10 @@ static int ts4900_gpio_direction_output(struct gpio_chip *chip,
unsigned int reg;
int ret;
- /* If changing from an input to an output, we need to first set the
- * proper data bit to what is requested and then set OE bit. This
- * prevents a glitch that can occur on the IO line
+ /*
+ * If changing from an input to an output, we need to first set the
+ * GPIO's DAT bit to what is requested and then set the OE bit. This
+ * prevents a glitch that can occur on the IO line.
*/
regmap_read(priv->regmap, offset, ®);
if (!(reg & TS4900_GPIO_OE)) {
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: ts4900: Fix comment formatting and grammar
2022-03-11 18:19 [PATCH] gpio: ts4900: Fix comment formatting and grammar Kris Bahnsen
@ 2022-03-12 13:06 ` Andy Shevchenko
2022-03-14 14:46 ` Bartosz Golaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2022-03-12 13:06 UTC (permalink / raw)
To: Kris Bahnsen
Cc: Linus Walleij, Bartosz Golaszewski, open list:GPIO SUBSYSTEM,
Linux Kernel Mailing List
On Fri, Mar 11, 2022 at 8:20 PM Kris Bahnsen <kris@embeddedts.com> wrote:
>
> The issues were pointed out after the prior commit was applied
Missed period in the above sentence.
Otherwise LGTM,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>
> ---
> drivers/gpio/gpio-ts4900.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ts4900.c b/drivers/gpio/gpio-ts4900.c
> index d918d2df4de2..ede605b8e098 100644
> --- a/drivers/gpio/gpio-ts4900.c
> +++ b/drivers/gpio/gpio-ts4900.c
> @@ -55,8 +55,9 @@ static int ts4900_gpio_direction_input(struct gpio_chip *chip,
> {
> struct ts4900_gpio_priv *priv = gpiochip_get_data(chip);
>
> - /* Only clear the OE bit here, requires a RMW. Prevents potential issue
> - * with OE and data getting to the physical pin at different times.
> + /*
> + * Only clear the OE bit here, requires a RMW. Prevents a potential issue
> + * with OE and DAT getting to the physical pin at different times.
> */
> return regmap_update_bits(priv->regmap, offset, TS4900_GPIO_OE, 0);
> }
> @@ -68,9 +69,10 @@ static int ts4900_gpio_direction_output(struct gpio_chip *chip,
> unsigned int reg;
> int ret;
>
> - /* If changing from an input to an output, we need to first set the
> - * proper data bit to what is requested and then set OE bit. This
> - * prevents a glitch that can occur on the IO line
> + /*
> + * If changing from an input to an output, we need to first set the
> + * GPIO's DAT bit to what is requested and then set the OE bit. This
> + * prevents a glitch that can occur on the IO line.
> */
> regmap_read(priv->regmap, offset, ®);
> if (!(reg & TS4900_GPIO_OE)) {
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: ts4900: Fix comment formatting and grammar
2022-03-12 13:06 ` Andy Shevchenko
@ 2022-03-14 14:46 ` Bartosz Golaszewski
0 siblings, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2022-03-14 14:46 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Kris Bahnsen, Linus Walleij, open list:GPIO SUBSYSTEM,
Linux Kernel Mailing List
On Sat, Mar 12, 2022 at 2:06 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Fri, Mar 11, 2022 at 8:20 PM Kris Bahnsen <kris@embeddedts.com> wrote:
> >
> > The issues were pointed out after the prior commit was applied
>
> Missed period in the above sentence.
>
> Otherwise LGTM,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> > Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>
> > ---
> > drivers/gpio/gpio-ts4900.c | 12 +++++++-----
> > 1 file changed, 7 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-ts4900.c b/drivers/gpio/gpio-ts4900.c
> > index d918d2df4de2..ede605b8e098 100644
> > --- a/drivers/gpio/gpio-ts4900.c
> > +++ b/drivers/gpio/gpio-ts4900.c
> > @@ -55,8 +55,9 @@ static int ts4900_gpio_direction_input(struct gpio_chip *chip,
> > {
> > struct ts4900_gpio_priv *priv = gpiochip_get_data(chip);
> >
> > - /* Only clear the OE bit here, requires a RMW. Prevents potential issue
> > - * with OE and data getting to the physical pin at different times.
> > + /*
> > + * Only clear the OE bit here, requires a RMW. Prevents a potential issue
> > + * with OE and DAT getting to the physical pin at different times.
> > */
> > return regmap_update_bits(priv->regmap, offset, TS4900_GPIO_OE, 0);
> > }
> > @@ -68,9 +69,10 @@ static int ts4900_gpio_direction_output(struct gpio_chip *chip,
> > unsigned int reg;
> > int ret;
> >
> > - /* If changing from an input to an output, we need to first set the
> > - * proper data bit to what is requested and then set OE bit. This
> > - * prevents a glitch that can occur on the IO line
> > + /*
> > + * If changing from an input to an output, we need to first set the
> > + * GPIO's DAT bit to what is requested and then set the OE bit. This
> > + * prevents a glitch that can occur on the IO line.
> > */
> > regmap_read(priv->regmap, offset, ®);
> > if (!(reg & TS4900_GPIO_OE)) {
> > --
> > 2.11.0
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko
Added the missing period and applied.
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-14 14:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-11 18:19 [PATCH] gpio: ts4900: Fix comment formatting and grammar Kris Bahnsen
2022-03-12 13:06 ` Andy Shevchenko
2022-03-14 14:46 ` Bartosz Golaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.