* [PATCH BlueZ 1/2] bthost: Fix not setting all parameters when using Create BIG cmd
@ 2022-03-11 21:17 Luiz Augusto von Dentz
2022-03-11 21:17 ` [PATCH BlueZ 2/2] btdev: Fix CIS Established Luiz Augusto von Dentz
2022-03-12 1:24 ` [BlueZ,1/2] bthost: Fix not setting all parameters when using Create BIG cmd bluez.test.bot
0 siblings, 2 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2022-03-11 21:17 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Create BIG shall set proper values for interval, latency, rtn and phy.
---
emulator/bthost.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/emulator/bthost.c b/emulator/bthost.c
index a7a0b8428..75fa625b1 100644
--- a/emulator/bthost.c
+++ b/emulator/bthost.c
@@ -3104,8 +3104,11 @@ void bthost_create_big(struct bthost *bthost, uint8_t num_bis)
cp.handle = 0x01;
cp.adv_handle = 0x01;
cp.num_bis = num_bis;
+ put_le24(10000, cp.bis.sdu_interval);
cp.bis.sdu = 40;
- cp.bis.phy = 0x01;
+ cp.bis.latency = cpu_to_le16(10);
+ cp.bis.rtn = 0x02;
+ cp.bis.phy = 0x02;
send_command(bthost, BT_HCI_CMD_LE_CREATE_BIG, &cp, sizeof(cp));
}
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH BlueZ 2/2] btdev: Fix CIS Established
2022-03-11 21:17 [PATCH BlueZ 1/2] bthost: Fix not setting all parameters when using Create BIG cmd Luiz Augusto von Dentz
@ 2022-03-11 21:17 ` Luiz Augusto von Dentz
2022-03-12 1:24 ` [BlueZ,1/2] bthost: Fix not setting all parameters when using Create BIG cmd bluez.test.bot
1 sibling, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2022-03-11 21:17 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
CIS Established was using the ISO latency instead of SDU interval for
transport latency.
---
emulator/btdev.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/emulator/btdev.c b/emulator/btdev.c
index 09eadd24f..c60ce6dbe 100644
--- a/emulator/btdev.c
+++ b/emulator/btdev.c
@@ -5774,10 +5774,10 @@ static void le_cis_estabilished(struct btdev *dev, struct btdev_conn *conn,
sizeof(remote->le_cig.params.c_interval));
memcpy(evt.cis_sync_delay, remote->le_cig.params.p_interval,
sizeof(remote->le_cig.params.p_interval));
- memcpy(evt.c_latency, &remote->le_cig.params.c_latency,
- sizeof(remote->le_cig.params.c_latency));
- memcpy(evt.p_latency, &remote->le_cig.params.p_latency,
- sizeof(remote->le_cig.params.p_latency));
+ memcpy(evt.c_latency, &remote->le_cig.params.c_interval,
+ sizeof(remote->le_cig.params.c_interval));
+ memcpy(evt.p_latency, &remote->le_cig.params.p_interval,
+ sizeof(remote->le_cig.params.p_interval));
evt.c_phy = remote->le_cig.cis[0].c_phy;
evt.p_phy = remote->le_cig.cis[0].p_phy;
evt.nse = 0x01;
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [BlueZ,1/2] bthost: Fix not setting all parameters when using Create BIG cmd
2022-03-11 21:17 [PATCH BlueZ 1/2] bthost: Fix not setting all parameters when using Create BIG cmd Luiz Augusto von Dentz
2022-03-11 21:17 ` [PATCH BlueZ 2/2] btdev: Fix CIS Established Luiz Augusto von Dentz
@ 2022-03-12 1:24 ` bluez.test.bot
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2022-03-12 1:24 UTC (permalink / raw)
To: linux-bluetooth, luiz.dentz
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=622790
---Test result---
Test Summary:
CheckPatch PASS 3.05 seconds
GitLint PASS 2.12 seconds
Prep - Setup ELL PASS 55.50 seconds
Build - Prep PASS 0.88 seconds
Build - Configure PASS 11.01 seconds
Build - Make PASS 1549.91 seconds
Make Check PASS 12.81 seconds
Make Check w/Valgrind PASS 566.40 seconds
Make Distcheck PASS 295.67 seconds
Build w/ext ELL - Configure PASS 11.28 seconds
Build w/ext ELL - Make PASS 1520.49 seconds
Incremental Build with patchesPASS 3122.33 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-12 1:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-11 21:17 [PATCH BlueZ 1/2] bthost: Fix not setting all parameters when using Create BIG cmd Luiz Augusto von Dentz
2022-03-11 21:17 ` [PATCH BlueZ 2/2] btdev: Fix CIS Established Luiz Augusto von Dentz
2022-03-12 1:24 ` [BlueZ,1/2] bthost: Fix not setting all parameters when using Create BIG cmd bluez.test.bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.