[PATCH] clk: bcm2835: Remove unused variable

[PATCH] clk: bcm2835: Remove unused variable

[Maxime Ripard]

Since commit 8ca011ef4af4 ("clk: bcm-2835: Remove rounding up the
dividers"), the rem variable is still set but no longer used. Remove it.

Fixes: 8ca011ef4af4 ("clk: bcm-2835: Remove rounding up the dividers")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 drivers/clk/bcm/clk-bcm2835.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index 3667b4d731e7..3ad20e75fd23 100644
--- a/drivers/clk/bcm/clk-bcm2835.c
+++ b/drivers/clk/bcm/clk-bcm2835.c
@@ -939,10 +939,8 @@ static u32 bcm2835_clock_choose_div(struct clk_hw *hw,
 	u32 unused_frac_mask =
 		GENMASK(CM_DIV_FRAC_BITS - data->frac_bits, 0) >> 1;
 	u64 temp = (u64)parent_rate << CM_DIV_FRAC_BITS;
-	u64 rem;
 	u32 div, mindiv, maxdiv;
 
-	rem = do_div(temp, rate);
 	div = temp;
 	div &= ~unused_frac_mask;
 
-- 
2.35.1

Re: [PATCH] clk: bcm2835: Remove unused variable

[Florian Fainelli]

On 2/22/2022 6:07 AM, Maxime Ripard wrote:
> Since commit 8ca011ef4af4 ("clk: bcm-2835: Remove rounding up the
> dividers"), the rem variable is still set but no longer used. Remove it.
> 
> Fixes: 8ca011ef4af4 ("clk: bcm-2835: Remove rounding up the dividers")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH] clk: bcm2835: Remove unused variable

[Stephen Boyd]

Quoting Maxime Ripard (2022-02-22 06:07:32)
> Since commit 8ca011ef4af4 ("clk: bcm-2835: Remove rounding up the
> dividers"), the rem variable is still set but no longer used. Remove it.
> 
> Fixes: 8ca011ef4af4 ("clk: bcm-2835: Remove rounding up the dividers")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---

Applied to clk-next