[PATCH] SUNRPC/xprt: fix call_kern.cocci warnings

[PATCH] SUNRPC/xprt: fix call_kern.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1926 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: NeilBrown <neilb@suse.de>
CC: Trond Myklebust <trond.myklebust@hammerspace.com>
CC: Anna Schumaker <anna@kernel.org>
CC: Chuck Lever <chuck.lever@oracle.com>
CC: Jakub Kicinski <kuba@kernel.org>
CC: linux-nfs(a)vger.kernel.org
CC: netdev(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

net/sunrpc/xprt.c:1690:18-28: ERROR: function xprt_dynamic_alloc_slot called on line 1728 inside lock on line 1722 but uses GFP_KERNEL

 Find functions that refer to GFP_KERNEL but are called with locks held.

Semantic patch information:
 The proposed change of converting the GFP_KERNEL is not necessarily the
 correct one.  It may be desired to unlock the lock, or to not call the
 function under the lock in the first place.

Generated by: scripts/coccinelle/locks/call_kern.cocci

Fixes: a721035477fb ("SUNRPC/xprt: async tasks mustn't block waiting for memory")
CC: NeilBrown <neilb@suse.de>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git linux-next
head:   693486d5f8951780a9bb31f7fe935171a80010e4
commit: a721035477fb5fb8abc738fbe410b07c12af3dc5 [59/66] SUNRPC/xprt: async tasks mustn't block waiting for memory
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago

Please take the patch only if it's a positive warning. Thanks!

 net/sunrpc/xprt.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/sunrpc/xprt.c
+++ b/net/sunrpc/xprt.c
@@ -1687,7 +1687,7 @@ out:
 static struct rpc_rqst *xprt_dynamic_alloc_slot(struct rpc_xprt *xprt)
 {
 	struct rpc_rqst *req = ERR_PTR(-EAGAIN);
-	gfp_t gfp_mask = GFP_KERNEL;
+	gfp_t gfp_mask = GFP_ATOMIC;
 
 	if (xprt->num_reqs >= xprt->max_reqs)
 		goto out;

[trondmy-nfs-2.6:linux-next 59/66] net/sunrpc/xprt.c:1690:18-28: ERROR: function xprt_dynamic_alloc_slot called on line 1728 inside lock on line 1722 but uses GFP_KERNEL

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: NeilBrown <neilb@suse.de>
CC: Trond Myklebust <trond.myklebust@hammerspace.com>

tree:   git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git linux-next
head:   693486d5f8951780a9bb31f7fe935171a80010e4
commit: a721035477fb5fb8abc738fbe410b07c12af3dc5 [59/66] SUNRPC/xprt: async tasks mustn't block waiting for memory
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago
config: alpha-allmodconfig (https://download.01.org/0day-ci/archive/20220314/202203141129.Lt2sd2kq-lkp(a)intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> net/sunrpc/xprt.c:1690:18-28: ERROR: function xprt_dynamic_alloc_slot called on line 1728 inside lock on line 1722 but uses GFP_KERNEL

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[PATCH] SUNRPC/xprt: fix call_kern.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
TO: Sasha Levin <sashal@kernel.org>

From: kernel test robot <lkp@intel.com>

net/sunrpc/xprt.c:1638:18-28: ERROR: function xprt_dynamic_alloc_slot called on line 1676 inside lock on line 1670 but uses GFP_KERNEL

 Find functions that refer to GFP_KERNEL but are called with locks held.

Semantic patch information:
 The proposed change of converting the GFP_KERNEL is not necessarily the
 correct one.  It may be desired to unlock the lock, or to not call the
 function under the lock in the first place.

Generated by: scripts/coccinelle/locks/call_kern.cocci

Fixes: ab3f07e5a52e ("SUNRPC/xprt: async tasks mustn't block waiting for memory")
CC: NeilBrown <neilb@suse.de>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git pending-5.10
head:   9008a65557dbcc00c1a0874eae6fd0601dece970
commit: ab3f07e5a52e2eeeede7ecb0f35092f496bc6120 [84/98] SUNRPC/xprt: async tasks mustn't block waiting for memory
:::::: branch date: 6 hours ago
:::::: commit date: 8 hours ago

Please take the patch only if it's a positive warning. Thanks!

 net/sunrpc/xprt.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/sunrpc/xprt.c
+++ b/net/sunrpc/xprt.c
@@ -1635,7 +1635,7 @@ out:
 static struct rpc_rqst *xprt_dynamic_alloc_slot(struct rpc_xprt *xprt)
 {
 	struct rpc_rqst *req = ERR_PTR(-EAGAIN);
-	gfp_t gfp_mask = GFP_KERNEL;
+	gfp_t gfp_mask = GFP_ATOMIC;
 
 	if (xprt->num_reqs >= xprt->max_reqs)
 		goto out;