* [PATCH] iommu/amd: Remove redundant check
@ 2022-03-14 7:02 Vasant Hegde via iommu
2022-03-28 9:28 ` Vasant Hegde via iommu
2022-04-28 7:58 ` Joerg Roedel
0 siblings, 2 replies; 3+ messages in thread
From: Vasant Hegde via iommu @ 2022-03-14 7:02 UTC (permalink / raw)
To: iommu, joro; +Cc: Dan Carpenter, Vasant Hegde
smatch static checker warning:
drivers/iommu/amd/init.c:1989 amd_iommu_init_pci()
warn: duplicate check 'ret' (previous on line 1978)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 06687a03805e ("iommu/amd: Improve error handling for amd_iommu_init_pci")
Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
---
drivers/iommu/amd/init.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
index 2586e589e54e..8ed1f86fe93d 100644
--- a/drivers/iommu/amd/init.c
+++ b/drivers/iommu/amd/init.c
@@ -2137,8 +2137,7 @@ static int __init amd_iommu_init_pci(void)
for_each_iommu(iommu)
iommu_flush_all_caches(iommu);
- if (!ret)
- print_iommu_info();
+ print_iommu_info();
out:
return ret;
--
2.27.0
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/amd: Remove redundant check
2022-03-14 7:02 [PATCH] iommu/amd: Remove redundant check Vasant Hegde via iommu
@ 2022-03-28 9:28 ` Vasant Hegde via iommu
2022-04-28 7:58 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Vasant Hegde via iommu @ 2022-03-28 9:28 UTC (permalink / raw)
To: iommu, joro; +Cc: Dan Carpenter
Joerg,
Ping.
-Vasant
On 3/14/2022 12:32 PM, Vasant Hegde via iommu wrote:
> smatch static checker warning:
> drivers/iommu/amd/init.c:1989 amd_iommu_init_pci()
> warn: duplicate check 'ret' (previous on line 1978)
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: 06687a03805e ("iommu/amd: Improve error handling for amd_iommu_init_pci")
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> ---
> drivers/iommu/amd/init.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index 2586e589e54e..8ed1f86fe93d 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -2137,8 +2137,7 @@ static int __init amd_iommu_init_pci(void)
> for_each_iommu(iommu)
> iommu_flush_all_caches(iommu);
>
> - if (!ret)
> - print_iommu_info();
> + print_iommu_info();
>
> out:
> return ret;
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/amd: Remove redundant check
2022-03-14 7:02 [PATCH] iommu/amd: Remove redundant check Vasant Hegde via iommu
2022-03-28 9:28 ` Vasant Hegde via iommu
@ 2022-04-28 7:58 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2022-04-28 7:58 UTC (permalink / raw)
To: Vasant Hegde; +Cc: iommu, Dan Carpenter
On Mon, Mar 14, 2022 at 12:32:26PM +0530, Vasant Hegde wrote:
> smatch static checker warning:
> drivers/iommu/amd/init.c:1989 amd_iommu_init_pci()
> warn: duplicate check 'ret' (previous on line 1978)
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: 06687a03805e ("iommu/amd: Improve error handling for amd_iommu_init_pci")
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
Applied, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-28 7:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-14 7:02 [PATCH] iommu/amd: Remove redundant check Vasant Hegde via iommu
2022-03-28 9:28 ` Vasant Hegde via iommu
2022-04-28 7:58 ` Joerg Roedel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.