* [PATCH] arch:x86:xen: Remove unnecessary assignment in xen_apic_read()
@ 2022-03-14 7:05 jianchunfu
2022-03-16 21:48 ` Boris Ostrovsky
0 siblings, 1 reply; 2+ messages in thread
From: jianchunfu @ 2022-03-14 7:05 UTC (permalink / raw)
To: tglx
Cc: x86, hpa, boris.ostrovsky, sstabellini, xen-devel, trivial, jianchunfu
In the function xen_apic_read(), the initialized value of 'ret' is unused
because it will be assigned by the function HYPERVISOR_platform_op(),
thus remove it.
Signed-off-by: jianchunfu <jianchunfu@cmss.chinamobile.com>
---
arch/x86/xen/apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c
index 0d46cc283..62d34b661 100644
--- a/arch/x86/xen/apic.c
+++ b/arch/x86/xen/apic.c
@@ -51,7 +51,7 @@ static u32 xen_apic_read(u32 reg)
.interface_version = XENPF_INTERFACE_VERSION,
.u.pcpu_info.xen_cpuid = 0,
};
- int ret = 0;
+ int ret;
/* Shouldn't need this as APIC is turned off for PV, and we only
* get called on the bootup processor. But just in case. */
--
2.18.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arch:x86:xen: Remove unnecessary assignment in xen_apic_read()
2022-03-14 7:05 [PATCH] arch:x86:xen: Remove unnecessary assignment in xen_apic_read() jianchunfu
@ 2022-03-16 21:48 ` Boris Ostrovsky
0 siblings, 0 replies; 2+ messages in thread
From: Boris Ostrovsky @ 2022-03-16 21:48 UTC (permalink / raw)
To: jianchunfu, tglx; +Cc: x86, hpa, sstabellini, xen-devel, trivial
On 3/14/22 3:05 AM, jianchunfu wrote:
> In the function xen_apic_read(), the initialized value of 'ret' is unused
> because it will be assigned by the function HYPERVISOR_platform_op(),
> thus remove it.
>
> Signed-off-by: jianchunfu <jianchunfu@cmss.chinamobile.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Applied to for-linus-5.18 (both patches)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-16 21:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-14 7:05 [PATCH] arch:x86:xen: Remove unnecessary assignment in xen_apic_read() jianchunfu
2022-03-16 21:48 ` Boris Ostrovsky
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.