From: kernel test robot <lkp@intel.com> To: Dietmar Eggemann <dietmar.eggemann@arm.com>, Darren Hart <darren@os.amperecomputing.com> Cc: kbuild-all@lists.01.org, Vincent Guittot <vincent.guittot@linaro.org>, Will Deacon <will@kernel.org>, LKML <linux-kernel@vger.kernel.org>, Linux Arm <linux-arm-kernel@lists.infradead.org>, Sudeep Holla <sudeep.holla@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Catalin Marinas <Catalin.Marinas@arm.com>, Barry Song <song.bao.hua@hisilicon.com>, Valentin Schneider <Valentin.Schneider@arm.com>, "D . Scott Phillips" <scott@os.amperecomputing.com>, Ilkka Koskinen <ilkka@os.amperecomputing.com>, stable@vger.kernel.org Subject: Re: [PATCH] arch_topology: Swap MC & CLS SD mask if MC weight==1 & Date: Tue, 15 Mar 2022 05:29:41 +0800 [thread overview] Message-ID: <202203150553.QRvgHFHm-lkp@intel.com> (raw) In-Reply-To: <9398d7ad-30e7-890a-3e18-c3011c383585@arm.com> Hi Dietmar, I love your patch! Perhaps something to improve: [auto build test WARNING on driver-core/driver-core-testing] [also build test WARNING on v5.17-rc8 next-20220310] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Dietmar-Eggemann/arch_topology-Swap-MC-CLS-SD-mask-if-MC-weight-1/20220315-004742 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 4a248f85b3dd8e010ff8335755c927130e9b0764 config: arm-defconfig (https://download.01.org/0day-ci/archive/20220315/202203150553.QRvgHFHm-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/7528fb2ea1e30038ee1dcc48df9d413502977895 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dietmar-Eggemann/arch_topology-Swap-MC-CLS-SD-mask-if-MC-weight-1/20220315-004742 git checkout 7528fb2ea1e30038ee1dcc48df9d413502977895 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/base/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> drivers/base/arch_topology.c:617:23: warning: no previous prototype for '_cpu_coregroup_mask' [-Wmissing-prototypes] 617 | const struct cpumask *_cpu_coregroup_mask(int cpu) | ^~~~~~~~~~~~~~~~~~~ >> drivers/base/arch_topology.c:634:23: warning: no previous prototype for '_cpu_clustergroup_mask' [-Wmissing-prototypes] 634 | const struct cpumask *_cpu_clustergroup_mask(int cpu) | ^~~~~~~~~~~~~~~~~~~~~~ vim +/_cpu_coregroup_mask +617 drivers/base/arch_topology.c 616 > 617 const struct cpumask *_cpu_coregroup_mask(int cpu) 618 { 619 const cpumask_t *core_mask = cpumask_of_node(cpu_to_node(cpu)); 620 621 /* Find the smaller of NUMA, core or LLC siblings */ 622 if (cpumask_subset(&cpu_topology[cpu].core_sibling, core_mask)) { 623 /* not numa in package, lets use the package siblings */ 624 core_mask = &cpu_topology[cpu].core_sibling; 625 } 626 if (cpu_topology[cpu].llc_id != -1) { 627 if (cpumask_subset(&cpu_topology[cpu].llc_sibling, core_mask)) 628 core_mask = &cpu_topology[cpu].llc_sibling; 629 } 630 631 return core_mask; 632 } 633 > 634 const struct cpumask *_cpu_clustergroup_mask(int cpu) 635 { 636 return &cpu_topology[cpu].cluster_sibling; 637 } 638 --- 0-DAY CI Kernel Test Service https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: Dietmar Eggemann <dietmar.eggemann@arm.com>, Darren Hart <darren@os.amperecomputing.com> Cc: kbuild-all@lists.01.org, Vincent Guittot <vincent.guittot@linaro.org>, Will Deacon <will@kernel.org>, LKML <linux-kernel@vger.kernel.org>, Linux Arm <linux-arm-kernel@lists.infradead.org>, Sudeep Holla <sudeep.holla@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Catalin Marinas <Catalin.Marinas@arm.com>, Barry Song <song.bao.hua@hisilicon.com>, Valentin Schneider <Valentin.Schneider@arm.com>, "D . Scott Phillips" <scott@os.amperecomputing.com>, Ilkka Koskinen <ilkka@os.amperecomputing.com>, stable@vger.kernel.org Subject: Re: [PATCH] arch_topology: Swap MC & CLS SD mask if MC weight==1 & Date: Tue, 15 Mar 2022 05:29:41 +0800 [thread overview] Message-ID: <202203150553.QRvgHFHm-lkp@intel.com> (raw) In-Reply-To: <9398d7ad-30e7-890a-3e18-c3011c383585@arm.com> Hi Dietmar, I love your patch! Perhaps something to improve: [auto build test WARNING on driver-core/driver-core-testing] [also build test WARNING on v5.17-rc8 next-20220310] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Dietmar-Eggemann/arch_topology-Swap-MC-CLS-SD-mask-if-MC-weight-1/20220315-004742 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 4a248f85b3dd8e010ff8335755c927130e9b0764 config: arm-defconfig (https://download.01.org/0day-ci/archive/20220315/202203150553.QRvgHFHm-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/7528fb2ea1e30038ee1dcc48df9d413502977895 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dietmar-Eggemann/arch_topology-Swap-MC-CLS-SD-mask-if-MC-weight-1/20220315-004742 git checkout 7528fb2ea1e30038ee1dcc48df9d413502977895 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/base/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> drivers/base/arch_topology.c:617:23: warning: no previous prototype for '_cpu_coregroup_mask' [-Wmissing-prototypes] 617 | const struct cpumask *_cpu_coregroup_mask(int cpu) | ^~~~~~~~~~~~~~~~~~~ >> drivers/base/arch_topology.c:634:23: warning: no previous prototype for '_cpu_clustergroup_mask' [-Wmissing-prototypes] 634 | const struct cpumask *_cpu_clustergroup_mask(int cpu) | ^~~~~~~~~~~~~~~~~~~~~~ vim +/_cpu_coregroup_mask +617 drivers/base/arch_topology.c 616 > 617 const struct cpumask *_cpu_coregroup_mask(int cpu) 618 { 619 const cpumask_t *core_mask = cpumask_of_node(cpu_to_node(cpu)); 620 621 /* Find the smaller of NUMA, core or LLC siblings */ 622 if (cpumask_subset(&cpu_topology[cpu].core_sibling, core_mask)) { 623 /* not numa in package, lets use the package siblings */ 624 core_mask = &cpu_topology[cpu].core_sibling; 625 } 626 if (cpu_topology[cpu].llc_id != -1) { 627 if (cpumask_subset(&cpu_topology[cpu].llc_sibling, core_mask)) 628 core_mask = &cpu_topology[cpu].llc_sibling; 629 } 630 631 return core_mask; 632 } 633 > 634 const struct cpumask *_cpu_clustergroup_mask(int cpu) 635 { 636 return &cpu_topology[cpu].cluster_sibling; 637 } 638 --- 0-DAY CI Kernel Test Service https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-14 21:30 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-04 17:01 [PATCH v3] topology: make core_mask include at least cluster_siblings Darren Hart 2022-03-04 17:01 ` Darren Hart 2022-03-08 10:30 ` Will Deacon 2022-03-08 10:30 ` Will Deacon 2022-03-08 10:45 ` Sudeep Holla 2022-03-08 10:45 ` Sudeep Holla 2022-03-08 11:04 ` Vincent Guittot 2022-03-08 11:04 ` Vincent Guittot 2022-03-08 16:03 ` Dietmar Eggemann 2022-03-08 16:03 ` Dietmar Eggemann 2022-03-08 17:49 ` Darren Hart 2022-03-08 17:49 ` Darren Hart 2022-03-09 12:50 ` Dietmar Eggemann 2022-03-09 12:50 ` Dietmar Eggemann 2022-03-09 18:26 ` Darren Hart 2022-03-09 18:26 ` Darren Hart 2022-03-14 9:37 ` Dietmar Eggemann 2022-03-14 9:37 ` Dietmar Eggemann 2022-03-14 16:56 ` Darren Hart 2022-03-14 16:56 ` Darren Hart 2022-03-16 14:42 ` Dietmar Eggemann 2022-03-16 14:42 ` Dietmar Eggemann 2022-03-14 16:35 ` Dietmar Eggemann 2022-03-14 16:35 ` Dietmar Eggemann 2022-03-14 16:54 ` Darren Hart 2022-03-14 16:54 ` Darren Hart 2022-03-16 14:48 ` Dietmar Eggemann 2022-03-16 14:48 ` Dietmar Eggemann 2022-03-16 15:20 ` Darren Hart 2022-03-16 15:20 ` Darren Hart 2022-03-16 15:55 ` Sudeep Holla 2022-03-16 15:55 ` Sudeep Holla 2022-03-21 14:30 ` Will Deacon 2022-03-21 14:30 ` Will Deacon 2022-03-21 15:56 ` Greg Kroah-Hartman 2022-03-21 15:56 ` Greg Kroah-Hartman 2022-03-14 21:29 ` kernel test robot [this message] 2022-03-14 21:29 ` [PATCH] arch_topology: Swap MC & CLS SD mask if MC weight==1 & kernel test robot 2022-03-14 23:02 ` kernel test robot 2022-03-14 23:02 ` kernel test robot 2022-03-17 6:10 ` [PATCH v3] topology: make core_mask include at least cluster_siblings Barry Song 2022-03-17 6:10 ` Barry Song
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202203150553.QRvgHFHm-lkp@intel.com \ --to=lkp@intel.com \ --cc=Catalin.Marinas@arm.com \ --cc=Valentin.Schneider@arm.com \ --cc=darren@os.amperecomputing.com \ --cc=dietmar.eggemann@arm.com \ --cc=gregkh@linuxfoundation.org \ --cc=ilkka@os.amperecomputing.com \ --cc=kbuild-all@lists.01.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rafael@kernel.org \ --cc=scott@os.amperecomputing.com \ --cc=song.bao.hua@hisilicon.com \ --cc=stable@vger.kernel.org \ --cc=sudeep.holla@arm.com \ --cc=vincent.guittot@linaro.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.