* drivers/vdpa/mlx5/net/mlx5_vnet.c:2063 mlx5_vdpa_dev_add() error: uninitialized symbol 'pfmdev'.
@ 2022-03-14 22:31 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2022-03-14 22:31 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 7149 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Eli Cohen <elic@nvidia.com>
CC: Saeed Mahameed <saeedm@nvidia.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 09688c0166e76ce2fb85e86b9d99be8b0084cdf9
commit: 7c9f131f366ab414691907fa0407124ea2b2f3bc {net,vdpa}/mlx5: Configure interface MAC into mpfs L2 table
date: 10 months ago
:::::: branch date: 26 hours ago
:::::: commit date: 10 months ago
config: riscv-randconfig-m031-20220313 (https://download.01.org/0day-ci/archive/20220315/202203150629.HhcGYLEN-lkp(a)intel.com/config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/vdpa/mlx5/net/mlx5_vnet.c:2063 mlx5_vdpa_dev_add() error: uninitialized symbol 'pfmdev'.
Old smatch warnings:
drivers/vdpa/mlx5/net/mlx5_vnet.c:638 umem_size() error: uninitialized symbol 'p_a'.
drivers/vdpa/mlx5/net/mlx5_vnet.c:638 umem_size() error: uninitialized symbol 'p_b'.
drivers/vdpa/mlx5/net/mlx5_vnet.c:720 umem_destroy() error: potentially dereferencing uninitialized 'umem'.
vim +/pfmdev +2063 drivers/vdpa/mlx5/net/mlx5_vnet.c
58926c8aab104da Eli Cohen 2021-04-08 1994
58926c8aab104da Eli Cohen 2021-04-08 1995 static int mlx5_vdpa_dev_add(struct vdpa_mgmt_dev *v_mdev, const char *name)
1a86b377aa2147a Eli Cohen 2020-08-04 1996 {
58926c8aab104da Eli Cohen 2021-04-08 1997 struct mlx5_vdpa_mgmtdev *mgtdev = container_of(v_mdev, struct mlx5_vdpa_mgmtdev, mgtdev);
1a86b377aa2147a Eli Cohen 2020-08-04 1998 struct virtio_net_config *config;
7c9f131f366ab41 Eli Cohen 2021-04-22 1999 struct mlx5_core_dev *pfmdev;
1a86b377aa2147a Eli Cohen 2020-08-04 2000 struct mlx5_vdpa_dev *mvdev;
1a86b377aa2147a Eli Cohen 2020-08-04 2001 struct mlx5_vdpa_net *ndev;
58926c8aab104da Eli Cohen 2021-04-08 2002 struct mlx5_core_dev *mdev;
1a86b377aa2147a Eli Cohen 2020-08-04 2003 u32 max_vqs;
1a86b377aa2147a Eli Cohen 2020-08-04 2004 int err;
1a86b377aa2147a Eli Cohen 2020-08-04 2005
58926c8aab104da Eli Cohen 2021-04-08 2006 if (mgtdev->ndev)
58926c8aab104da Eli Cohen 2021-04-08 2007 return -ENOSPC;
58926c8aab104da Eli Cohen 2021-04-08 2008
58926c8aab104da Eli Cohen 2021-04-08 2009 mdev = mgtdev->madev->mdev;
1a86b377aa2147a Eli Cohen 2020-08-04 2010 /* we save one virtqueue for control virtqueue should we require it */
1a86b377aa2147a Eli Cohen 2020-08-04 2011 max_vqs = MLX5_CAP_DEV_VDPA_EMULATION(mdev, max_num_virtio_queues);
1a86b377aa2147a Eli Cohen 2020-08-04 2012 max_vqs = min_t(u32, max_vqs, MLX5_MAX_SUPPORTED_VQS);
1a86b377aa2147a Eli Cohen 2020-08-04 2013
1a86b377aa2147a Eli Cohen 2020-08-04 2014 ndev = vdpa_alloc_device(struct mlx5_vdpa_net, mvdev.vdev, mdev->device, &mlx5_vdpa_ops,
58926c8aab104da Eli Cohen 2021-04-08 2015 name);
1a86b377aa2147a Eli Cohen 2020-08-04 2016 if (IS_ERR(ndev))
74c9729dd892a1b Leon Romanovsky 2020-10-04 2017 return PTR_ERR(ndev);
1a86b377aa2147a Eli Cohen 2020-08-04 2018
1a86b377aa2147a Eli Cohen 2020-08-04 2019 ndev->mvdev.max_vqs = max_vqs;
1a86b377aa2147a Eli Cohen 2020-08-04 2020 mvdev = &ndev->mvdev;
1a86b377aa2147a Eli Cohen 2020-08-04 2021 mvdev->mdev = mdev;
1a86b377aa2147a Eli Cohen 2020-08-04 2022 init_mvqs(ndev);
1a86b377aa2147a Eli Cohen 2020-08-04 2023 mutex_init(&ndev->reslock);
1a86b377aa2147a Eli Cohen 2020-08-04 2024 config = &ndev->config;
d084d996aaf53c0 Si-Wei Liu 2021-04-08 2025 err = query_mtu(mdev, &ndev->mtu);
1a86b377aa2147a Eli Cohen 2020-08-04 2026 if (err)
1a86b377aa2147a Eli Cohen 2020-08-04 2027 goto err_mtu;
1a86b377aa2147a Eli Cohen 2020-08-04 2028
1a86b377aa2147a Eli Cohen 2020-08-04 2029 err = mlx5_query_nic_vport_mac_address(mdev, 0, 0, config->mac);
1a86b377aa2147a Eli Cohen 2020-08-04 2030 if (err)
1a86b377aa2147a Eli Cohen 2020-08-04 2031 goto err_mtu;
1a86b377aa2147a Eli Cohen 2020-08-04 2032
7c9f131f366ab41 Eli Cohen 2021-04-22 2033 if (!is_zero_ether_addr(config->mac)) {
7c9f131f366ab41 Eli Cohen 2021-04-22 2034 pfmdev = pci_get_drvdata(pci_physfn(mdev->pdev));
7c9f131f366ab41 Eli Cohen 2021-04-22 2035 err = mlx5_mpfs_add_mac(pfmdev, config->mac);
7c9f131f366ab41 Eli Cohen 2021-04-22 2036 if (err)
7c9f131f366ab41 Eli Cohen 2021-04-22 2037 goto err_mtu;
7c9f131f366ab41 Eli Cohen 2021-04-22 2038 }
7c9f131f366ab41 Eli Cohen 2021-04-22 2039
1a86b377aa2147a Eli Cohen 2020-08-04 2040 mvdev->vdev.dma_dev = mdev->device;
1a86b377aa2147a Eli Cohen 2020-08-04 2041 err = mlx5_vdpa_alloc_resources(&ndev->mvdev);
1a86b377aa2147a Eli Cohen 2020-08-04 2042 if (err)
7c9f131f366ab41 Eli Cohen 2021-04-22 2043 goto err_mpfs;
1a86b377aa2147a Eli Cohen 2020-08-04 2044
1a86b377aa2147a Eli Cohen 2020-08-04 2045 err = alloc_resources(ndev);
1a86b377aa2147a Eli Cohen 2020-08-04 2046 if (err)
1a86b377aa2147a Eli Cohen 2020-08-04 2047 goto err_res;
1a86b377aa2147a Eli Cohen 2020-08-04 2048
58926c8aab104da Eli Cohen 2021-04-08 2049 mvdev->vdev.mdev = &mgtdev->mgtdev;
58926c8aab104da Eli Cohen 2021-04-08 2050 err = _vdpa_register_device(&mvdev->vdev, 2 * mlx5_vdpa_max_qps(max_vqs));
1a86b377aa2147a Eli Cohen 2020-08-04 2051 if (err)
1a86b377aa2147a Eli Cohen 2020-08-04 2052 goto err_reg;
1a86b377aa2147a Eli Cohen 2020-08-04 2053
58926c8aab104da Eli Cohen 2021-04-08 2054 mgtdev->ndev = ndev;
74c9729dd892a1b Leon Romanovsky 2020-10-04 2055 return 0;
1a86b377aa2147a Eli Cohen 2020-08-04 2056
1a86b377aa2147a Eli Cohen 2020-08-04 2057 err_reg:
1a86b377aa2147a Eli Cohen 2020-08-04 2058 free_resources(ndev);
1a86b377aa2147a Eli Cohen 2020-08-04 2059 err_res:
1a86b377aa2147a Eli Cohen 2020-08-04 2060 mlx5_vdpa_free_resources(&ndev->mvdev);
7c9f131f366ab41 Eli Cohen 2021-04-22 2061 err_mpfs:
7c9f131f366ab41 Eli Cohen 2021-04-22 2062 if (!is_zero_ether_addr(config->mac))
7c9f131f366ab41 Eli Cohen 2021-04-22 @2063 mlx5_mpfs_del_mac(pfmdev, config->mac);
1a86b377aa2147a Eli Cohen 2020-08-04 2064 err_mtu:
1a86b377aa2147a Eli Cohen 2020-08-04 2065 mutex_destroy(&ndev->reslock);
1a86b377aa2147a Eli Cohen 2020-08-04 2066 put_device(&mvdev->vdev.dev);
74c9729dd892a1b Leon Romanovsky 2020-10-04 2067 return err;
1a86b377aa2147a Eli Cohen 2020-08-04 2068 }
1a86b377aa2147a Eli Cohen 2020-08-04 2069
---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* drivers/vdpa/mlx5/net/mlx5_vnet.c:2063 mlx5_vdpa_dev_add() error: uninitialized symbol 'pfmdev'.
@ 2023-12-11 6:02 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-12-11 6:02 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Eli Cohen <elic@nvidia.com>
CC: Saeed Mahameed <saeedm@nvidia.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a39b6ac3781d46ba18193c9dbb2110f31e9bffe9
commit: 7c9f131f366ab414691907fa0407124ea2b2f3bc {net,vdpa}/mlx5: Configure interface MAC into mpfs L2 table
date: 2 years, 7 months ago
:::::: branch date: 7 hours ago
:::::: commit date: 2 years, 7 months ago
config: i386-randconfig-141-20230929 (https://download.01.org/0day-ci/archive/20231211/202312111323.7TNjXNJF-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce: (https://download.01.org/0day-ci/archive/20231211/202312111323.7TNjXNJF-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312111323.7TNjXNJF-lkp@intel.com/
New smatch warnings:
drivers/vdpa/mlx5/net/mlx5_vnet.c:2063 mlx5_vdpa_dev_add() error: uninitialized symbol 'pfmdev'.
Old smatch warnings:
drivers/vdpa/mlx5/net/mlx5_vnet.c:638 umem_size() error: uninitialized symbol 'p_a'.
drivers/vdpa/mlx5/net/mlx5_vnet.c:638 umem_size() error: uninitialized symbol 'p_b'.
drivers/vdpa/mlx5/net/mlx5_vnet.c:720 umem_destroy() error: potentially dereferencing uninitialized 'umem'.
vim +/pfmdev +2063 drivers/vdpa/mlx5/net/mlx5_vnet.c
58926c8aab104d Eli Cohen 2021-04-08 1994
58926c8aab104d Eli Cohen 2021-04-08 1995 static int mlx5_vdpa_dev_add(struct vdpa_mgmt_dev *v_mdev, const char *name)
1a86b377aa2147 Eli Cohen 2020-08-04 1996 {
58926c8aab104d Eli Cohen 2021-04-08 1997 struct mlx5_vdpa_mgmtdev *mgtdev = container_of(v_mdev, struct mlx5_vdpa_mgmtdev, mgtdev);
1a86b377aa2147 Eli Cohen 2020-08-04 1998 struct virtio_net_config *config;
7c9f131f366ab4 Eli Cohen 2021-04-22 1999 struct mlx5_core_dev *pfmdev;
1a86b377aa2147 Eli Cohen 2020-08-04 2000 struct mlx5_vdpa_dev *mvdev;
1a86b377aa2147 Eli Cohen 2020-08-04 2001 struct mlx5_vdpa_net *ndev;
58926c8aab104d Eli Cohen 2021-04-08 2002 struct mlx5_core_dev *mdev;
1a86b377aa2147 Eli Cohen 2020-08-04 2003 u32 max_vqs;
1a86b377aa2147 Eli Cohen 2020-08-04 2004 int err;
1a86b377aa2147 Eli Cohen 2020-08-04 2005
58926c8aab104d Eli Cohen 2021-04-08 2006 if (mgtdev->ndev)
58926c8aab104d Eli Cohen 2021-04-08 2007 return -ENOSPC;
58926c8aab104d Eli Cohen 2021-04-08 2008
58926c8aab104d Eli Cohen 2021-04-08 2009 mdev = mgtdev->madev->mdev;
1a86b377aa2147 Eli Cohen 2020-08-04 2010 /* we save one virtqueue for control virtqueue should we require it */
1a86b377aa2147 Eli Cohen 2020-08-04 2011 max_vqs = MLX5_CAP_DEV_VDPA_EMULATION(mdev, max_num_virtio_queues);
1a86b377aa2147 Eli Cohen 2020-08-04 2012 max_vqs = min_t(u32, max_vqs, MLX5_MAX_SUPPORTED_VQS);
1a86b377aa2147 Eli Cohen 2020-08-04 2013
1a86b377aa2147 Eli Cohen 2020-08-04 2014 ndev = vdpa_alloc_device(struct mlx5_vdpa_net, mvdev.vdev, mdev->device, &mlx5_vdpa_ops,
58926c8aab104d Eli Cohen 2021-04-08 2015 name);
1a86b377aa2147 Eli Cohen 2020-08-04 2016 if (IS_ERR(ndev))
74c9729dd892a1 Leon Romanovsky 2020-10-04 2017 return PTR_ERR(ndev);
1a86b377aa2147 Eli Cohen 2020-08-04 2018
1a86b377aa2147 Eli Cohen 2020-08-04 2019 ndev->mvdev.max_vqs = max_vqs;
1a86b377aa2147 Eli Cohen 2020-08-04 2020 mvdev = &ndev->mvdev;
1a86b377aa2147 Eli Cohen 2020-08-04 2021 mvdev->mdev = mdev;
1a86b377aa2147 Eli Cohen 2020-08-04 2022 init_mvqs(ndev);
1a86b377aa2147 Eli Cohen 2020-08-04 2023 mutex_init(&ndev->reslock);
1a86b377aa2147 Eli Cohen 2020-08-04 2024 config = &ndev->config;
d084d996aaf53c Si-Wei Liu 2021-04-08 2025 err = query_mtu(mdev, &ndev->mtu);
1a86b377aa2147 Eli Cohen 2020-08-04 2026 if (err)
1a86b377aa2147 Eli Cohen 2020-08-04 2027 goto err_mtu;
1a86b377aa2147 Eli Cohen 2020-08-04 2028
1a86b377aa2147 Eli Cohen 2020-08-04 2029 err = mlx5_query_nic_vport_mac_address(mdev, 0, 0, config->mac);
1a86b377aa2147 Eli Cohen 2020-08-04 2030 if (err)
1a86b377aa2147 Eli Cohen 2020-08-04 2031 goto err_mtu;
1a86b377aa2147 Eli Cohen 2020-08-04 2032
7c9f131f366ab4 Eli Cohen 2021-04-22 2033 if (!is_zero_ether_addr(config->mac)) {
7c9f131f366ab4 Eli Cohen 2021-04-22 2034 pfmdev = pci_get_drvdata(pci_physfn(mdev->pdev));
7c9f131f366ab4 Eli Cohen 2021-04-22 2035 err = mlx5_mpfs_add_mac(pfmdev, config->mac);
7c9f131f366ab4 Eli Cohen 2021-04-22 2036 if (err)
7c9f131f366ab4 Eli Cohen 2021-04-22 2037 goto err_mtu;
7c9f131f366ab4 Eli Cohen 2021-04-22 2038 }
7c9f131f366ab4 Eli Cohen 2021-04-22 2039
1a86b377aa2147 Eli Cohen 2020-08-04 2040 mvdev->vdev.dma_dev = mdev->device;
1a86b377aa2147 Eli Cohen 2020-08-04 2041 err = mlx5_vdpa_alloc_resources(&ndev->mvdev);
1a86b377aa2147 Eli Cohen 2020-08-04 2042 if (err)
7c9f131f366ab4 Eli Cohen 2021-04-22 2043 goto err_mpfs;
1a86b377aa2147 Eli Cohen 2020-08-04 2044
1a86b377aa2147 Eli Cohen 2020-08-04 2045 err = alloc_resources(ndev);
1a86b377aa2147 Eli Cohen 2020-08-04 2046 if (err)
1a86b377aa2147 Eli Cohen 2020-08-04 2047 goto err_res;
1a86b377aa2147 Eli Cohen 2020-08-04 2048
58926c8aab104d Eli Cohen 2021-04-08 2049 mvdev->vdev.mdev = &mgtdev->mgtdev;
58926c8aab104d Eli Cohen 2021-04-08 2050 err = _vdpa_register_device(&mvdev->vdev, 2 * mlx5_vdpa_max_qps(max_vqs));
1a86b377aa2147 Eli Cohen 2020-08-04 2051 if (err)
1a86b377aa2147 Eli Cohen 2020-08-04 2052 goto err_reg;
1a86b377aa2147 Eli Cohen 2020-08-04 2053
58926c8aab104d Eli Cohen 2021-04-08 2054 mgtdev->ndev = ndev;
74c9729dd892a1 Leon Romanovsky 2020-10-04 2055 return 0;
1a86b377aa2147 Eli Cohen 2020-08-04 2056
1a86b377aa2147 Eli Cohen 2020-08-04 2057 err_reg:
1a86b377aa2147 Eli Cohen 2020-08-04 2058 free_resources(ndev);
1a86b377aa2147 Eli Cohen 2020-08-04 2059 err_res:
1a86b377aa2147 Eli Cohen 2020-08-04 2060 mlx5_vdpa_free_resources(&ndev->mvdev);
7c9f131f366ab4 Eli Cohen 2021-04-22 2061 err_mpfs:
7c9f131f366ab4 Eli Cohen 2021-04-22 2062 if (!is_zero_ether_addr(config->mac))
7c9f131f366ab4 Eli Cohen 2021-04-22 @2063 mlx5_mpfs_del_mac(pfmdev, config->mac);
1a86b377aa2147 Eli Cohen 2020-08-04 2064 err_mtu:
1a86b377aa2147 Eli Cohen 2020-08-04 2065 mutex_destroy(&ndev->reslock);
1a86b377aa2147 Eli Cohen 2020-08-04 2066 put_device(&mvdev->vdev.dev);
74c9729dd892a1 Leon Romanovsky 2020-10-04 2067 return err;
1a86b377aa2147 Eli Cohen 2020-08-04 2068 }
1a86b377aa2147 Eli Cohen 2020-08-04 2069
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* drivers/vdpa/mlx5/net/mlx5_vnet.c:2063 mlx5_vdpa_dev_add() error: uninitialized symbol 'pfmdev'.
@ 2021-11-26 12:18 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-11-26 12:18 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 7140 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Eli Cohen <elic@nvidia.com>
CC: Saeed Mahameed <saeedm@nvidia.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a4849f6000e29235a2707f22e39da6b897bb9543
commit: 7c9f131f366ab414691907fa0407124ea2b2f3bc {net,vdpa}/mlx5: Configure interface MAC into mpfs L2 table
date: 6 months ago
:::::: branch date: 10 hours ago
:::::: commit date: 6 months ago
config: ia64-randconfig-m031-20211122 (https://download.01.org/0day-ci/archive/20211126/202111262052.K4MjKwss-lkp(a)intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/vdpa/mlx5/net/mlx5_vnet.c:2063 mlx5_vdpa_dev_add() error: uninitialized symbol 'pfmdev'.
Old smatch warnings:
drivers/vdpa/mlx5/net/mlx5_vnet.c:638 umem_size() error: uninitialized symbol 'p_a'.
drivers/vdpa/mlx5/net/mlx5_vnet.c:638 umem_size() error: uninitialized symbol 'p_b'.
drivers/vdpa/mlx5/net/mlx5_vnet.c:720 umem_destroy() error: potentially dereferencing uninitialized 'umem'.
vim +/pfmdev +2063 drivers/vdpa/mlx5/net/mlx5_vnet.c
58926c8aab104da Eli Cohen 2021-04-08 1994
58926c8aab104da Eli Cohen 2021-04-08 1995 static int mlx5_vdpa_dev_add(struct vdpa_mgmt_dev *v_mdev, const char *name)
1a86b377aa2147a Eli Cohen 2020-08-04 1996 {
58926c8aab104da Eli Cohen 2021-04-08 1997 struct mlx5_vdpa_mgmtdev *mgtdev = container_of(v_mdev, struct mlx5_vdpa_mgmtdev, mgtdev);
1a86b377aa2147a Eli Cohen 2020-08-04 1998 struct virtio_net_config *config;
7c9f131f366ab41 Eli Cohen 2021-04-22 1999 struct mlx5_core_dev *pfmdev;
1a86b377aa2147a Eli Cohen 2020-08-04 2000 struct mlx5_vdpa_dev *mvdev;
1a86b377aa2147a Eli Cohen 2020-08-04 2001 struct mlx5_vdpa_net *ndev;
58926c8aab104da Eli Cohen 2021-04-08 2002 struct mlx5_core_dev *mdev;
1a86b377aa2147a Eli Cohen 2020-08-04 2003 u32 max_vqs;
1a86b377aa2147a Eli Cohen 2020-08-04 2004 int err;
1a86b377aa2147a Eli Cohen 2020-08-04 2005
58926c8aab104da Eli Cohen 2021-04-08 2006 if (mgtdev->ndev)
58926c8aab104da Eli Cohen 2021-04-08 2007 return -ENOSPC;
58926c8aab104da Eli Cohen 2021-04-08 2008
58926c8aab104da Eli Cohen 2021-04-08 2009 mdev = mgtdev->madev->mdev;
1a86b377aa2147a Eli Cohen 2020-08-04 2010 /* we save one virtqueue for control virtqueue should we require it */
1a86b377aa2147a Eli Cohen 2020-08-04 2011 max_vqs = MLX5_CAP_DEV_VDPA_EMULATION(mdev, max_num_virtio_queues);
1a86b377aa2147a Eli Cohen 2020-08-04 2012 max_vqs = min_t(u32, max_vqs, MLX5_MAX_SUPPORTED_VQS);
1a86b377aa2147a Eli Cohen 2020-08-04 2013
1a86b377aa2147a Eli Cohen 2020-08-04 2014 ndev = vdpa_alloc_device(struct mlx5_vdpa_net, mvdev.vdev, mdev->device, &mlx5_vdpa_ops,
58926c8aab104da Eli Cohen 2021-04-08 2015 name);
1a86b377aa2147a Eli Cohen 2020-08-04 2016 if (IS_ERR(ndev))
74c9729dd892a1b Leon Romanovsky 2020-10-04 2017 return PTR_ERR(ndev);
1a86b377aa2147a Eli Cohen 2020-08-04 2018
1a86b377aa2147a Eli Cohen 2020-08-04 2019 ndev->mvdev.max_vqs = max_vqs;
1a86b377aa2147a Eli Cohen 2020-08-04 2020 mvdev = &ndev->mvdev;
1a86b377aa2147a Eli Cohen 2020-08-04 2021 mvdev->mdev = mdev;
1a86b377aa2147a Eli Cohen 2020-08-04 2022 init_mvqs(ndev);
1a86b377aa2147a Eli Cohen 2020-08-04 2023 mutex_init(&ndev->reslock);
1a86b377aa2147a Eli Cohen 2020-08-04 2024 config = &ndev->config;
d084d996aaf53c0 Si-Wei Liu 2021-04-08 2025 err = query_mtu(mdev, &ndev->mtu);
1a86b377aa2147a Eli Cohen 2020-08-04 2026 if (err)
1a86b377aa2147a Eli Cohen 2020-08-04 2027 goto err_mtu;
1a86b377aa2147a Eli Cohen 2020-08-04 2028
1a86b377aa2147a Eli Cohen 2020-08-04 2029 err = mlx5_query_nic_vport_mac_address(mdev, 0, 0, config->mac);
1a86b377aa2147a Eli Cohen 2020-08-04 2030 if (err)
1a86b377aa2147a Eli Cohen 2020-08-04 2031 goto err_mtu;
1a86b377aa2147a Eli Cohen 2020-08-04 2032
7c9f131f366ab41 Eli Cohen 2021-04-22 2033 if (!is_zero_ether_addr(config->mac)) {
7c9f131f366ab41 Eli Cohen 2021-04-22 2034 pfmdev = pci_get_drvdata(pci_physfn(mdev->pdev));
7c9f131f366ab41 Eli Cohen 2021-04-22 2035 err = mlx5_mpfs_add_mac(pfmdev, config->mac);
7c9f131f366ab41 Eli Cohen 2021-04-22 2036 if (err)
7c9f131f366ab41 Eli Cohen 2021-04-22 2037 goto err_mtu;
7c9f131f366ab41 Eli Cohen 2021-04-22 2038 }
7c9f131f366ab41 Eli Cohen 2021-04-22 2039
1a86b377aa2147a Eli Cohen 2020-08-04 2040 mvdev->vdev.dma_dev = mdev->device;
1a86b377aa2147a Eli Cohen 2020-08-04 2041 err = mlx5_vdpa_alloc_resources(&ndev->mvdev);
1a86b377aa2147a Eli Cohen 2020-08-04 2042 if (err)
7c9f131f366ab41 Eli Cohen 2021-04-22 2043 goto err_mpfs;
1a86b377aa2147a Eli Cohen 2020-08-04 2044
1a86b377aa2147a Eli Cohen 2020-08-04 2045 err = alloc_resources(ndev);
1a86b377aa2147a Eli Cohen 2020-08-04 2046 if (err)
1a86b377aa2147a Eli Cohen 2020-08-04 2047 goto err_res;
1a86b377aa2147a Eli Cohen 2020-08-04 2048
58926c8aab104da Eli Cohen 2021-04-08 2049 mvdev->vdev.mdev = &mgtdev->mgtdev;
58926c8aab104da Eli Cohen 2021-04-08 2050 err = _vdpa_register_device(&mvdev->vdev, 2 * mlx5_vdpa_max_qps(max_vqs));
1a86b377aa2147a Eli Cohen 2020-08-04 2051 if (err)
1a86b377aa2147a Eli Cohen 2020-08-04 2052 goto err_reg;
1a86b377aa2147a Eli Cohen 2020-08-04 2053
58926c8aab104da Eli Cohen 2021-04-08 2054 mgtdev->ndev = ndev;
74c9729dd892a1b Leon Romanovsky 2020-10-04 2055 return 0;
1a86b377aa2147a Eli Cohen 2020-08-04 2056
1a86b377aa2147a Eli Cohen 2020-08-04 2057 err_reg:
1a86b377aa2147a Eli Cohen 2020-08-04 2058 free_resources(ndev);
1a86b377aa2147a Eli Cohen 2020-08-04 2059 err_res:
1a86b377aa2147a Eli Cohen 2020-08-04 2060 mlx5_vdpa_free_resources(&ndev->mvdev);
7c9f131f366ab41 Eli Cohen 2021-04-22 2061 err_mpfs:
7c9f131f366ab41 Eli Cohen 2021-04-22 2062 if (!is_zero_ether_addr(config->mac))
7c9f131f366ab41 Eli Cohen 2021-04-22 @2063 mlx5_mpfs_del_mac(pfmdev, config->mac);
1a86b377aa2147a Eli Cohen 2020-08-04 2064 err_mtu:
1a86b377aa2147a Eli Cohen 2020-08-04 2065 mutex_destroy(&ndev->reslock);
1a86b377aa2147a Eli Cohen 2020-08-04 2066 put_device(&mvdev->vdev.dev);
74c9729dd892a1b Leon Romanovsky 2020-10-04 2067 return err;
1a86b377aa2147a Eli Cohen 2020-08-04 2068 }
1a86b377aa2147a Eli Cohen 2020-08-04 2069
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-11 6:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-14 22:31 drivers/vdpa/mlx5/net/mlx5_vnet.c:2063 mlx5_vdpa_dev_add() error: uninitialized symbol 'pfmdev' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-12-11 6:02 kernel test robot
2021-11-26 12:18 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.