All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] i915_module_load: Unload the module before exiting the subtest
@ 2022-03-15  6:55 Bhanuprakash Modem
  2022-03-15  7:39 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 12+ messages in thread
From: Bhanuprakash Modem @ 2022-03-15  6:55 UTC (permalink / raw)
  To: igt-dev; +Cc: Chris Wilson

On DP-MST setup, after execution of "reload" subtest, i915
became unloadable. And this is effecting the next subtest
"reload-no-display".

Observing below error, if we run all subtests of i915_module_load
(or) run "reload" & "reload-no-display" in same order using the
igt_runner. But not seen any issue if we run each subtest individually.

$ ./igt_runner -o -l verbose -s --test-list tests.txt --use-watchdog ../tests/ results/
(or)
$ ./build/tests/i915_module_load
  Starting subtest: reload
  ...
  Subtest reload: SUCCESS (3.780s)

  Starting subtest: reload-no-display
  (i915_module_load:42617) igt_kmod-WARNING: Could not unload i915
  Module                   Used by
  i915                     1
  ...
  Reloading i915 with disable_display=1
  Module i915 already inserted
  Could not load i915
  Subtest reload-no-display: FAIL (1.998s)

$ ./build/tests/i915_module_load --r reload
  Starting subtest: reload
  ...
  Subtest reload: SUCCESS (5.562s)
$ ./build/tests/i915_module_load --r reload-no-display
  Starting subtest: reload-no-display
  ...
  Subtest reload-no-display: SUCCESS (7.995s)

This patch will unload the module before exiting the subtest. So
that we can make sure that the module is unloaded.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/i915_module_load.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/i915_module_load.c b/tests/i915/i915_module_load.c
index a86dd86cd0..c641a6a989 100644
--- a/tests/i915/i915_module_load.c
+++ b/tests/i915/i915_module_load.c
@@ -249,7 +249,7 @@ igt_main
 
 		gem_sanitycheck();
 
-		/* only default modparams, can leave module loaded */
+		igt_i915_driver_unload();
 	}
 
 	igt_subtest("reload-no-display") {
-- 
2.35.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2022-05-19  8:25 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-15  6:55 [igt-dev] [PATCH i-g-t] i915_module_load: Unload the module before exiting the subtest Bhanuprakash Modem
2022-03-15  7:39 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-03-15  8:43 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-15 11:43 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2022-03-15 12:05   ` Modem, Bhanuprakash
2022-03-15 13:31     ` Petri Latvala
2022-03-16  5:18       ` Modem, Bhanuprakash
2022-05-19  7:30     ` Sharma, Swati2
2022-05-19  8:22       ` Petri Latvala
2022-04-29 12:51 ` [igt-dev] ✗ Fi.CI.BAT: failure for i915_module_load: Unload the module before exiting the subtest (rev2) Patchwork
2022-05-09 10:32 ` [igt-dev] ✓ Fi.CI.BAT: success for i915_module_load: Unload the module before exiting the subtest (rev3) Patchwork
2022-05-09 14:59 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.