From: Alper Nebi Yasak <alpernebiyasak@gmail.com>
To: u-boot@lists.denx.de
Cc: Faiz Abbas <faiz_abbas@ti.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Peter Robinson <pbrobinson@gmail.com>,
Peng Fan <peng.fan@nxp.com>, Peter Geis <pgwipeout@gmail.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Samuel Dionne-Riel <samuel@dionne-riel.com>,
Simon Glass <sjg@chromium.org>,
Kever Yang <kever.yang@rock-chips.com>,
Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>,
Aswath Govindraju <a-govindraju@ti.com>,
Jack Mitchell <ml@embed.me.uk>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Yifeng Zhao <yifeng.zhao@rock-chips.com>,
Michal Simek <michal.simek@xilinx.com>,
Stephen Carlson <stcarlso@linux.microsoft.com>,
Alper Nebi Yasak <alpernebiyasak@gmail.com>
Subject: [PATCH v5 0/3] rockchip: sdhci: Add HS400 Enhanced Strobe support
Date: Tue, 15 Mar 2022 20:46:25 +0300 [thread overview]
Message-ID: <20220315174629.7467-1-alpernebiyasak@gmail.com> (raw)
This series implements support for the HS400 Enhanced Strobe mode on the
Rockchip SDHCI driver, for both RK3399 and RK3568. To test, I'm building
for chromebook_kevin with the following configs enabled:
+CONFIG_MMC_SPEED_MODE_SET=y
[...]
CONFIG_MMC_PWRSEQ=y
+CONFIG_MMC_IO_VOLTAGE=y
+CONFIG_MMC_UHS_SUPPORT=y
+CONFIG_MMC_HS400_ES_SUPPORT=y
+CONFIG_MMC_HS400_SUPPORT=y
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_SDMA=y
CONFIG_MMC_SDHCI_ROCKCHIP=y
and running roughly:
$ mmc rescan [0|1|3|10|11|12]
$ mmc info
$ mmc part
$ load mmc 0:1 0xd0000000 256MiB.bin
$ load mmc 0:1 0xd0000000 16MiB.bin
$ load mmc 0:1 0xd0000000 8MiB.bin
Here's the differences in info and speeds I get with this:
Mode | Bus Speed | Bus Width
-----------------------+--------------+--------------
MMC Legacy | 25000000 | 8-bit
MMC High Speed (26MHz) | 26000000 | 8-bit
MMC High Speed (52MHz) | 52000000 | 8-bit
HS200 (200MHz) | 200000000 | 8-bit
HS400 (200MHz) | 200000000 | 8-bit DDR
HS400ES (200MHz) | 200000000 | 8-bit DDR
Mode | 256 MiB Load | 16 MiB Load | 8 MiB Load
-----------------------+--------------+--------------+--------------
MMC Legacy | ~22.1 MiB/s | ~21.9 MiB/s | ~21.6 MiB/s
MMC High Speed (26MHz) | ~22.1 MiB/s | ~21.9 MiB/s | ~21.6 MiB/s
MMC High Speed (52MHz) | ~43.7 MiB/s | ~42.8 MiB/s | ~41.7 MiB/s
HS200 (200MHz) | ~161.2 MiB/s | ~149.5 MiB/s | ~137.9 MiB/s
HS400 (200MHz) | ~254.5 MiB/s | ~235.3 MiB/s | ~216.2 MiB/s
HS400ES (200MHz) | ~254.7 MiB/s | ~238.8 MiB/s | ~216.2 MiB/s
Hope I haven't missed anything. Enabling the configs above for each
board is left to board maintainers as I can't test on those boards.
Changes in v5:
- Incorporate RK3568 HS400ES fixes from Yifeng Zhao:
- Use DWCMSHC_CTRL_HS400 = 0x7, instead of SDHCI_CTRL_HS400 = 0x5
- Configure DWCMSHC_CARD_IS_EMMC in rk3568_sdhci_set_ios_post()
- Configure DLL_STRBIN and DLL_TXCLK for HS400.
- Drop re-init fix already merged to master
v4: https://patchwork.ozlabs.org/project/uboot/list/?series=283482&state=*
Changes in v4:
- Add comment for SDHCI set_enhanced_strobe() operation
- Add comment for Rockchip SDHCI set_enhanced_strobe() driver data op
v3: https://patchwork.ozlabs.org/project/uboot/list/?series=281327&state=*
Changes in v3:
- Set DWCMSHC_CARD_IS_EMMC bit in rk3568_emmc_phy_init()
v2: https://patchwork.ozlabs.org/project/uboot/list/?series=280494&state=*
Changes in v2:
- Unset ES bit in rk3399 set_control_reg() to fix a reinit issue
- Don't use unnecessary & for function pointer in ops struct
- Rename rk3399_set_enhanced_strobe -> rk3399_sdhci_set_enhanced_strobe
- Rename rk3568_set_enhanced_strobe -> rk3568_sdhci_set_enhanced_strobe
- Let set_enhanced_strobe() unset the ES bit if mode is not HS400_ES
- Rewrote cover letter
v1: https://patchwork.ozlabs.org/project/uboot/list/?series=269768&state=*
Alper Nebi Yasak (3):
mmc: sdhci: Add HS400 Enhanced Strobe support
rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3399
rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3568
drivers/mmc/rockchip_sdhci.c | 117 +++++++++++++++++++++++++++++++++--
drivers/mmc/sdhci.c | 18 ++++++
include/sdhci.h | 12 ++++
3 files changed, 141 insertions(+), 6 deletions(-)
--
2.35.1
next reply other threads:[~2022-03-15 17:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220315174657epcas1p23089ad47a1f6fac2017f8ac2f4802765@epcas1p2.samsung.com>
2022-03-15 17:46 ` Alper Nebi Yasak [this message]
2022-03-15 17:46 ` [PATCH v5 1/3] mmc: sdhci: Add HS400 Enhanced Strobe support Alper Nebi Yasak
2022-03-16 1:26 ` Kever Yang
2022-03-15 17:46 ` [PATCH v5 2/3] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3399 Alper Nebi Yasak
2022-03-16 1:26 ` Kever Yang
2022-03-15 17:46 ` [PATCH v5 3/3] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3568 Alper Nebi Yasak
2022-03-16 1:12 ` zyf
2022-03-16 1:56 ` Kever Yang
2022-03-16 10:25 ` [PATCH v5 0/3] rockchip: sdhci: Add HS400 Enhanced Strobe support Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220315174629.7467-1-alpernebiyasak@gmail.com \
--to=alpernebiyasak@gmail.com \
--cc=a-govindraju@ti.com \
--cc=ashok.reddy.soma@xilinx.com \
--cc=faiz_abbas@ti.com \
--cc=jagan@amarulasolutions.com \
--cc=jh80.chung@samsung.com \
--cc=kever.yang@rock-chips.com \
--cc=michal.simek@xilinx.com \
--cc=ml@embed.me.uk \
--cc=pbrobinson@gmail.com \
--cc=peng.fan@nxp.com \
--cc=pgwipeout@gmail.com \
--cc=philipp.tomsich@vrull.eu \
--cc=samuel@dionne-riel.com \
--cc=sjg@chromium.org \
--cc=stcarlso@linux.microsoft.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.