All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mailbox: imx: Fix duplicate field initialization in imx
@ 2022-03-16  1:41 ` Wan Jiabing
  0 siblings, 0 replies; 6+ messages in thread
From: Wan Jiabing @ 2022-03-16  1:41 UTC (permalink / raw)
  To: Jassi Brar, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, NXP Linux Team, Peng Fan, linux-kernel,
	linux-arm-kernel
  Cc: kael_w, Wan Jiabing

Fix the following coccicheck warning:
./drivers/mailbox/imx-mailbox.c:884:51-52: rxdb: first occurrence line
887, second occurrence line 889

Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/mailbox/imx-mailbox.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
index e88f544a1548..df8a785be324 100644
--- a/drivers/mailbox/imx-mailbox.c
+++ b/drivers/mailbox/imx-mailbox.c
@@ -886,7 +886,6 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = {
 	.rx	= imx_mu_generic_rx,
 	.rxdb	= imx_mu_generic_rxdb,
 	.init	= imx_mu_init_generic,
-	.rxdb	= imx_mu_generic_rxdb,
 	.type	= IMX_MU_V2,
 	.xTR	= 0x200,
 	.xRR	= 0x280,
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] mailbox: imx: Fix duplicate field initialization in imx
@ 2022-03-16  1:41 ` Wan Jiabing
  0 siblings, 0 replies; 6+ messages in thread
From: Wan Jiabing @ 2022-03-16  1:41 UTC (permalink / raw)
  To: Jassi Brar, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, NXP Linux Team, Peng Fan, linux-kernel,
	linux-arm-kernel
  Cc: kael_w, Wan Jiabing

Fix the following coccicheck warning:
./drivers/mailbox/imx-mailbox.c:884:51-52: rxdb: first occurrence line
887, second occurrence line 889

Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/mailbox/imx-mailbox.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
index e88f544a1548..df8a785be324 100644
--- a/drivers/mailbox/imx-mailbox.c
+++ b/drivers/mailbox/imx-mailbox.c
@@ -886,7 +886,6 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = {
 	.rx	= imx_mu_generic_rx,
 	.rxdb	= imx_mu_generic_rxdb,
 	.init	= imx_mu_init_generic,
-	.rxdb	= imx_mu_generic_rxdb,
 	.type	= IMX_MU_V2,
 	.xTR	= 0x200,
 	.xRR	= 0x280,
-- 
2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* RE: [PATCH] mailbox: imx: Fix duplicate field initialization in imx
  2022-03-16  1:41 ` Wan Jiabing
@ 2022-03-16  2:03   ` Peng Fan
  -1 siblings, 0 replies; 6+ messages in thread
From: Peng Fan @ 2022-03-16  2:03 UTC (permalink / raw)
  To: Wan Jiabing, Jassi Brar, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, dl-linux-imx,
	linux-kernel, linux-arm-kernel
  Cc: kael_w

> Subject: [PATCH] mailbox: imx: Fix duplicate field initialization in imx
> 
> Fix the following coccicheck warning:
> ./drivers/mailbox/imx-mailbox.c:884:51-52: rxdb: first occurrence line 887,
> second occurrence line 889
> 
> Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback")
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  drivers/mailbox/imx-mailbox.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index e88f544a1548..df8a785be324 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -886,7 +886,6 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp
> = {
>  	.rx	= imx_mu_generic_rx,
>  	.rxdb	= imx_mu_generic_rxdb,
>  	.init	= imx_mu_init_generic,
> -	.rxdb	= imx_mu_generic_rxdb,
>  	.type	= IMX_MU_V2,
>  	.xTR	= 0x200,
>  	.xRR	= 0x280,
> --
> 2.35.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] mailbox: imx: Fix duplicate field initialization in imx
@ 2022-03-16  2:03   ` Peng Fan
  0 siblings, 0 replies; 6+ messages in thread
From: Peng Fan @ 2022-03-16  2:03 UTC (permalink / raw)
  To: Wan Jiabing, Jassi Brar, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, dl-linux-imx,
	linux-kernel, linux-arm-kernel
  Cc: kael_w

> Subject: [PATCH] mailbox: imx: Fix duplicate field initialization in imx
> 
> Fix the following coccicheck warning:
> ./drivers/mailbox/imx-mailbox.c:884:51-52: rxdb: first occurrence line 887,
> second occurrence line 889
> 
> Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback")
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  drivers/mailbox/imx-mailbox.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index e88f544a1548..df8a785be324 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -886,7 +886,6 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp
> = {
>  	.rx	= imx_mu_generic_rx,
>  	.rxdb	= imx_mu_generic_rxdb,
>  	.init	= imx_mu_init_generic,
> -	.rxdb	= imx_mu_generic_rxdb,
>  	.type	= IMX_MU_V2,
>  	.xTR	= 0x200,
>  	.xRR	= 0x280,
> --
> 2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] mailbox: imx: Fix duplicate field initialization in imx
  2022-03-16  2:03   ` Peng Fan
@ 2022-04-27  3:39     ` Wan Jiabing
  -1 siblings, 0 replies; 6+ messages in thread
From: Wan Jiabing @ 2022-04-27  3:39 UTC (permalink / raw)
  To: Peng Fan
  Cc: Jassi Brar, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, dl-linux-imx, linux-kernel, linux-arm-kernel,
	kael_w

On Wed, Mar 16, 2022 at 02:03:49AM +0000, Peng Fan wrote:
> > Subject: [PATCH] mailbox: imx: Fix duplicate field initialization in imx
> > 
> > Fix the following coccicheck warning:
> > ./drivers/mailbox/imx-mailbox.c:884:51-52: rxdb: first occurrence line 887,
> > second occurrence line 889
> > 
> > Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback")
> > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> 
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> 
> > ---
> >  drivers/mailbox/imx-mailbox.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> > index e88f544a1548..df8a785be324 100644
> > --- a/drivers/mailbox/imx-mailbox.c
> > +++ b/drivers/mailbox/imx-mailbox.c
> > @@ -886,7 +886,6 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp
> > = {
> >  	.rx	= imx_mu_generic_rx,
> >  	.rxdb	= imx_mu_generic_rxdb,
> >  	.init	= imx_mu_init_generic,
> > -	.rxdb	= imx_mu_generic_rxdb,
> >  	.type	= IMX_MU_V2,
> >  	.xTR	= 0x200,
> >  	.xRR	= 0x280,
> > --
> > 2.35.1
> 

Hi, all

I notice the status of this patch hasn't been updated for
a long time.

Could someone pick it up to avoid warning again?

[0] https://lore.kernel.org/all/20220403145304.685443-1-trix@redhat.com/

Thanks,
Wan Jiabing 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] mailbox: imx: Fix duplicate field initialization in imx
@ 2022-04-27  3:39     ` Wan Jiabing
  0 siblings, 0 replies; 6+ messages in thread
From: Wan Jiabing @ 2022-04-27  3:39 UTC (permalink / raw)
  To: Peng Fan
  Cc: Jassi Brar, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, dl-linux-imx, linux-kernel, linux-arm-kernel,
	kael_w

On Wed, Mar 16, 2022 at 02:03:49AM +0000, Peng Fan wrote:
> > Subject: [PATCH] mailbox: imx: Fix duplicate field initialization in imx
> > 
> > Fix the following coccicheck warning:
> > ./drivers/mailbox/imx-mailbox.c:884:51-52: rxdb: first occurrence line 887,
> > second occurrence line 889
> > 
> > Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback")
> > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> 
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> 
> > ---
> >  drivers/mailbox/imx-mailbox.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> > index e88f544a1548..df8a785be324 100644
> > --- a/drivers/mailbox/imx-mailbox.c
> > +++ b/drivers/mailbox/imx-mailbox.c
> > @@ -886,7 +886,6 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp
> > = {
> >  	.rx	= imx_mu_generic_rx,
> >  	.rxdb	= imx_mu_generic_rxdb,
> >  	.init	= imx_mu_init_generic,
> > -	.rxdb	= imx_mu_generic_rxdb,
> >  	.type	= IMX_MU_V2,
> >  	.xTR	= 0x200,
> >  	.xRR	= 0x280,
> > --
> > 2.35.1
> 

Hi, all

I notice the status of this patch hasn't been updated for
a long time.

Could someone pick it up to avoid warning again?

[0] https://lore.kernel.org/all/20220403145304.685443-1-trix@redhat.com/

Thanks,
Wan Jiabing 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-04-27  3:40 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16  1:41 [PATCH] mailbox: imx: Fix duplicate field initialization in imx Wan Jiabing
2022-03-16  1:41 ` Wan Jiabing
2022-03-16  2:03 ` Peng Fan
2022-03-16  2:03   ` Peng Fan
2022-04-27  3:39   ` Wan Jiabing
2022-04-27  3:39     ` Wan Jiabing

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.