* [PATCH] phy: ti: omap-usb2: Fix error handling in omap_usb2_enable_clocks
@ 2022-03-16 2:41 ` Miaoqian Lin
0 siblings, 0 replies; 8+ messages in thread
From: Miaoqian Lin @ 2022-03-16 2:41 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul, Liam Beguin, Miaoqian Lin,
Roger Quadros, linux-phy, linux-kernel
The corresponding API for clk_prepare_enable is clk_disable_unprepare,
other than clk_disable_unprepare.
Fix this by changing clk_disable to clk_disable_unprepare.
Fixes: ed31ee7cf1fe ("phy: ti: usb2: Fix logic on -EPROBE_DEFER")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/phy/ti/phy-omap-usb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/ti/phy-omap-usb2.c b/drivers/phy/ti/phy-omap-usb2.c
index 3a505fe5715a..31a775877f6e 100644
--- a/drivers/phy/ti/phy-omap-usb2.c
+++ b/drivers/phy/ti/phy-omap-usb2.c
@@ -215,7 +215,7 @@ static int omap_usb2_enable_clocks(struct omap_usb *phy)
return 0;
err1:
- clk_disable(phy->wkupclk);
+ clk_disable_unprepare(phy->wkupclk);
err0:
return ret;
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] phy: ti: omap-usb2: Fix error handling in omap_usb2_enable_clocks
@ 2022-03-16 2:41 ` Miaoqian Lin
0 siblings, 0 replies; 8+ messages in thread
From: Miaoqian Lin @ 2022-03-16 2:41 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul, Liam Beguin, Miaoqian Lin,
Roger Quadros, linux-phy, linux-kernel
The corresponding API for clk_prepare_enable is clk_disable_unprepare,
other than clk_disable_unprepare.
Fix this by changing clk_disable to clk_disable_unprepare.
Fixes: ed31ee7cf1fe ("phy: ti: usb2: Fix logic on -EPROBE_DEFER")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/phy/ti/phy-omap-usb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/ti/phy-omap-usb2.c b/drivers/phy/ti/phy-omap-usb2.c
index 3a505fe5715a..31a775877f6e 100644
--- a/drivers/phy/ti/phy-omap-usb2.c
+++ b/drivers/phy/ti/phy-omap-usb2.c
@@ -215,7 +215,7 @@ static int omap_usb2_enable_clocks(struct omap_usb *phy)
return 0;
err1:
- clk_disable(phy->wkupclk);
+ clk_disable_unprepare(phy->wkupclk);
err0:
return ret;
--
2.17.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] phy: ti: omap-usb2: Fix error handling in omap_usb2_enable_clocks
2022-03-16 2:41 ` Miaoqian Lin
@ 2022-03-16 15:31 ` Liam Beguin
-1 siblings, 0 replies; 8+ messages in thread
From: Liam Beguin @ 2022-03-16 15:31 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Kishon Vijay Abraham I, Vinod Koul, Roger Quadros, linux-phy,
linux-kernel
On Wed, Mar 16, 2022 at 02:41:53AM +0000, Miaoqian Lin wrote:
> The corresponding API for clk_prepare_enable is clk_disable_unprepare,
> other than clk_disable_unprepare.
>
> Fix this by changing clk_disable to clk_disable_unprepare.
There seems to be a typo in the first sentence of the commit message.
Maybe something like this would do:
The corresponding API for clk_prepare_enable is clk_disable_unprepare.
Make sure that the clock is unprepared on exit by changing clk_disable
to clk_disable_unprepare.
>
> Fixes: ed31ee7cf1fe ("phy: ti: usb2: Fix logic on -EPROBE_DEFER")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Other than that,
Reviewed-by: Liam Beguin <liambeguin@gmail.com>
> ---
> drivers/phy/ti/phy-omap-usb2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/ti/phy-omap-usb2.c b/drivers/phy/ti/phy-omap-usb2.c
> index 3a505fe5715a..31a775877f6e 100644
> --- a/drivers/phy/ti/phy-omap-usb2.c
> +++ b/drivers/phy/ti/phy-omap-usb2.c
> @@ -215,7 +215,7 @@ static int omap_usb2_enable_clocks(struct omap_usb *phy)
> return 0;
>
> err1:
> - clk_disable(phy->wkupclk);
> + clk_disable_unprepare(phy->wkupclk);
>
> err0:
> return ret;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] phy: ti: omap-usb2: Fix error handling in omap_usb2_enable_clocks
@ 2022-03-16 15:31 ` Liam Beguin
0 siblings, 0 replies; 8+ messages in thread
From: Liam Beguin @ 2022-03-16 15:31 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Kishon Vijay Abraham I, Vinod Koul, Roger Quadros, linux-phy,
linux-kernel
On Wed, Mar 16, 2022 at 02:41:53AM +0000, Miaoqian Lin wrote:
> The corresponding API for clk_prepare_enable is clk_disable_unprepare,
> other than clk_disable_unprepare.
>
> Fix this by changing clk_disable to clk_disable_unprepare.
There seems to be a typo in the first sentence of the commit message.
Maybe something like this would do:
The corresponding API for clk_prepare_enable is clk_disable_unprepare.
Make sure that the clock is unprepared on exit by changing clk_disable
to clk_disable_unprepare.
>
> Fixes: ed31ee7cf1fe ("phy: ti: usb2: Fix logic on -EPROBE_DEFER")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Other than that,
Reviewed-by: Liam Beguin <liambeguin@gmail.com>
> ---
> drivers/phy/ti/phy-omap-usb2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/ti/phy-omap-usb2.c b/drivers/phy/ti/phy-omap-usb2.c
> index 3a505fe5715a..31a775877f6e 100644
> --- a/drivers/phy/ti/phy-omap-usb2.c
> +++ b/drivers/phy/ti/phy-omap-usb2.c
> @@ -215,7 +215,7 @@ static int omap_usb2_enable_clocks(struct omap_usb *phy)
> return 0;
>
> err1:
> - clk_disable(phy->wkupclk);
> + clk_disable_unprepare(phy->wkupclk);
>
> err0:
> return ret;
> --
> 2.17.1
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2] phy: ti: omap-usb2: Fix error handling in omap_usb2_enable_clocks
2022-03-16 15:31 ` Liam Beguin
@ 2022-03-18 10:57 ` Miaoqian Lin
-1 siblings, 0 replies; 8+ messages in thread
From: Miaoqian Lin @ 2022-03-18 10:57 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul, Miaoqian Lin, Liam Beguin,
Roger Quadros, linux-phy, linux-kernel
The corresponding API for clk_prepare_enable is clk_disable_unprepare.
Make sure that the clock is unprepared on exit by changing clk_disable
to clk_disable_unprepare.
Fixes: ed31ee7cf1fe ("phy: ti: usb2: Fix logic on -EPROBE_DEFER")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
changes in v2:
- fix typo in commit message.
---
drivers/phy/ti/phy-omap-usb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/ti/phy-omap-usb2.c b/drivers/phy/ti/phy-omap-usb2.c
index 3a505fe5715a..31a775877f6e 100644
--- a/drivers/phy/ti/phy-omap-usb2.c
+++ b/drivers/phy/ti/phy-omap-usb2.c
@@ -215,7 +215,7 @@ static int omap_usb2_enable_clocks(struct omap_usb *phy)
return 0;
err1:
- clk_disable(phy->wkupclk);
+ clk_disable_unprepare(phy->wkupclk);
err0:
return ret;
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2] phy: ti: omap-usb2: Fix error handling in omap_usb2_enable_clocks
@ 2022-03-18 10:57 ` Miaoqian Lin
0 siblings, 0 replies; 8+ messages in thread
From: Miaoqian Lin @ 2022-03-18 10:57 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul, Miaoqian Lin, Liam Beguin,
Roger Quadros, linux-phy, linux-kernel
The corresponding API for clk_prepare_enable is clk_disable_unprepare.
Make sure that the clock is unprepared on exit by changing clk_disable
to clk_disable_unprepare.
Fixes: ed31ee7cf1fe ("phy: ti: usb2: Fix logic on -EPROBE_DEFER")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
changes in v2:
- fix typo in commit message.
---
drivers/phy/ti/phy-omap-usb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/ti/phy-omap-usb2.c b/drivers/phy/ti/phy-omap-usb2.c
index 3a505fe5715a..31a775877f6e 100644
--- a/drivers/phy/ti/phy-omap-usb2.c
+++ b/drivers/phy/ti/phy-omap-usb2.c
@@ -215,7 +215,7 @@ static int omap_usb2_enable_clocks(struct omap_usb *phy)
return 0;
err1:
- clk_disable(phy->wkupclk);
+ clk_disable_unprepare(phy->wkupclk);
err0:
return ret;
--
2.17.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2] phy: ti: omap-usb2: Fix error handling in omap_usb2_enable_clocks
2022-03-18 10:57 ` Miaoqian Lin
@ 2022-04-13 9:33 ` Vinod Koul
-1 siblings, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2022-04-13 9:33 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Kishon Vijay Abraham I, Liam Beguin, Roger Quadros, linux-phy,
linux-kernel
On 18-03-22, 10:57, Miaoqian Lin wrote:
> The corresponding API for clk_prepare_enable is clk_disable_unprepare.
> Make sure that the clock is unprepared on exit by changing clk_disable
> to clk_disable_unprepare.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-04-13 9:33 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 2:41 [PATCH] phy: ti: omap-usb2: Fix error handling in omap_usb2_enable_clocks Miaoqian Lin
2022-03-16 2:41 ` Miaoqian Lin
2022-03-16 15:31 ` Liam Beguin
2022-03-16 15:31 ` Liam Beguin
2022-03-18 10:57 ` [PATCH v2] " Miaoqian Lin
2022-03-18 10:57 ` Miaoqian Lin
2022-04-13 9:33 ` Vinod Koul
2022-04-13 9:33 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.