From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>,
netdev@vger.kernel.org,
syzbot+2339c27f5c66c652843e@syzkaller.appspotmail.com
Subject: Re: [net-next] can: isotp: sanitize CAN ID checks in isotp_bind()
Date: Wed, 16 Mar 2022 08:45:15 +0100 [thread overview]
Message-ID: <20220316074515.jchjdelc722dkug7@pengutronix.de> (raw)
In-Reply-To: <20220315185134.687fe506@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]
On 15.03.2022 18:51:34, Jakub Kicinski wrote:
> On Tue, 15 Mar 2022 21:37:48 +0100 Oliver Hartkopp wrote:
> > Syzbot created an environment that lead to a state machine status that
> > can not be reached with a compliant CAN ID address configuration.
> > The provided address information consisted of CAN ID 0x6000001 and 0xC28001
> > which both boil down to 11 bit CAN IDs 0x001 in sending and receiving.
> >
> > Sanitize the SFF/EFF CAN ID values before performing the address checks.
> >
> > Fixes: e057dd3fc20f ("can: add ISO 15765-2:2016 transport protocol")
> > Reported-by: syzbot+2339c27f5c66c652843e@syzkaller.appspotmail.com
> > Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
>
> CC Marc, please make sure you CC maintainers.
Thx. And make sure you have the linux-can ML on Cc :)
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-03-16 7:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 20:37 [net-next] can: isotp: sanitize CAN ID checks in isotp_bind() Oliver Hartkopp
2022-03-16 1:51 ` Jakub Kicinski
2022-03-16 7:35 ` Oliver Hartkopp
2022-03-16 7:48 ` Marc Kleine-Budde
2022-03-16 7:53 ` Oliver Hartkopp
2022-03-16 8:01 ` Marc Kleine-Budde
2022-03-16 8:42 ` Oliver Hartkopp
2022-03-16 16:49 ` Oliver Hartkopp
2022-03-16 20:51 ` Marc Kleine-Budde
2022-03-16 18:33 ` Jakub Kicinski
2022-03-16 18:29 ` Jakub Kicinski
2022-03-16 7:45 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220316074515.jchjdelc722dkug7@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=syzbot+2339c27f5c66c652843e@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.