All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
	netdev@vger.kernel.org,
	syzbot+2339c27f5c66c652843e@syzkaller.appspotmail.com
Subject: Re: [net-next] can: isotp: sanitize CAN ID checks in isotp_bind()
Date: Wed, 16 Mar 2022 11:29:43 -0700	[thread overview]
Message-ID: <20220316112943.266df1d1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <3922032f-c829-b609-e408-6dec83a0041a@hartkopp.net>

On Wed, 16 Mar 2022 08:35:58 +0100 Oliver Hartkopp wrote:
> On 16.03.22 02:51, Jakub Kicinski wrote:
> > On Tue, 15 Mar 2022 21:37:48 +0100 Oliver Hartkopp wrote:  
> >> Syzbot created an environment that lead to a state machine status that
> >> can not be reached with a compliant CAN ID address configuration.
> >> The provided address information consisted of CAN ID 0x6000001 and 0xC28001
> >> which both boil down to 11 bit CAN IDs 0x001 in sending and receiving.
> >>
> >> Sanitize the SFF/EFF CAN ID values before performing the address checks.
> >>
> >> Fixes: e057dd3fc20f ("can: add ISO 15765-2:2016 transport protocol")
> >> Reported-by: syzbot+2339c27f5c66c652843e@syzkaller.appspotmail.com
> >> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>  
> > 
> > CC Marc, please make sure you CC maintainers.  
> 
> Oh, that would have been better! I'm maintaining the CAN network layer 
> stuff together with Marc and there was no relevant stuff in can-next to 
> be pulled in the next days. So I sent it directly to hit the merge 
> window and had all of us in the reply to the syzbot report.
> 
> Will CC Marc next time when posting to netdev only!
> 
> Maybe I treated this patch more urgent than it needed to be handled 
> ¯\_(ツ)_/¯

Heh, I did think to myself "why is Oliver sending this directly" 
but wasn't confident enough to conclude that it's intentional :)
Feel free to add any random info / context under the --- marker
in a patch.

  parent reply	other threads:[~2022-03-16 18:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15 20:37 [net-next] can: isotp: sanitize CAN ID checks in isotp_bind() Oliver Hartkopp
2022-03-16  1:51 ` Jakub Kicinski
2022-03-16  7:35   ` Oliver Hartkopp
2022-03-16  7:48     ` Marc Kleine-Budde
2022-03-16  7:53       ` Oliver Hartkopp
2022-03-16  8:01         ` Marc Kleine-Budde
2022-03-16  8:42           ` Oliver Hartkopp
2022-03-16 16:49             ` Oliver Hartkopp
2022-03-16 20:51               ` Marc Kleine-Budde
2022-03-16 18:33             ` Jakub Kicinski
2022-03-16 18:29     ` Jakub Kicinski [this message]
2022-03-16  7:45   ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220316112943.266df1d1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    --cc=syzbot+2339c27f5c66c652843e@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.