From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jiri@nvidia.com,
idosch@nvidia.com, petrm@nvidia.com, simon.horman@corigine.com,
louis.peens@corigine.com
Subject: Re: [PATCH net-next 1/6] devlink: expose instance locking and add locked port registering
Date: Wed, 16 Mar 2022 09:48:59 -0700 [thread overview]
Message-ID: <20220316094859.2128c430@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <YjGf3OqijAiqSNE/@unreal>
On Wed, 16 Mar 2022 10:29:16 +0200 Leon Romanovsky wrote:
> Sorry that I'm asking you again same question.
> How will this devl_lock_is_held() be used in drivers?
>
> Right now, if I decide to use this function in mlx5 (or in any other driver),
> the code will be something like this:
>
> void func(...)
> {
> ....
> if (IS_ENABLED(CONFIG_LOCKDEP))
> if (rcu_dereference_protected(a, devl_lock_is_held(devlink) == b) {
> ....
> }
>
> The line "if (IS_ENABLED(CONFIG_LOCKDEP))" needs to be in every driver
> or it won't compile in release mode.
It follows the semantics of lockdep_is_held(), note that
rcu_dereference_protected() makes the last parameter dead
code with LOCKDEP=n
#define RCU_LOCKDEP_WARN(c, s) do { } while (0 && (c))
where (c) would be devl_lock_is_held()
so the call to devl_lock_is_held() is eliminated, and we
won't get a linker error. There's no need for IS_ENABLED().
next prev parent reply other threads:[~2022-03-16 16:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 6:00 [PATCH net-next 0/6] devlink: expose instance locking and simplify port splitting Jakub Kicinski
2022-03-15 6:00 ` [PATCH net-next 1/6] devlink: expose instance locking and add locked port registering Jakub Kicinski
2022-03-16 8:29 ` Leon Romanovsky
2022-03-16 16:48 ` Jakub Kicinski [this message]
2022-03-16 18:39 ` Leon Romanovsky
2022-03-16 18:39 ` Leon Romanovsky
2022-03-15 6:00 ` [PATCH net-next 2/6] eth: nfp: wrap locking assertions in helpers Jakub Kicinski
2022-03-15 6:00 ` [PATCH net-next 3/6] eth: nfp: replace driver's "pf" lock with devlink instance lock Jakub Kicinski
2022-03-16 8:34 ` Leon Romanovsky
2022-03-16 16:45 ` Jakub Kicinski
2022-03-15 6:00 ` [PATCH net-next 4/6] eth: mlxsw: switch to explicit locking for port registration Jakub Kicinski
2022-03-15 8:29 ` Ido Schimmel
2022-03-15 6:00 ` [PATCH net-next 5/6] devlink: hold the instance lock in port_split / port_unsplit callbacks Jakub Kicinski
2022-03-15 8:30 ` Ido Schimmel
2022-03-15 6:00 ` [PATCH net-next 6/6] devlink: pass devlink_port to " Jakub Kicinski
2022-03-15 8:32 ` Ido Schimmel
2022-03-16 20:07 ` [PATCH net-next 0/6] devlink: expose instance locking and simplify port splitting Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220316094859.2128c430@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=leon@kernel.org \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.