All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jiri@nvidia.com,
	idosch@nvidia.com, petrm@nvidia.com, simon.horman@corigine.com,
	louis.peens@corigine.com
Subject: Re: [PATCH net-next 3/6] eth: nfp: replace driver's "pf" lock with devlink instance lock
Date: Wed, 16 Mar 2022 10:34:31 +0200	[thread overview]
Message-ID: <YjGhF2AYAq/XNh+F@unreal> (raw)
In-Reply-To: <20220315060009.1028519-4-kuba@kernel.org>

On Mon, Mar 14, 2022 at 11:00:06PM -0700, Jakub Kicinski wrote:
> The whole reason for existence of the pf mutex is that we could
> not lock the devlink instance around port splitting. There are
> more types of reconfig which can make ports appear or disappear.
> Now that the devlink instance lock is exposed to drivers and
> "locked" helpers exist we can switch to using the devlink lock
> directly.
> 
> Next patches will move the locking inside .port_(un)split to
> the core.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  drivers/net/ethernet/netronome/nfp/nfp_app.h  | 11 +++---
>  .../net/ethernet/netronome/nfp/nfp_devlink.c  | 16 ++++-----
>  drivers/net/ethernet/netronome/nfp/nfp_main.c | 19 ++++++-----
>  drivers/net/ethernet/netronome/nfp/nfp_main.h |  6 ++--
>  .../net/ethernet/netronome/nfp/nfp_net_main.c | 34 +++++++++++--------
>  drivers/net/ethernet/netronome/nfp/nfp_port.c |  3 +-
>  6 files changed, 48 insertions(+), 41 deletions(-)

<...>

> -#define nfp_app_is_locked(app)	lockdep_is_held(&(app)->pf->lock)
> +static inline bool nfp_app_is_locked(struct nfp_app *app)
> +{
> +	return devl_lock_is_held(priv_to_devlink(app->pf));
> +}

Does it compile if you set CONFIG_LOCKDEP=n?

Thanks

  reply	other threads:[~2022-03-16  8:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15  6:00 [PATCH net-next 0/6] devlink: expose instance locking and simplify port splitting Jakub Kicinski
2022-03-15  6:00 ` [PATCH net-next 1/6] devlink: expose instance locking and add locked port registering Jakub Kicinski
2022-03-16  8:29   ` Leon Romanovsky
2022-03-16 16:48     ` Jakub Kicinski
2022-03-16 18:39       ` Leon Romanovsky
2022-03-16 18:39   ` Leon Romanovsky
2022-03-15  6:00 ` [PATCH net-next 2/6] eth: nfp: wrap locking assertions in helpers Jakub Kicinski
2022-03-15  6:00 ` [PATCH net-next 3/6] eth: nfp: replace driver's "pf" lock with devlink instance lock Jakub Kicinski
2022-03-16  8:34   ` Leon Romanovsky [this message]
2022-03-16 16:45     ` Jakub Kicinski
2022-03-15  6:00 ` [PATCH net-next 4/6] eth: mlxsw: switch to explicit locking for port registration Jakub Kicinski
2022-03-15  8:29   ` Ido Schimmel
2022-03-15  6:00 ` [PATCH net-next 5/6] devlink: hold the instance lock in port_split / port_unsplit callbacks Jakub Kicinski
2022-03-15  8:30   ` Ido Schimmel
2022-03-15  6:00 ` [PATCH net-next 6/6] devlink: pass devlink_port to " Jakub Kicinski
2022-03-15  8:32   ` Ido Schimmel
2022-03-16 20:07 ` [PATCH net-next 0/6] devlink: expose instance locking and simplify port splitting Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YjGhF2AYAq/XNh+F@unreal \
    --to=leon@kernel.org \
    --cc=davem@davemloft.net \
    --cc=idosch@nvidia.com \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=louis.peens@corigine.com \
    --cc=netdev@vger.kernel.org \
    --cc=petrm@nvidia.com \
    --cc=simon.horman@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.