All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] block: Add parameter description in kernel-doc comment
@ 2022-03-16 12:53 ` Yang Li
  0 siblings, 0 replies; 2+ messages in thread
From: Yang Li @ 2022-03-16 12:53 UTC (permalink / raw)
  To: paolo.valente
  Cc: tj, axboe, cgroups, linux-block, linux-kernel, Yang Li, Abaci Robot

Add the description of @ioprio_class in bfq_reparent_leaf_entity()
and bfq_reparent_active_queues() kernel-doc comment to remove
warning found by running scripts/kernel-doc, which is caused by
using 'make W=1'.

block/bfq-cgroup.c:848: warning: Function parameter or member
'ioprio_class' not described in 'bfq_reparent_leaf_entity'
block/bfq-cgroup.c:878: warning: Function parameter or member
'ioprio_class' not described in 'bfq_reparent_active_queues'

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 block/bfq-cgroup.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
index 420eda2589c0..af92c2e5fd98 100644
--- a/block/bfq-cgroup.c
+++ b/block/bfq-cgroup.c
@@ -841,6 +841,7 @@ static void bfq_flush_idle_tree(struct bfq_service_tree *st)
  * @bfqd: the device data structure with the root group.
  * @entity: the entity to move, if entity is a leaf; or the parent entity
  *	    of an active leaf entity to move, if entity is not a leaf.
+ * @ioprio_class: the offset used to manipulate the service_tree
  */
 static void bfq_reparent_leaf_entity(struct bfq_data *bfqd,
 				     struct bfq_entity *entity,
@@ -870,6 +871,7 @@ static void bfq_reparent_leaf_entity(struct bfq_data *bfqd,
  * @bfqd: the device data structure with the root group.
  * @bfqg: the group to move from.
  * @st: the service tree to start the search from.
+ * @ioprio_class: the offset used to manipulate the service_tree
  */
 static void bfq_reparent_active_queues(struct bfq_data *bfqd,
 				       struct bfq_group *bfqg,
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH -next] block: Add parameter description in kernel-doc comment
@ 2022-03-16 12:53 ` Yang Li
  0 siblings, 0 replies; 2+ messages in thread
From: Yang Li @ 2022-03-16 12:53 UTC (permalink / raw)
  To: paolo.valente-QSEj5FYQhm4dnm+yROfE0A
  Cc: tj-DgEjT+Ai2ygdnm+yROfE0A, axboe-tSWWG44O7X1aa/9Udqfwiw,
	cgroups-u79uwXL29TY76Z2rM5mHXA,
	linux-block-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Yang Li, Abaci Robot

Add the description of @ioprio_class in bfq_reparent_leaf_entity()
and bfq_reparent_active_queues() kernel-doc comment to remove
warning found by running scripts/kernel-doc, which is caused by
using 'make W=1'.

block/bfq-cgroup.c:848: warning: Function parameter or member
'ioprio_class' not described in 'bfq_reparent_leaf_entity'
block/bfq-cgroup.c:878: warning: Function parameter or member
'ioprio_class' not described in 'bfq_reparent_active_queues'

Reported-by: Abaci Robot <abaci-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
Signed-off-by: Yang Li <yang.lee-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
---
 block/bfq-cgroup.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
index 420eda2589c0..af92c2e5fd98 100644
--- a/block/bfq-cgroup.c
+++ b/block/bfq-cgroup.c
@@ -841,6 +841,7 @@ static void bfq_flush_idle_tree(struct bfq_service_tree *st)
  * @bfqd: the device data structure with the root group.
  * @entity: the entity to move, if entity is a leaf; or the parent entity
  *	    of an active leaf entity to move, if entity is not a leaf.
+ * @ioprio_class: the offset used to manipulate the service_tree
  */
 static void bfq_reparent_leaf_entity(struct bfq_data *bfqd,
 				     struct bfq_entity *entity,
@@ -870,6 +871,7 @@ static void bfq_reparent_leaf_entity(struct bfq_data *bfqd,
  * @bfqd: the device data structure with the root group.
  * @bfqg: the group to move from.
  * @st: the service tree to start the search from.
+ * @ioprio_class: the offset used to manipulate the service_tree
  */
 static void bfq_reparent_active_queues(struct bfq_data *bfqd,
 				       struct bfq_group *bfqg,
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-16 12:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 12:53 [PATCH -next] block: Add parameter description in kernel-doc comment Yang Li
2022-03-16 12:53 ` Yang Li

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.