* [PATCH net-next] ptp: ocp: Make debugfs variables the correct bitwidth
@ 2022-03-16 16:53 Jonathan Lemon
2022-03-18 1:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Lemon @ 2022-03-16 16:53 UTC (permalink / raw)
To: kuba, davem, richardcochran, dan.carpenter; +Cc: netdev, kernel-team
An earlier patch mistakenly changed these variables from u32 to u16,
leading to unintended truncation. Restore the original logic.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
---
drivers/ptp/ptp_ocp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
index d8cefc89a588..d64a1ce5f5bc 100644
--- a/drivers/ptp/ptp_ocp.c
+++ b/drivers/ptp/ptp_ocp.c
@@ -2983,11 +2983,12 @@ ptp_ocp_summary_show(struct seq_file *s, void *data)
{
struct device *dev = s->private;
struct ptp_system_timestamp sts;
- u16 sma_val[4][2], ctrl, val;
struct ts_reg __iomem *ts_reg;
struct timespec64 ts;
struct ptp_ocp *bp;
+ u16 sma_val[4][2];
char *src, *buf;
+ u32 ctrl, val;
bool on, map;
int i;
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ptp: ocp: Make debugfs variables the correct bitwidth
2022-03-16 16:53 [PATCH net-next] ptp: ocp: Make debugfs variables the correct bitwidth Jonathan Lemon
@ 2022-03-18 1:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-18 1:00 UTC (permalink / raw)
To: Jonathan Lemon
Cc: kuba, davem, richardcochran, dan.carpenter, netdev, kernel-team
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 16 Mar 2022 09:53:47 -0700 you wrote:
> An earlier patch mistakenly changed these variables from u32 to u16,
> leading to unintended truncation. Restore the original logic.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> ---
> drivers/ptp/ptp_ocp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Here is the summary with links:
- [net-next] ptp: ocp: Make debugfs variables the correct bitwidth
https://git.kernel.org/netdev/net-next/c/2b341f7532d4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-18 1:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 16:53 [PATCH net-next] ptp: ocp: Make debugfs variables the correct bitwidth Jonathan Lemon
2022-03-18 1:00 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.