* [Buildroot] [PATCH v1] package/qt5base: fix eglconvenience compile (missing QList include)
@ 2022-03-16 18:24 Peter Seiderer
2022-03-24 21:43 ` Arnout Vandecappelle
2022-03-30 7:13 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Peter Seiderer @ 2022-03-16 18:24 UTC (permalink / raw)
To: buildroot; +Cc: Julien Corjon
- add 0008-eglconvenience-add-missing-QList-include.patch to fix
eglconvenience compile (missing QList include)
Fixes:
qeglconvenience.cpp:418:23: error: variable ‘QList<QByteArray> extensions’ has initializer but incomplete type
418 | QList<QByteArray> extensions =
| ^~~~~~~~~~
qeglconvenience.cpp:420:65: error: invalid use of incomplete type ‘class QList<QByteArray>’
420 | (eglQueryString(display, EGL_EXTENSIONS))).split(' ');
| ^
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
...onvenience-add-missing-QList-include.patch | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch
diff --git a/package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch b/package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch
new file mode 100644
index 0000000000..c7127291e4
--- /dev/null
+++ b/package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch
@@ -0,0 +1,37 @@
+From f681f428477812e54484f631b0da332cc2e00eaa Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <ps.report@gmx.net>
+Date: Wed, 16 Mar 2022 19:08:55 +0100
+Subject: [PATCH] eglconvenience: add missing QList include
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Fixes:
+
+ qeglconvenience.cpp:418:23: error: variable ‘QList<QByteArray> extensions’ has initializer but incomplete type
+ 418 | QList<QByteArray> extensions =
+ | ^~~~~~~~~~
+ qeglconvenience.cpp:420:65: error: invalid use of incomplete type ‘class QList<QByteArray>’
+ 420 | (eglQueryString(display, EGL_EXTENSIONS))).split(' ');
+ | ^
+
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+---
+ src/platformsupport/eglconvenience/qeglconvenience.cpp | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/platformsupport/eglconvenience/qeglconvenience.cpp b/src/platformsupport/eglconvenience/qeglconvenience.cpp
+index 5303d37c..daceeb8b 100644
+--- a/src/platformsupport/eglconvenience/qeglconvenience.cpp
++++ b/src/platformsupport/eglconvenience/qeglconvenience.cpp
+@@ -38,6 +38,7 @@
+ ****************************************************************************/
+
+ #include <QByteArray>
++#include <QList>
+ #include <QOpenGLContext>
+
+ #ifdef Q_OS_LINUX
+--
+2.35.1
+
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v1] package/qt5base: fix eglconvenience compile (missing QList include)
2022-03-16 18:24 [Buildroot] [PATCH v1] package/qt5base: fix eglconvenience compile (missing QList include) Peter Seiderer
@ 2022-03-24 21:43 ` Arnout Vandecappelle
2022-03-30 7:13 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2022-03-24 21:43 UTC (permalink / raw)
To: Peter Seiderer, buildroot; +Cc: Julien Corjon
On 16/03/2022 19:24, Peter Seiderer wrote:
> - add 0008-eglconvenience-add-missing-QList-include.patch to fix
> eglconvenience compile (missing QList include)
>
> Fixes:
>
> qeglconvenience.cpp:418:23: error: variable ‘QList<QByteArray> extensions’ has initializer but incomplete type
> 418 | QList<QByteArray> extensions =
> | ^~~~~~~~~~
> qeglconvenience.cpp:420:65: error: invalid use of incomplete type ‘class QList<QByteArray>’
> 420 | (eglQueryString(display, EGL_EXTENSIONS))).split(' ');
> | ^
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> ...onvenience-add-missing-QList-include.patch | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch
>
> diff --git a/package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch b/package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch
> new file mode 100644
> index 0000000000..c7127291e4
> --- /dev/null
> +++ b/package/qt5/qt5base/0008-eglconvenience-add-missing-QList-include.patch
There was already a patch 0008. However, I merged another commit that removed
patch 0006, and renumbered them, so no your patch is 0008 :-)
Applied to master, thanks.
Regards,
Arnout
> @@ -0,0 +1,37 @@
> +From f681f428477812e54484f631b0da332cc2e00eaa Mon Sep 17 00:00:00 2001
> +From: Peter Seiderer <ps.report@gmx.net>
> +Date: Wed, 16 Mar 2022 19:08:55 +0100
> +Subject: [PATCH] eglconvenience: add missing QList include
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +Fixes:
> +
> + qeglconvenience.cpp:418:23: error: variable ‘QList<QByteArray> extensions’ has initializer but incomplete type
> + 418 | QList<QByteArray> extensions =
> + | ^~~~~~~~~~
> + qeglconvenience.cpp:420:65: error: invalid use of incomplete type ‘class QList<QByteArray>’
> + 420 | (eglQueryString(display, EGL_EXTENSIONS))).split(' ');
> + | ^
> +
> +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> +---
> + src/platformsupport/eglconvenience/qeglconvenience.cpp | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/src/platformsupport/eglconvenience/qeglconvenience.cpp b/src/platformsupport/eglconvenience/qeglconvenience.cpp
> +index 5303d37c..daceeb8b 100644
> +--- a/src/platformsupport/eglconvenience/qeglconvenience.cpp
> ++++ b/src/platformsupport/eglconvenience/qeglconvenience.cpp
> +@@ -38,6 +38,7 @@
> + ****************************************************************************/
> +
> + #include <QByteArray>
> ++#include <QList>
> + #include <QOpenGLContext>
> +
> + #ifdef Q_OS_LINUX
> +--
> +2.35.1
> +
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v1] package/qt5base: fix eglconvenience compile (missing QList include)
2022-03-16 18:24 [Buildroot] [PATCH v1] package/qt5base: fix eglconvenience compile (missing QList include) Peter Seiderer
2022-03-24 21:43 ` Arnout Vandecappelle
@ 2022-03-30 7:13 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-03-30 7:13 UTC (permalink / raw)
To: Peter Seiderer; +Cc: Julien Corjon, buildroot
>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:
> - add 0008-eglconvenience-add-missing-QList-include.patch to fix
> eglconvenience compile (missing QList include)
> Fixes:
> qeglconvenience.cpp:418:23: error: variable ‘QList<QByteArray> extensions’ has initializer but incomplete type
> 418 | QList<QByteArray> extensions =
> | ^~~~~~~~~~
> qeglconvenience.cpp:420:65: error: invalid use of incomplete type ‘class QList<QByteArray>’
> 420 | (eglQueryString(display, EGL_EXTENSIONS))).split(' ');
> | ^
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-30 7:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 18:24 [Buildroot] [PATCH v1] package/qt5base: fix eglconvenience compile (missing QList include) Peter Seiderer
2022-03-24 21:43 ` Arnout Vandecappelle
2022-03-30 7:13 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.