* [PATCH] drm/ttm: fix uninit ptr deref in range manager alloc error path
@ 2022-03-16 19:50 Robert Beckett
2022-03-17 7:09 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Robert Beckett @ 2022-03-16 19:50 UTC (permalink / raw)
To: dri-devel, Christian Koenig, Huang Rui, David Airlie, Daniel Vetter
Cc: Robert Beckett, Daniel Vetter, linux-kernel
ttm_range_man_alloc would try to ttm_resource_fini the res pointer
before it is allocated.
Fixes: de3688e469b0 (drm/ttm: add ttm_resource_fini v2)
Signed-off-by: Robert Beckett <bob.beckett@collabora.com>
---
drivers/gpu/drm/ttm/ttm_range_manager.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ttm/ttm_range_manager.c b/drivers/gpu/drm/ttm/ttm_range_manager.c
index 5662627bb933..1b4d8ca52f68 100644
--- a/drivers/gpu/drm/ttm/ttm_range_manager.c
+++ b/drivers/gpu/drm/ttm/ttm_range_manager.c
@@ -89,7 +89,7 @@ static int ttm_range_man_alloc(struct ttm_resource_manager *man,
spin_unlock(&rman->lock);
if (unlikely(ret)) {
- ttm_resource_fini(man, *res);
+ ttm_resource_fini(man, &node->base);
kfree(node);
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/ttm: fix uninit ptr deref in range manager alloc error path
2022-03-16 19:50 [PATCH] drm/ttm: fix uninit ptr deref in range manager alloc error path Robert Beckett
@ 2022-03-17 7:09 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2022-03-17 7:09 UTC (permalink / raw)
To: Robert Beckett, dri-devel, Huang Rui, David Airlie, Daniel Vetter
Cc: Daniel Vetter, linux-kernel
Am 16.03.22 um 20:50 schrieb Robert Beckett:
> ttm_range_man_alloc would try to ttm_resource_fini the res pointer
> before it is allocated.
>
> Fixes: de3688e469b0 (drm/ttm: add ttm_resource_fini v2)
>
> Signed-off-by: Robert Beckett <bob.beckett@collabora.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Good catch, going to push that to drm-misc-fixes.
> ---
> drivers/gpu/drm/ttm/ttm_range_manager.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_range_manager.c b/drivers/gpu/drm/ttm/ttm_range_manager.c
> index 5662627bb933..1b4d8ca52f68 100644
> --- a/drivers/gpu/drm/ttm/ttm_range_manager.c
> +++ b/drivers/gpu/drm/ttm/ttm_range_manager.c
> @@ -89,7 +89,7 @@ static int ttm_range_man_alloc(struct ttm_resource_manager *man,
> spin_unlock(&rman->lock);
>
> if (unlikely(ret)) {
> - ttm_resource_fini(man, *res);
> + ttm_resource_fini(man, &node->base);
> kfree(node);
> return ret;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-17 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 19:50 [PATCH] drm/ttm: fix uninit ptr deref in range manager alloc error path Robert Beckett
2022-03-17 7:09 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.