All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] media: bdisp: remove unnecessary IS_ERR() check
@ 2022-03-17  7:51 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2022-03-17  7:51 UTC (permalink / raw)
  To: Fabien Dessenne
  Cc: Mauro Carvalho Chehab, Maxime Coquelin, Alexandre Torgue,
	linux-media, kernel-janitors

The "bdisp->clock" variable cannot be an error pointer here.  No need to
check.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/media/platform/stm/sti/bdisp/bdisp-v4l2.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/platform/stm/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/stm/sti/bdisp/bdisp-v4l2.c
index 5aa79d9277c8..dd74cc43920d 100644
--- a/drivers/media/platform/stm/sti/bdisp/bdisp-v4l2.c
+++ b/drivers/media/platform/stm/sti/bdisp/bdisp-v4l2.c
@@ -1394,8 +1394,7 @@ static int bdisp_probe(struct platform_device *pdev)
 	bdisp_debugfs_remove(bdisp);
 	v4l2_device_unregister(&bdisp->v4l2_dev);
 err_clk:
-	if (!IS_ERR(bdisp->clock))
-		clk_unprepare(bdisp->clock);
+	clk_unprepare(bdisp->clock);
 err_wq:
 	destroy_workqueue(bdisp->work_queue);
 	return ret;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-03-17  7:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-17  7:51 [PATCH] media: bdisp: remove unnecessary IS_ERR() check Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.