* [PATCH net-next] ptp: ocp: fix sprintf overflow in ptp_ocp_verify()
@ 2022-03-17 7:59 Dan Carpenter
2022-03-17 17:04 ` Jonathan Lemon
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2022-03-17 7:59 UTC (permalink / raw)
To: Richard Cochran, Jonathan Lemon
Cc: Richard Cochran, David S. Miller, netdev, kernel-janitors
The "chan" value comes from the user via sysfs. A large like UINT_MAX
could overflow the buffer by three bytes. Make the buffer larger and
use snprintf() instead of sprintf().
Fixes: 1aa66a3a135a ("ptp: ocp: Program the signal generators via PTP_CLK_REQ_PEROUT")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/ptp/ptp_ocp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
index 56b04a7bba3a..f0565c4a85df 100644
--- a/drivers/ptp/ptp_ocp.c
+++ b/drivers/ptp/ptp_ocp.c
@@ -968,15 +968,15 @@ ptp_ocp_verify(struct ptp_clock_info *ptp_info, unsigned pin,
enum ptp_pin_function func, unsigned chan)
{
struct ptp_ocp *bp = container_of(ptp_info, struct ptp_ocp, ptp_info);
- char buf[16];
+ char buf[20];
if (func != PTP_PF_PEROUT)
return -EOPNOTSUPP;
if (chan)
- sprintf(buf, "OUT: GEN%d", chan);
+ snprintf(buf, sizeof(buf), "OUT: GEN%d", chan);
else
- sprintf(buf, "OUT: PHC");
+ snprintf(buf, sizeof(buf), "OUT: PHC");
return ptp_ocp_sma_store(bp, buf, pin + 1);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ptp: ocp: fix sprintf overflow in ptp_ocp_verify()
2022-03-17 7:59 [PATCH net-next] ptp: ocp: fix sprintf overflow in ptp_ocp_verify() Dan Carpenter
@ 2022-03-17 17:04 ` Jonathan Lemon
2022-03-18 7:45 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Lemon @ 2022-03-17 17:04 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Richard Cochran, David S. Miller, netdev, kernel-janitors
On Thu, Mar 17, 2022 at 10:59:57AM +0300, Dan Carpenter wrote:
> The "chan" value comes from the user via sysfs. A large like UINT_MAX
> could overflow the buffer by three bytes. Make the buffer larger and
> use snprintf() instead of sprintf().
>
> Fixes: 1aa66a3a135a ("ptp: ocp: Program the signal generators via PTP_CLK_REQ_PEROUT")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
This needs to be respun to catch up with the last patch.
--
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ptp: ocp: fix sprintf overflow in ptp_ocp_verify()
2022-03-17 17:04 ` Jonathan Lemon
@ 2022-03-18 7:45 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-03-18 7:45 UTC (permalink / raw)
To: Jonathan Lemon; +Cc: Richard Cochran, David S. Miller, netdev, kernel-janitors
On Thu, Mar 17, 2022 at 10:04:49AM -0700, Jonathan Lemon wrote:
> On Thu, Mar 17, 2022 at 10:59:57AM +0300, Dan Carpenter wrote:
> > The "chan" value comes from the user via sysfs. A large like UINT_MAX
> > could overflow the buffer by three bytes. Make the buffer larger and
> > use snprintf() instead of sprintf().
> >
> > Fixes: 1aa66a3a135a ("ptp: ocp: Program the signal generators via PTP_CLK_REQ_PEROUT")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> This needs to be respun to catch up with the last patch.
Thanks. It turns out you can't actually trigger this bug. Still using
snprintf() is better so I will resend.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-18 7:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-17 7:59 [PATCH net-next] ptp: ocp: fix sprintf overflow in ptp_ocp_verify() Dan Carpenter
2022-03-17 17:04 ` Jonathan Lemon
2022-03-18 7:45 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.