* [PATCH] MIPS: ingenic: correct unit node address
@ 2022-03-17 11:52 Krzysztof Kozlowski
2022-03-17 14:53 ` Paul Cercueil
2022-03-18 8:42 ` Thomas Bogendoerfer
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-17 11:52 UTC (permalink / raw)
To: Paul Cercueil, Rob Herring, Krzysztof Kozlowski,
Thomas Bogendoerfer, linux-mips, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Unit node addresses should not have leading 0x:
Warning (unit_address_format): /nemc@13410000/efuse@d0/eth-mac-addr@0x22: unit name should not have leading "0x"
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi
index 3f9ea47a10cd..b998301f179c 100644
--- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
+++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
@@ -510,7 +510,7 @@ efuse: efuse@d0 {
#address-cells = <1>;
#size-cells = <1>;
- eth0_addr: eth-mac-addr@0x22 {
+ eth0_addr: eth-mac-addr@22 {
reg = <0x22 0x6>;
};
};
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: ingenic: correct unit node address
2022-03-17 11:52 [PATCH] MIPS: ingenic: correct unit node address Krzysztof Kozlowski
@ 2022-03-17 14:53 ` Paul Cercueil
2022-03-18 8:42 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Paul Cercueil @ 2022-03-17 14:53 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Thomas Bogendoerfer,
linux-mips, devicetree, linux-kernel
Hi,
Le jeu., mars 17 2022 at 12:52:59 +0100, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> a écrit :
> Unit node addresses should not have leading 0x:
>
> Warning (unit_address_format):
> /nemc@13410000/efuse@d0/eth-mac-addr@0x22: unit name should not have
> leading "0x"
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
Cheers,
-Paul
> ---
> arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> index 3f9ea47a10cd..b998301f179c 100644
> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> @@ -510,7 +510,7 @@ efuse: efuse@d0 {
> #address-cells = <1>;
> #size-cells = <1>;
>
> - eth0_addr: eth-mac-addr@0x22 {
> + eth0_addr: eth-mac-addr@22 {
> reg = <0x22 0x6>;
> };
> };
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: ingenic: correct unit node address
2022-03-17 11:52 [PATCH] MIPS: ingenic: correct unit node address Krzysztof Kozlowski
2022-03-17 14:53 ` Paul Cercueil
@ 2022-03-18 8:42 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2022-03-18 8:42 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Paul Cercueil, Rob Herring, Krzysztof Kozlowski, linux-mips,
devicetree, linux-kernel
On Thu, Mar 17, 2022 at 12:52:59PM +0100, Krzysztof Kozlowski wrote:
> Unit node addresses should not have leading 0x:
>
> Warning (unit_address_format): /nemc@13410000/efuse@d0/eth-mac-addr@0x22: unit name should not have leading "0x"
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> index 3f9ea47a10cd..b998301f179c 100644
> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> @@ -510,7 +510,7 @@ efuse: efuse@d0 {
> #address-cells = <1>;
> #size-cells = <1>;
>
> - eth0_addr: eth-mac-addr@0x22 {
> + eth0_addr: eth-mac-addr@22 {
> reg = <0x22 0x6>;
> };
> };
> --
> 2.32.0
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-18 8:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-17 11:52 [PATCH] MIPS: ingenic: correct unit node address Krzysztof Kozlowski
2022-03-17 14:53 ` Paul Cercueil
2022-03-18 8:42 ` Thomas Bogendoerfer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.