Re: Queries on CAN frame work - Marc Kleine-Budde

From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Srinivas Neeli <sneeli@xilinx.com>
Cc: "Srinivas Goud" <sgoud@xilinx.com>,
	"Naveen Kumar Gaddipati" <naveenku@xilinx.com>,
	"Prasad Beer Prasad" <prasadbe@xilinx.com>,
	linux-can <linux-can@vger.kernel.org>,
	"Stefan Mätje" <stefan.maetje@esd.eu>,
	"Vincent MAILHOL" <mailhol.vincent@wanadoo.fr>
Subject: Re: Queries on CAN frame work
Date: Fri, 18 Mar 2022 11:01:31 +0100	[thread overview]
Message-ID: <20220318100131.3hbz7pi63kf2n7je@pengutronix.de> (raw)
In-Reply-To: <DM6PR02MB5386167ECF8C0CE87AC15DA6AF139@DM6PR02MB5386.namprd02.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1678 bytes --]

On 18.03.2022 09:54:37, Srinivas Neeli wrote:
> > No, you are not. As explained in my last mail, there's no struct
> > can_bittiming_const in the mainline driver that matches your "ip"
> > output.
> 
> Just cross checked the mainline driver and our internal driver.
> I am not seeing difference in struct can_bittiming_const structures.
> We are using 5 structures 
> CAN - 1 structure
> CANFD 1.0 - Arbitration 1, data phase 1
> CANFD 2.0 - Arbitration 1, data phase 1
> Please check below link once.
> https://elixir.bootlin.com/linux/latest/source/drivers/net/can/xilinx_can.c#L216

static const struct can_bittiming_const xcan_bittiming_const = {
	.name = DRIVER_NAME,
	.tseg1_min = 1,
	.tseg1_max = 16,
	.tseg2_min = 1,
	.tseg2_max = 8,
	.sjw_max = 4,
	.brp_min = 1,
	.brp_max = 256,
	.brp_inc = 1,
};

Looking at your "ip" output

| https://lore.kernel.org/all/DM6PR02MB538689AA158B340FE287CF05AF3A9@DM6PR02MB5386.namprd02.prod.outlook.com/

it says:

          xilinx_can: tseg1 1..256 tseg2 1..128 sjw 1..128 brp 1..256 brp-inc 1
          xilinx_can: dtseg1 1..32 dtseg2 1..16 dsjw 1..16 dbrp 1..256 dbrp-inc 1

> Could you please let me know if I miss anything?

That does not match to the "struct can_bittiming_const
xcan_bittiming_const" you referenced
(https://elixir.bootlin.com/linux/latest/source/drivers/net/can/xilinx_can.c#L216).

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]