* [Buildroot] [PATCH v1 1/2] package/libcamera-apps: X11 support needs libdrm
@ 2022-03-18 13:10 Peter Seiderer
2022-03-18 13:10 ` [Buildroot] [PATCH v1 2/2] package/libcamera-apps: add '-fpermissive' (fixes X11 preview compile) Peter Seiderer
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Peter Seiderer @ 2022-03-18 13:10 UTC (permalink / raw)
To: buildroot
- X11 support needs libdrm (optional libdrm dependency already
present in libcamera-apps.mk)
Fixes:
http://autobuild.buildroot.net/results/5df48038df5deb4f1e85287cde9a403c5681c28e
.../build/libcamera-apps-2d1009e3badcc8047361ff81149ad6cba3b911b5/preview/egl_preview.cpp:18:10: fatal error: libdrm/drm_fourcc.h: No such file or directory
18 | #include <libdrm/drm_fourcc.h>
| ^~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
package/libcamera-apps/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/libcamera-apps/Config.in b/package/libcamera-apps/Config.in
index a1affc2d23..492a99cf55 100644
--- a/package/libcamera-apps/Config.in
+++ b/package/libcamera-apps/Config.in
@@ -14,6 +14,7 @@ config BR2_PACKAGE_LIBCAMERA_APPS
select BR2_PACKAGE_LIBPNG
select BR2_PACKAGE_TIFF
select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7 && (BR2_PACKAGE_HAS_LIBEGL || BR2_PACKAGE_HAS_LIBGL)
+ select BR2_PACKAGE_LIBDRM if BR2_PACKAGE_XORG7 && (BR2_PACKAGE_HAS_LIBEGL || BR2_PACKAGE_HAS_LIBGL)
select BR2_PACKAGE_LIBEPOXY if BR2_PACKAGE_XORG7 && (BR2_PACKAGE_HAS_LIBEGL || BR2_PACKAGE_HAS_LIBGL)
select BR2_PACKAGE_QT5BASE_GUI if BR2_PACKAGE_QT5
select BR2_PACKAGE_QT5BASE_WIDGETS if BR2_PACKAGE_QT5
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v1 2/2] package/libcamera-apps: add '-fpermissive' (fixes X11 preview compile)
2022-03-18 13:10 [Buildroot] [PATCH v1 1/2] package/libcamera-apps: X11 support needs libdrm Peter Seiderer
@ 2022-03-18 13:10 ` Peter Seiderer
2022-03-27 15:40 ` Arnout Vandecappelle
2022-03-27 15:37 ` [Buildroot] [PATCH v1 1/2] package/libcamera-apps: X11 support needs libdrm Arnout Vandecappelle
2022-03-30 17:25 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Peter Seiderer @ 2022-03-18 13:10 UTC (permalink / raw)
To: buildroot
- add patch to add '-fpermissive' compiler command line option to fix
egl_preview.cpp compile
Fixes:
.../build/libcamera-apps-2d1009e3badcc8047361ff81149ad6cba3b911b5/preview/egl_preview.cpp:329:69: error: invalid conversion from ‘Window’ {aka ‘long unsigned int’} to ‘EGLNativeWindowType’ {aka ‘fbdev_window*’} [-fpermissive]
329 | egl_surface_ = eglCreateWindowSurface(egl_display_, config, window_, NULL);
| ^~~~~~~
| |
| Window {aka long unsigned int}
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
...missive-compiler-command-line-option.patch | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 package/libcamera-apps/0002-cmake-add-fpermissive-compiler-command-line-option.patch
diff --git a/package/libcamera-apps/0002-cmake-add-fpermissive-compiler-command-line-option.patch b/package/libcamera-apps/0002-cmake-add-fpermissive-compiler-command-line-option.patch
new file mode 100644
index 0000000000..0bfc7e1ad4
--- /dev/null
+++ b/package/libcamera-apps/0002-cmake-add-fpermissive-compiler-command-line-option.patch
@@ -0,0 +1,37 @@
+From b04777e6b386ed0c6b1036d4c1178b4b8a1c88d5 Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <ps.report@gmx.net>
+Date: Fri, 18 Mar 2022 12:39:27 +0100
+Subject: [PATCH] cmake: add -fpermissive compiler command line option
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Fixes (with bootlin arm toolchain):
+
+ .../build/libcamera-apps-2d1009e3badcc8047361ff81149ad6cba3b911b5/preview/egl_preview.cpp:329:69: error: invalid conversion from ‘Window’ {aka ‘long unsigned int’} to ‘EGLNativeWindowType’ {aka ‘fbdev_window*’} [-fpermissive]
+ 329 | egl_surface_ = eglCreateWindowSurface(egl_display_, config, window_, NULL);
+ | ^~~~~~~
+ | |
+ | Window {aka long unsigned int}
+
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+---
+ CMakeLists.txt | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 1ca1e39..eddda1f 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -11,7 +11,7 @@ endif()
+
+ set (CMAKE_EXPORT_COMPILE_COMMANDS ON)
+ set (CMAKE_CXX_STANDARD 17)
+-add_compile_options(-Wall -Wextra -pedantic -Wno-unused-parameter -faligned-new)
++add_compile_options(-Wall -Wextra -pedantic -Wno-unused-parameter -faligned-new -fpermissive)
+ add_definitions(-D_FILE_OFFSET_BITS=64)
+
+ if (CMAKE_COMPILER_IS_GNUCXX)
+--
+2.35.1
+
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v1 1/2] package/libcamera-apps: X11 support needs libdrm
2022-03-18 13:10 [Buildroot] [PATCH v1 1/2] package/libcamera-apps: X11 support needs libdrm Peter Seiderer
2022-03-18 13:10 ` [Buildroot] [PATCH v1 2/2] package/libcamera-apps: add '-fpermissive' (fixes X11 preview compile) Peter Seiderer
@ 2022-03-27 15:37 ` Arnout Vandecappelle
2022-03-30 17:25 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2022-03-27 15:37 UTC (permalink / raw)
To: Peter Seiderer, buildroot
On 18/03/2022 14:10, Peter Seiderer wrote:
> - X11 support needs libdrm (optional libdrm dependency already
> present in libcamera-apps.mk)
>
> Fixes:
>
> http://autobuild.buildroot.net/results/5df48038df5deb4f1e85287cde9a403c5681c28e
>
> .../build/libcamera-apps-2d1009e3badcc8047361ff81149ad6cba3b911b5/preview/egl_preview.cpp:18:10: fatal error: libdrm/drm_fourcc.h: No such file or directory
> 18 | #include <libdrm/drm_fourcc.h>
> | ^~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Applied to master, thanks.
Regards,
Arnout
> ---
> package/libcamera-apps/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/libcamera-apps/Config.in b/package/libcamera-apps/Config.in
> index a1affc2d23..492a99cf55 100644
> --- a/package/libcamera-apps/Config.in
> +++ b/package/libcamera-apps/Config.in
> @@ -14,6 +14,7 @@ config BR2_PACKAGE_LIBCAMERA_APPS
> select BR2_PACKAGE_LIBPNG
> select BR2_PACKAGE_TIFF
> select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7 && (BR2_PACKAGE_HAS_LIBEGL || BR2_PACKAGE_HAS_LIBGL)
> + select BR2_PACKAGE_LIBDRM if BR2_PACKAGE_XORG7 && (BR2_PACKAGE_HAS_LIBEGL || BR2_PACKAGE_HAS_LIBGL)
> select BR2_PACKAGE_LIBEPOXY if BR2_PACKAGE_XORG7 && (BR2_PACKAGE_HAS_LIBEGL || BR2_PACKAGE_HAS_LIBGL)
> select BR2_PACKAGE_QT5BASE_GUI if BR2_PACKAGE_QT5
> select BR2_PACKAGE_QT5BASE_WIDGETS if BR2_PACKAGE_QT5
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v1 2/2] package/libcamera-apps: add '-fpermissive' (fixes X11 preview compile)
2022-03-18 13:10 ` [Buildroot] [PATCH v1 2/2] package/libcamera-apps: add '-fpermissive' (fixes X11 preview compile) Peter Seiderer
@ 2022-03-27 15:40 ` Arnout Vandecappelle
0 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2022-03-27 15:40 UTC (permalink / raw)
To: Peter Seiderer, buildroot
On 18/03/2022 14:10, Peter Seiderer wrote:
> - add patch to add '-fpermissive' compiler command line option to fix
> egl_preview.cpp compile
>
> Fixes:
>
> .../build/libcamera-apps-2d1009e3badcc8047361ff81149ad6cba3b911b5/preview/egl_preview.cpp:329:69: error: invalid conversion from ‘Window’ {aka ‘long unsigned int’} to ‘EGLNativeWindowType’ {aka ‘fbdev_window*’} [-fpermissive]
> 329 | egl_surface_ = eglCreateWindowSurface(egl_display_, config, window_, NULL);
> | ^~~~~~~
> | |
> | Window {aka long unsigned int}
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> ...missive-compiler-command-line-option.patch | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 package/libcamera-apps/0002-cmake-add-fpermissive-compiler-command-line-option.patch
>
> diff --git a/package/libcamera-apps/0002-cmake-add-fpermissive-compiler-command-line-option.patch b/package/libcamera-apps/0002-cmake-add-fpermissive-compiler-command-line-option.patch
> new file mode 100644
> index 0000000000..0bfc7e1ad4
> --- /dev/null
> +++ b/package/libcamera-apps/0002-cmake-add-fpermissive-compiler-command-line-option.patch
> @@ -0,0 +1,37 @@
> +From b04777e6b386ed0c6b1036d4c1178b4b8a1c88d5 Mon Sep 17 00:00:00 2001
> +From: Peter Seiderer <ps.report@gmx.net>
> +Date: Fri, 18 Mar 2022 12:39:27 +0100
> +Subject: [PATCH] cmake: add -fpermissive compiler command line option
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +Fixes (with bootlin arm toolchain):
> +
> + .../build/libcamera-apps-2d1009e3badcc8047361ff81149ad6cba3b911b5/preview/egl_preview.cpp:329:69: error: invalid conversion from ‘Window’ {aka ‘long unsigned int’} to ‘EGLNativeWindowType’ {aka ‘fbdev_window*’} [-fpermissive]
> + 329 | egl_surface_ = eglCreateWindowSurface(egl_display_, config, window_, NULL);
> + | ^~~~~~~
> + | |
> + | Window {aka long unsigned int}
> +
> +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> +---
> + CMakeLists.txt | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/CMakeLists.txt b/CMakeLists.txt
> +index 1ca1e39..eddda1f 100644
> +--- a/CMakeLists.txt
> ++++ b/CMakeLists.txt
> +@@ -11,7 +11,7 @@ endif()
> +
> + set (CMAKE_EXPORT_COMPILE_COMMANDS ON)
> + set (CMAKE_CXX_STANDARD 17)
> +-add_compile_options(-Wall -Wextra -pedantic -Wno-unused-parameter -faligned-new)
> ++add_compile_options(-Wall -Wextra -pedantic -Wno-unused-parameter -faligned-new -fpermissive)
This patch is most likely not upstreamable (and I indeed can't find your
upstream PR). It would be much better to simply fix the underlying issue and
upstream that. Should be simple enough, just add a cast.
Regards,
Arnout
> + add_definitions(-D_FILE_OFFSET_BITS=64)
> +
> + if (CMAKE_COMPILER_IS_GNUCXX)
> +--
> +2.35.1
> +
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v1 1/2] package/libcamera-apps: X11 support needs libdrm
2022-03-18 13:10 [Buildroot] [PATCH v1 1/2] package/libcamera-apps: X11 support needs libdrm Peter Seiderer
2022-03-18 13:10 ` [Buildroot] [PATCH v1 2/2] package/libcamera-apps: add '-fpermissive' (fixes X11 preview compile) Peter Seiderer
2022-03-27 15:37 ` [Buildroot] [PATCH v1 1/2] package/libcamera-apps: X11 support needs libdrm Arnout Vandecappelle
@ 2022-03-30 17:25 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2022-03-30 17:25 UTC (permalink / raw)
To: Peter Seiderer; +Cc: buildroot
>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:
> - X11 support needs libdrm (optional libdrm dependency already
> present in libcamera-apps.mk)
> Fixes:
> http://autobuild.buildroot.net/results/5df48038df5deb4f1e85287cde9a403c5681c28e
> .../build/libcamera-apps-2d1009e3badcc8047361ff81149ad6cba3b911b5/preview/egl_preview.cpp:18:10: fatal error: libdrm/drm_fourcc.h: No such file or directory
> 18 | #include <libdrm/drm_fourcc.h>
> | ^~~~~~~~~~~~~~~~~~~~~
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-03-30 17:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-18 13:10 [Buildroot] [PATCH v1 1/2] package/libcamera-apps: X11 support needs libdrm Peter Seiderer
2022-03-18 13:10 ` [Buildroot] [PATCH v1 2/2] package/libcamera-apps: add '-fpermissive' (fixes X11 preview compile) Peter Seiderer
2022-03-27 15:40 ` Arnout Vandecappelle
2022-03-27 15:37 ` [Buildroot] [PATCH v1 1/2] package/libcamera-apps: X11 support needs libdrm Arnout Vandecappelle
2022-03-30 17:25 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.