From: kernel test robot <lkp@intel.com>
To: Jane Chu <jane.chu@oracle.com>,
david@fromorbit.com, djwong@kernel.org, dan.j.williams@intel.com,
hch@infradead.org, vishal.l.verma@intel.com,
dave.jiang@intel.com, agk@redhat.com, snitzer@redhat.com,
dm-devel@redhat.com, ira.weiny@intel.com, willy@infradead.org,
vgoyal@redhat.com, linux-fsdevel@vger.kernel.org,
nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org
Cc: kbuild-all@lists.01.org
Subject: Re: [PATCH v6 4/6] dax: add DAX_RECOVERY flag and .recovery_write dev_pgmap_ops
Date: Sat, 19 Mar 2022 16:24:04 +0800 [thread overview]
Message-ID: <202203191610.umg0CGkh-lkp@intel.com> (raw)
In-Reply-To: <20220319062833.3136528-5-jane.chu@oracle.com>
Hi Jane,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on nvdimm/libnvdimm-for-next]
[also build test WARNING on device-mapper-dm/for-next linus/master v5.17-rc8 next-20220318]
[cannot apply to tip/x86/mm]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jane-Chu/DAX-poison-recovery/20220319-143144
base: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git libnvdimm-for-next
config: s390-randconfig-r044-20220317 (https://download.01.org/0day-ci/archive/20220319/202203191610.umg0CGkh-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/203570f765a6ad07eb5809850478a25a5257f7e2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jane-Chu/DAX-poison-recovery/20220319-143144
git checkout 203570f765a6ad07eb5809850478a25a5257f7e2
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash fs/fuse/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
fs/fuse/virtio_fs.c: In function 'virtio_fs_zero_page_range':
>> fs/fuse/virtio_fs.c:774:58: warning: passing argument 4 of 'dax_direct_access' makes integer from pointer without a cast [-Wint-conversion]
774 | rc = dax_direct_access(dax_dev, pgoff, nr_pages, &kaddr, NULL);
| ^~~~~~
| |
| void **
In file included from fs/fuse/virtio_fs.c:8:
include/linux/dax.h:187:21: note: expected 'int' but argument is of type 'void **'
187 | int flags, void **kaddr, pfn_t *pfn);
| ~~~~^~~~~
fs/fuse/virtio_fs.c:774:14: error: too few arguments to function 'dax_direct_access'
774 | rc = dax_direct_access(dax_dev, pgoff, nr_pages, &kaddr, NULL);
| ^~~~~~~~~~~~~~~~~
In file included from fs/fuse/virtio_fs.c:8:
include/linux/dax.h:186:6: note: declared here
186 | long dax_direct_access(struct dax_device *dax_dev, pgoff_t pgoff, long nr_pages,
| ^~~~~~~~~~~~~~~~~
fs/fuse/virtio_fs.c: At top level:
fs/fuse/virtio_fs.c:783:26: error: initialization of 'long int (*)(struct dax_device *, long unsigned int, long int, int, void **, pfn_t *)' from incompatible pointer type 'long int (*)(struct dax_device *, long unsigned int, long int, void **, pfn_t *)' [-Werror=incompatible-pointer-types]
783 | .direct_access = virtio_fs_direct_access,
| ^~~~~~~~~~~~~~~~~~~~~~~
fs/fuse/virtio_fs.c:783:26: note: (near initialization for 'virtio_fs_dax_ops.direct_access')
cc1: some warnings being treated as errors
vim +/dax_direct_access +774 fs/fuse/virtio_fs.c
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 767
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 768 static int virtio_fs_zero_page_range(struct dax_device *dax_dev,
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 769 pgoff_t pgoff, size_t nr_pages)
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 770 {
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 771 long rc;
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 772 void *kaddr;
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 773
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 @774 rc = dax_direct_access(dax_dev, pgoff, nr_pages, &kaddr, NULL);
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 775 if (rc < 0)
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 776 return rc;
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 777 memset(kaddr, 0, nr_pages << PAGE_SHIFT);
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 778 dax_flush(dax_dev, kaddr, nr_pages << PAGE_SHIFT);
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 779 return 0;
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 780 }
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 781
---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Jane Chu <jane.chu@oracle.com>,
david@fromorbit.com, djwong@kernel.org, dan.j.williams@intel.com,
hch@infradead.org, vishal.l.verma@intel.com,
dave.jiang@intel.com, agk@redhat.com, snitzer@redhat.com,
dm-devel@redhat.com, ira.weiny@intel.com, willy@infradead.org,
vgoyal@redhat.com, linux-fsdevel@vger.kernel.org,
nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org
Cc: kbuild-all@lists.01.org
Subject: Re: [dm-devel] [PATCH v6 4/6] dax: add DAX_RECOVERY flag and .recovery_write dev_pgmap_ops
Date: Sat, 19 Mar 2022 16:24:04 +0800 [thread overview]
Message-ID: <202203191610.umg0CGkh-lkp@intel.com> (raw)
In-Reply-To: <20220319062833.3136528-5-jane.chu@oracle.com>
Hi Jane,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on nvdimm/libnvdimm-for-next]
[also build test WARNING on device-mapper-dm/for-next linus/master v5.17-rc8 next-20220318]
[cannot apply to tip/x86/mm]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jane-Chu/DAX-poison-recovery/20220319-143144
base: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git libnvdimm-for-next
config: s390-randconfig-r044-20220317 (https://download.01.org/0day-ci/archive/20220319/202203191610.umg0CGkh-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/203570f765a6ad07eb5809850478a25a5257f7e2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jane-Chu/DAX-poison-recovery/20220319-143144
git checkout 203570f765a6ad07eb5809850478a25a5257f7e2
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash fs/fuse/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
fs/fuse/virtio_fs.c: In function 'virtio_fs_zero_page_range':
>> fs/fuse/virtio_fs.c:774:58: warning: passing argument 4 of 'dax_direct_access' makes integer from pointer without a cast [-Wint-conversion]
774 | rc = dax_direct_access(dax_dev, pgoff, nr_pages, &kaddr, NULL);
| ^~~~~~
| |
| void **
In file included from fs/fuse/virtio_fs.c:8:
include/linux/dax.h:187:21: note: expected 'int' but argument is of type 'void **'
187 | int flags, void **kaddr, pfn_t *pfn);
| ~~~~^~~~~
fs/fuse/virtio_fs.c:774:14: error: too few arguments to function 'dax_direct_access'
774 | rc = dax_direct_access(dax_dev, pgoff, nr_pages, &kaddr, NULL);
| ^~~~~~~~~~~~~~~~~
In file included from fs/fuse/virtio_fs.c:8:
include/linux/dax.h:186:6: note: declared here
186 | long dax_direct_access(struct dax_device *dax_dev, pgoff_t pgoff, long nr_pages,
| ^~~~~~~~~~~~~~~~~
fs/fuse/virtio_fs.c: At top level:
fs/fuse/virtio_fs.c:783:26: error: initialization of 'long int (*)(struct dax_device *, long unsigned int, long int, int, void **, pfn_t *)' from incompatible pointer type 'long int (*)(struct dax_device *, long unsigned int, long int, void **, pfn_t *)' [-Werror=incompatible-pointer-types]
783 | .direct_access = virtio_fs_direct_access,
| ^~~~~~~~~~~~~~~~~~~~~~~
fs/fuse/virtio_fs.c:783:26: note: (near initialization for 'virtio_fs_dax_ops.direct_access')
cc1: some warnings being treated as errors
vim +/dax_direct_access +774 fs/fuse/virtio_fs.c
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 767
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 768 static int virtio_fs_zero_page_range(struct dax_device *dax_dev,
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 769 pgoff_t pgoff, size_t nr_pages)
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 770 {
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 771 long rc;
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 772 void *kaddr;
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 773
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 @774 rc = dax_direct_access(dax_dev, pgoff, nr_pages, &kaddr, NULL);
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 775 if (rc < 0)
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 776 return rc;
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 777 memset(kaddr, 0, nr_pages << PAGE_SHIFT);
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 778 dax_flush(dax_dev, kaddr, nr_pages << PAGE_SHIFT);
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 779 return 0;
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 780 }
22f3787e9d95e7 Stefan Hajnoczi 2020-08-19 781
---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-03-19 8:25 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 6:28 [PATCH v6 0/6] DAX poison recovery Jane Chu
2022-03-19 6:28 ` [dm-devel] " Jane Chu
2022-03-19 6:28 ` [PATCH v6 1/6] x86/mm: fix comment Jane Chu
2022-03-19 6:28 ` [dm-devel] " Jane Chu
2022-03-22 8:40 ` Christoph Hellwig
2022-03-22 8:40 ` [dm-devel] " Christoph Hellwig
2022-03-19 6:28 ` [PATCH v6 2/6] x86/mce: relocate set{clear}_mce_nospec() functions Jane Chu
2022-03-19 6:28 ` [dm-devel] " Jane Chu
2022-03-19 8:13 ` kernel test robot
2022-03-19 8:13 ` [dm-devel] " kernel test robot
2022-03-19 8:24 ` kernel test robot
2022-03-19 8:24 ` [dm-devel] " kernel test robot
2022-03-22 8:42 ` Christoph Hellwig
2022-03-22 8:42 ` [dm-devel] " Christoph Hellwig
2022-03-22 22:19 ` Jane Chu
2022-03-22 22:19 ` [dm-devel] " Jane Chu
2022-03-22 22:41 ` Borislav Petkov
2022-03-22 22:41 ` [dm-devel] " Borislav Petkov
2022-03-22 23:48 ` Jane Chu
2022-03-22 23:48 ` [dm-devel] " Jane Chu
2022-03-19 6:28 ` [PATCH v6 3/6] mce: fix set_mce_nospec to always unmap the whole page Jane Chu
2022-03-19 6:28 ` [dm-devel] " Jane Chu
2022-03-22 8:44 ` Christoph Hellwig
2022-03-22 8:44 ` [dm-devel] " Christoph Hellwig
2022-03-22 22:45 ` Jane Chu
2022-03-22 22:45 ` [dm-devel] " Jane Chu
2022-03-19 6:28 ` [PATCH v6 4/6] dax: add DAX_RECOVERY flag and .recovery_write dev_pgmap_ops Jane Chu
2022-03-19 6:28 ` [dm-devel] " Jane Chu
2022-03-19 8:24 ` kernel test robot [this message]
2022-03-19 8:24 ` kernel test robot
2022-03-19 8:44 ` kernel test robot
2022-03-19 8:44 ` [dm-devel] " kernel test robot
2022-03-22 9:01 ` Christoph Hellwig
2022-03-22 9:01 ` [dm-devel] " Christoph Hellwig
2022-03-22 23:05 ` Jane Chu
2022-03-22 23:05 ` [dm-devel] " Jane Chu
2022-03-23 5:45 ` Christoph Hellwig
2022-03-23 5:45 ` [dm-devel] " Christoph Hellwig
2022-03-23 18:43 ` Jane Chu
2022-03-23 18:43 ` [dm-devel] " Jane Chu
2022-03-24 6:37 ` Christoph Hellwig
2022-03-24 6:37 ` [dm-devel] " Christoph Hellwig
2022-03-26 6:31 ` Jane Chu
2022-03-26 6:31 ` [dm-devel] " Jane Chu
2022-03-19 6:28 ` [PATCH v6 5/6] pmem: refactor pmem_clear_poison() Jane Chu
2022-03-19 6:28 ` [dm-devel] " Jane Chu
2022-03-22 8:53 ` Christoph Hellwig
2022-03-22 8:53 ` [dm-devel] " Christoph Hellwig
2022-03-22 23:45 ` Jane Chu
2022-03-22 23:45 ` [dm-devel] " Jane Chu
2022-03-19 6:28 ` [PATCH v6 6/6] pmem: implement pmem_recovery_write() Jane Chu
2022-03-19 6:28 ` [dm-devel] " Jane Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202203191610.umg0CGkh-lkp@intel.com \
--to=lkp@intel.com \
--cc=agk@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=jane.chu@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=snitzer@redhat.com \
--cc=vgoyal@redhat.com \
--cc=vishal.l.verma@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.