From: Jonathan Cameron <jic23@kernel.org>
To: Jagath Jog J <jagathjog1996@gmail.com>
Cc: dan@dlrobertson.com, andy.shevchenko@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/5] iio: accel: bma400: changing scale min and max macro values
Date: Sun, 20 Mar 2022 17:17:26 +0000 [thread overview]
Message-ID: <20220320171726.7a4bd968@jic23-huawei> (raw)
In-Reply-To: <20220319181023.8090-3-jagathjog1996@gmail.com>
On Sat, 19 Mar 2022 23:40:20 +0530
Jagath Jog J <jagathjog1996@gmail.com> wrote:
> Changing the scale macro values to match the bma400 sensitivity
> for 1 LSB of all the available ranges.
>
> Signed-off-by: Jagath Jog J <jagathjog1996@gmail.com>
This needs a fixes tag and should be the first patch in the series.
I'd also like the maths to be described as these numbers are (I assume)
calculated based on the range and the bit depth of the sensor?
If you can add a comment in the code, then we'll have a convenient
reference alongside the numbers.
> ---
> drivers/iio/accel/bma400.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/bma400.h b/drivers/iio/accel/bma400.h
> index e938da5a57b4..cfc2c9bacec8 100644
> --- a/drivers/iio/accel/bma400.h
> +++ b/drivers/iio/accel/bma400.h
> @@ -83,8 +83,8 @@
> #define BMA400_ACC_ODR_MIN_WHOLE_HZ 25
> #define BMA400_ACC_ODR_MIN_HZ 12
>
> -#define BMA400_SCALE_MIN 38357
> -#define BMA400_SCALE_MAX 306864
> +#define BMA400_SCALE_MIN 9583
> +#define BMA400_SCALE_MAX 76669
>
> #define BMA400_NUM_REGULATORS 2
> #define BMA400_VDD_REGULATOR 0
next prev parent reply other threads:[~2022-03-20 17:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 18:10 [PATCH v1 0/5] iio: accel: bma400: Add support for buffer and step Jagath Jog J
2022-03-19 18:10 ` [PATCH v1 1/5] iio: accel: bma400: conversion to device-managed function Jagath Jog J
2022-03-20 17:14 ` Jonathan Cameron
2022-03-21 21:12 ` Jagath Jog J
2022-03-22 20:41 ` Jonathan Cameron
2022-03-21 8:30 ` Andy Shevchenko
2022-03-21 21:20 ` Jagath Jog J
2022-03-19 18:10 ` [PATCH v1 2/5] iio: accel: bma400: changing scale min and max macro values Jagath Jog J
2022-03-20 17:17 ` Jonathan Cameron [this message]
2022-03-19 18:10 ` [PATCH v1 3/5] iio: accel: bma400: Add triggered buffer support Jagath Jog J
2022-03-20 3:30 ` kernel test robot
2022-03-20 17:26 ` Jonathan Cameron
2022-03-21 8:39 ` Andy Shevchenko
2022-03-21 22:21 ` Jagath Jog J
2022-03-22 8:54 ` Andy Shevchenko
2022-03-22 15:40 ` Jagath Jog J
2022-03-22 16:12 ` Andy Shevchenko
2022-03-19 18:10 ` [PATCH v1 4/5] iio: accel: bma400: Add separate channel for step counter Jagath Jog J
2022-03-20 17:30 ` Jonathan Cameron
2022-03-21 8:42 ` Andy Shevchenko
2022-03-21 8:43 ` Andy Shevchenko
2022-03-19 18:10 ` [PATCH v1 5/5] iio: accel: bma400: Add step change event Jagath Jog J
2022-03-20 17:37 ` Jonathan Cameron
2022-03-21 22:52 ` Jagath Jog J
2022-03-21 8:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220320171726.7a4bd968@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=dan@dlrobertson.com \
--cc=jagathjog1996@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.