From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jagath Jog J <jagathjog1996@gmail.com>
Cc: Dan Robertson <dan@dlrobertson.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 4/5] iio: accel: bma400: Add separate channel for step counter
Date: Mon, 21 Mar 2022 10:42:19 +0200 [thread overview]
Message-ID: <CAHp75Ve9cJ9+UuimxD33h-2oDz0ESx640=-0rPbjnk0AVvFfeQ@mail.gmail.com> (raw)
In-Reply-To: <20220319181023.8090-5-jagathjog1996@gmail.com>
On Sat, Mar 19, 2022 at 8:10 PM Jagath Jog J <jagathjog1996@gmail.com> wrote:
>
> Added channel for step counter which can be enable or disable
> through the sysfs interface.
...
> + u32 steps_raw;
I would expect this to be u8 ...[3].
...
> + ret = regmap_bulk_read(data->regmap, BMA400_STEP_CNT0_REG,
> + &steps_raw, 3 * sizeof(u8));
sizeof(&steps_raw);
...
> + *val = steps_raw & 0x00FFFFFF;
And here it seems to be be24_to_cpu() like Jonathan mentioned,
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-21 8:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 18:10 [PATCH v1 0/5] iio: accel: bma400: Add support for buffer and step Jagath Jog J
2022-03-19 18:10 ` [PATCH v1 1/5] iio: accel: bma400: conversion to device-managed function Jagath Jog J
2022-03-20 17:14 ` Jonathan Cameron
2022-03-21 21:12 ` Jagath Jog J
2022-03-22 20:41 ` Jonathan Cameron
2022-03-21 8:30 ` Andy Shevchenko
2022-03-21 21:20 ` Jagath Jog J
2022-03-19 18:10 ` [PATCH v1 2/5] iio: accel: bma400: changing scale min and max macro values Jagath Jog J
2022-03-20 17:17 ` Jonathan Cameron
2022-03-19 18:10 ` [PATCH v1 3/5] iio: accel: bma400: Add triggered buffer support Jagath Jog J
2022-03-20 3:30 ` kernel test robot
2022-03-20 17:26 ` Jonathan Cameron
2022-03-21 8:39 ` Andy Shevchenko
2022-03-21 22:21 ` Jagath Jog J
2022-03-22 8:54 ` Andy Shevchenko
2022-03-22 15:40 ` Jagath Jog J
2022-03-22 16:12 ` Andy Shevchenko
2022-03-19 18:10 ` [PATCH v1 4/5] iio: accel: bma400: Add separate channel for step counter Jagath Jog J
2022-03-20 17:30 ` Jonathan Cameron
2022-03-21 8:42 ` Andy Shevchenko [this message]
2022-03-21 8:43 ` Andy Shevchenko
2022-03-19 18:10 ` [PATCH v1 5/5] iio: accel: bma400: Add step change event Jagath Jog J
2022-03-20 17:37 ` Jonathan Cameron
2022-03-21 22:52 ` Jagath Jog J
2022-03-21 8:45 ` Andy Shevchenko
2022-03-20 4:21 [PATCH v1 4/5] iio: accel: bma400: Add separate channel for step counter kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Ve9cJ9+UuimxD33h-2oDz0ESx640=-0rPbjnk0AVvFfeQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=dan@dlrobertson.com \
--cc=jagathjog1996@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.