* [PATCH 1/3] nvmem: bcm-ocotp: mark ACPI device ID table as maybe unused
@ 2022-03-21 11:03 Krzysztof Kozlowski
2022-03-21 11:03 ` [PATCH 2/3] nvmem: sunplus-ocotp: staticize sp_otp_v0 Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-21 11:03 UTC (permalink / raw)
To: Srinivas Kandagatla, Vincent Shih, Greg Kroah-Hartman, linux-kernel
Cc: Krzysztof Kozlowski
"bcm_otpc_acpi_ids" is used with ACPI_PTR, so a build with !CONFIG_ACPI
has a warning:
drivers/nvmem/bcm-ocotp.c:247:36: error:
‘bcm_otpc_acpi_ids’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/nvmem/bcm-ocotp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvmem/bcm-ocotp.c b/drivers/nvmem/bcm-ocotp.c
index a8097511582a..dfea96c52463 100644
--- a/drivers/nvmem/bcm-ocotp.c
+++ b/drivers/nvmem/bcm-ocotp.c
@@ -244,7 +244,7 @@ static const struct of_device_id bcm_otpc_dt_ids[] = {
};
MODULE_DEVICE_TABLE(of, bcm_otpc_dt_ids);
-static const struct acpi_device_id bcm_otpc_acpi_ids[] = {
+static const struct acpi_device_id bcm_otpc_acpi_ids[] __maybe_unused = {
{ .id = "BRCM0700", .driver_data = (kernel_ulong_t)&otp_map },
{ .id = "BRCM0701", .driver_data = (kernel_ulong_t)&otp_map_v2 },
{ /* sentinel */ }
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/3] nvmem: sunplus-ocotp: staticize sp_otp_v0
2022-03-21 11:03 [PATCH 1/3] nvmem: bcm-ocotp: mark ACPI device ID table as maybe unused Krzysztof Kozlowski
@ 2022-03-21 11:03 ` Krzysztof Kozlowski
2022-03-21 11:03 ` [PATCH 3/3] nvmem: sunplus-ocotp: drop useless probe confirmation Krzysztof Kozlowski
2022-04-29 9:29 ` [PATCH 1/3] nvmem: bcm-ocotp: mark ACPI device ID table as maybe unused Srinivas Kandagatla
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-21 11:03 UTC (permalink / raw)
To: Srinivas Kandagatla, Vincent Shih, Greg Kroah-Hartman, linux-kernel
Cc: Krzysztof Kozlowski, kernel test robot
The "sp_otp_v0" file scope variable is not used outside, so make it
static to fix warning:
drivers/nvmem/sunplus-ocotp.c:74:29: sparse:
sparse: symbol 'sp_otp_v0' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/nvmem/sunplus-ocotp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvmem/sunplus-ocotp.c b/drivers/nvmem/sunplus-ocotp.c
index 2dc59c22eb55..c94134649714 100644
--- a/drivers/nvmem/sunplus-ocotp.c
+++ b/drivers/nvmem/sunplus-ocotp.c
@@ -71,7 +71,7 @@ struct sp_ocotp_data {
int size;
};
-const struct sp_ocotp_data sp_otp_v0 = {
+static const struct sp_ocotp_data sp_otp_v0 = {
.size = QAC628_OTP_SIZE,
};
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 3/3] nvmem: sunplus-ocotp: drop useless probe confirmation
2022-03-21 11:03 [PATCH 1/3] nvmem: bcm-ocotp: mark ACPI device ID table as maybe unused Krzysztof Kozlowski
2022-03-21 11:03 ` [PATCH 2/3] nvmem: sunplus-ocotp: staticize sp_otp_v0 Krzysztof Kozlowski
@ 2022-03-21 11:03 ` Krzysztof Kozlowski
2022-04-29 9:29 ` [PATCH 1/3] nvmem: bcm-ocotp: mark ACPI device ID table as maybe unused Srinivas Kandagatla
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-21 11:03 UTC (permalink / raw)
To: Srinivas Kandagatla, Vincent Shih, Greg Kroah-Hartman, linux-kernel
Cc: Krzysztof Kozlowski
Printing probe success is discouraged, because we can use tracing for
this purpose. Remove useless print message after Sunplus OCOTP driver
probe.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/nvmem/sunplus-ocotp.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/nvmem/sunplus-ocotp.c b/drivers/nvmem/sunplus-ocotp.c
index c94134649714..52b928a7a6d5 100644
--- a/drivers/nvmem/sunplus-ocotp.c
+++ b/drivers/nvmem/sunplus-ocotp.c
@@ -202,8 +202,6 @@ static int sp_ocotp_probe(struct platform_device *pdev)
(int)QAC628_OTP_NUM_BANKS, (int)OTP_WORDS_PER_BANK,
(int)OTP_WORD_SIZE, (int)QAC628_OTP_SIZE);
- dev_info(dev, "by Sunplus (C) 2020");
-
return 0;
}
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] nvmem: bcm-ocotp: mark ACPI device ID table as maybe unused
2022-03-21 11:03 [PATCH 1/3] nvmem: bcm-ocotp: mark ACPI device ID table as maybe unused Krzysztof Kozlowski
2022-03-21 11:03 ` [PATCH 2/3] nvmem: sunplus-ocotp: staticize sp_otp_v0 Krzysztof Kozlowski
2022-03-21 11:03 ` [PATCH 3/3] nvmem: sunplus-ocotp: drop useless probe confirmation Krzysztof Kozlowski
@ 2022-04-29 9:29 ` Srinivas Kandagatla
2 siblings, 0 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2022-04-29 9:29 UTC (permalink / raw)
To: Krzysztof Kozlowski, Vincent Shih, Greg Kroah-Hartman, linux-kernel
On 21/03/2022 11:03, Krzysztof Kozlowski wrote:
> "bcm_otpc_acpi_ids" is used with ACPI_PTR, so a build with !CONFIG_ACPI
> has a warning:
>
> drivers/nvmem/bcm-ocotp.c:247:36: error:
> ‘bcm_otpc_acpi_ids’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied all thanks,
--srini
> ---
> drivers/nvmem/bcm-ocotp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/bcm-ocotp.c b/drivers/nvmem/bcm-ocotp.c
> index a8097511582a..dfea96c52463 100644
> --- a/drivers/nvmem/bcm-ocotp.c
> +++ b/drivers/nvmem/bcm-ocotp.c
> @@ -244,7 +244,7 @@ static const struct of_device_id bcm_otpc_dt_ids[] = {
> };
> MODULE_DEVICE_TABLE(of, bcm_otpc_dt_ids);
>
> -static const struct acpi_device_id bcm_otpc_acpi_ids[] = {
> +static const struct acpi_device_id bcm_otpc_acpi_ids[] __maybe_unused = {
> { .id = "BRCM0700", .driver_data = (kernel_ulong_t)&otp_map },
> { .id = "BRCM0701", .driver_data = (kernel_ulong_t)&otp_map_v2 },
> { /* sentinel */ }
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-29 9:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-21 11:03 [PATCH 1/3] nvmem: bcm-ocotp: mark ACPI device ID table as maybe unused Krzysztof Kozlowski
2022-03-21 11:03 ` [PATCH 2/3] nvmem: sunplus-ocotp: staticize sp_otp_v0 Krzysztof Kozlowski
2022-03-21 11:03 ` [PATCH 3/3] nvmem: sunplus-ocotp: drop useless probe confirmation Krzysztof Kozlowski
2022-04-29 9:29 ` [PATCH 1/3] nvmem: bcm-ocotp: mark ACPI device ID table as maybe unused Srinivas Kandagatla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.