All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] net: marvell: prestera: add missing destroy_workqueue() in prestera_module_init()
@ 2022-03-22  9:02 Yang Yingliang
  2022-03-23 17:50 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-03-22  9:02 UTC (permalink / raw)
  To: linux-kernel, netdev; +Cc: yevhen.orlov, tchornyi, oleksandr.mazur, davem

Add the missing destroy_workqueue() before return from
prestera_module_init() in the error handling case.

Fixes: 4394fbcb78cf ("net: marvell: prestera: handle fib notifications")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/net/ethernet/marvell/prestera/prestera_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index 1402c7889e78..3952fdcc9240 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -1032,8 +1032,10 @@ static int __init prestera_module_init(void)
 		return -ENOMEM;
 
 	prestera_owq = alloc_ordered_workqueue("prestera_ordered", 0);
-	if (!prestera_owq)
+	if (!prestera_owq) {
+		destroy_workqueue(prestera_wq);
 		return -ENOMEM;
+	}
 
 	return 0;
 }
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] net: marvell: prestera: add missing destroy_workqueue() in prestera_module_init()
  2022-03-22  9:02 [PATCH -next] net: marvell: prestera: add missing destroy_workqueue() in prestera_module_init() Yang Yingliang
@ 2022-03-23 17:50 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-23 17:50 UTC (permalink / raw)
  To: Yang Yingliang
  Cc: linux-kernel, netdev, yevhen.orlov, tchornyi, oleksandr.mazur, davem

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 22 Mar 2022 17:02:36 +0800 you wrote:
> Add the missing destroy_workqueue() before return from
> prestera_module_init() in the error handling case.
> 
> Fixes: 4394fbcb78cf ("net: marvell: prestera: handle fib notifications")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/net/ethernet/marvell/prestera/prestera_main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Here is the summary with links:
  - [-next] net: marvell: prestera: add missing destroy_workqueue() in prestera_module_init()
    https://git.kernel.org/netdev/net-next/c/4a6806cfcbca

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-23 17:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-22  9:02 [PATCH -next] net: marvell: prestera: add missing destroy_workqueue() in prestera_module_init() Yang Yingliang
2022-03-23 17:50 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.