All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: mark.rutland@arm.com, mingo@redhat.com, tglx@linutronix.de,
	catalin.marinas@arm.com, will@kernel.org,
	dave.hansen@linux.intel.com, broonie@kernel.org, x86@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, songmuchun@bytedance.com,
	qirui.001@bytedance.com
Subject: Re: [External] Re: [PATCH v3 3/3] arm64/ftrace: Make function graph use ftrace directly
Date: Tue, 22 Mar 2022 10:49:56 -0400	[thread overview]
Message-ID: <20220322104956.42203163@gandalf.local.home> (raw)
In-Reply-To: <7807fc23-c6c9-b6a9-62ef-e34e8beefdea@bytedance.com>

On Tue, 22 Mar 2022 22:14:11 +0800
Chengming Zhou <zhouchengming@bytedance.com> wrote:

> > You deleted ftrace_graph_caller above from entry-ftrace.S, if we can get
> > here with some options, wouldn't that break the build?  
> 
> The above ftrace_graph_caller deleted is only for CONFIG_DYNAMIC_FTRACE_WITH_REGS,
> and I tried using a low gcc version that doesn't select HAVE_DYNAMIC_FTRACE_WITH_REGS,
> it can build success.

OK, I didn't look too deep into this.

I don't have an issue with this patch, but it needs to go through the arm64
tree.

-- Steve

WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: mark.rutland@arm.com, mingo@redhat.com, tglx@linutronix.de,
	catalin.marinas@arm.com, will@kernel.org,
	dave.hansen@linux.intel.com, broonie@kernel.org, x86@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, songmuchun@bytedance.com,
	qirui.001@bytedance.com
Subject: Re: [External] Re: [PATCH v3 3/3] arm64/ftrace: Make function graph use ftrace directly
Date: Tue, 22 Mar 2022 10:49:56 -0400	[thread overview]
Message-ID: <20220322104956.42203163@gandalf.local.home> (raw)
In-Reply-To: <7807fc23-c6c9-b6a9-62ef-e34e8beefdea@bytedance.com>

On Tue, 22 Mar 2022 22:14:11 +0800
Chengming Zhou <zhouchengming@bytedance.com> wrote:

> > You deleted ftrace_graph_caller above from entry-ftrace.S, if we can get
> > here with some options, wouldn't that break the build?  
> 
> The above ftrace_graph_caller deleted is only for CONFIG_DYNAMIC_FTRACE_WITH_REGS,
> and I tried using a low gcc version that doesn't select HAVE_DYNAMIC_FTRACE_WITH_REGS,
> it can build success.

OK, I didn't look too deep into this.

I don't have an issue with this patch, but it needs to go through the arm64
tree.

-- Steve

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-03-22 14:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24  9:32 [PATCH v3 1/3] ftrace: cleanup ftrace_graph_caller enable and disable Chengming Zhou
2022-02-24  9:32 ` Chengming Zhou
2022-02-24  9:32 ` [PATCH v3 2/3] x86/ftrace: cleanup graph tracer Chengming Zhou
2022-02-24  9:32   ` Chengming Zhou
2022-02-24  9:32 ` [PATCH v3 3/3] arm64/ftrace: Make function graph use ftrace directly Chengming Zhou
2022-02-24  9:32   ` Chengming Zhou
2022-03-22 12:48   ` Chengming Zhou
2022-03-22 12:48     ` Chengming Zhou
2022-03-22 13:41     ` Steven Rostedt
2022-03-22 13:41       ` Steven Rostedt
2022-03-22 14:14       ` [External] " Chengming Zhou
2022-03-22 14:14         ` Chengming Zhou
2022-03-22 14:49         ` Steven Rostedt [this message]
2022-03-22 14:49           ` Steven Rostedt
2022-04-07  2:26           ` Chengming Zhou
2022-04-07  2:26             ` Chengming Zhou
2022-04-07  8:58             ` Mark Brown
2022-04-07  8:58               ` Mark Brown
2022-04-07 12:39               ` Chengming Zhou
2022-04-07 12:39                 ` Chengming Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220322104956.42203163@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=qirui.001@bytedance.com \
    --cc=songmuchun@bytedance.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    --cc=zhouchengming@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.