* [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init
@ 2022-03-22 12:53 Ma Jun
2022-03-22 13:09 ` Chen, Guchun
2022-03-22 13:33 ` Christian König
0 siblings, 2 replies; 6+ messages in thread
From: Ma Jun @ 2022-03-22 12:53 UTC (permalink / raw)
To: amd-gfx; +Cc: alexander.deucher, christian.koenig, Hawking.Zhang
Correct the parameter name of amdgpu_ring_init() in header file.
Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
Change-Id: I202d76ba04b137926b456b1c8a4c05a5b1a01bff
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
index 5320bb0883d8..317d80209e95 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
@@ -300,8 +300,8 @@ void amdgpu_ring_generic_pad_ib(struct amdgpu_ring *ring, struct amdgpu_ib *ib);
void amdgpu_ring_commit(struct amdgpu_ring *ring);
void amdgpu_ring_undo(struct amdgpu_ring *ring);
int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring,
- unsigned int ring_size, struct amdgpu_irq_src *irq_src,
- unsigned int irq_type, unsigned int prio,
+ unsigned int max_dw, struct amdgpu_irq_src *irq_src,
+ unsigned int irq_type, unsigned int hw_prio,
atomic_t *sched_score);
void amdgpu_ring_fini(struct amdgpu_ring *ring);
void amdgpu_ring_emit_reg_write_reg_wait_helper(struct amdgpu_ring *ring,
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init
2022-03-22 12:53 [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init Ma Jun
@ 2022-03-22 13:09 ` Chen, Guchun
2022-03-22 13:33 ` Christian König
1 sibling, 0 replies; 6+ messages in thread
From: Chen, Guchun @ 2022-03-22 13:09 UTC (permalink / raw)
To: Ma, Jun, amd-gfx; +Cc: Deucher, Alexander, Koenig, Christian, Zhang, Hawking
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Regards,
Guchun
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Ma Jun
Sent: Tuesday, March 22, 2022 8:53 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>
Subject: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init
Correct the parameter name of amdgpu_ring_init() in header file.
Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
Change-Id: I202d76ba04b137926b456b1c8a4c05a5b1a01bff
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
index 5320bb0883d8..317d80209e95 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
@@ -300,8 +300,8 @@ void amdgpu_ring_generic_pad_ib(struct amdgpu_ring *ring, struct amdgpu_ib *ib); void amdgpu_ring_commit(struct amdgpu_ring *ring); void amdgpu_ring_undo(struct amdgpu_ring *ring); int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring,
- unsigned int ring_size, struct amdgpu_irq_src *irq_src,
- unsigned int irq_type, unsigned int prio,
+ unsigned int max_dw, struct amdgpu_irq_src *irq_src,
+ unsigned int irq_type, unsigned int hw_prio,
atomic_t *sched_score);
void amdgpu_ring_fini(struct amdgpu_ring *ring); void amdgpu_ring_emit_reg_write_reg_wait_helper(struct amdgpu_ring *ring,
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init
2022-03-22 12:53 [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init Ma Jun
2022-03-22 13:09 ` Chen, Guchun
@ 2022-03-22 13:33 ` Christian König
2022-03-23 3:02 ` Ma, Jun
1 sibling, 1 reply; 6+ messages in thread
From: Christian König @ 2022-03-22 13:33 UTC (permalink / raw)
To: Ma Jun, amd-gfx; +Cc: alexander.deucher, Hawking.Zhang
Am 22.03.22 um 13:53 schrieb Ma Jun:
> Correct the parameter name of amdgpu_ring_init() in header file.
Maybe write "Sync up header and implementation to use the same parameter
names", otherwise somebody could think that this is a real functional
bug fix and backport it.
>
> Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
With the commit message and subject adjusted the patch is Reviewed-by:
Christian König <christian.koenig@amd.com>
> Change-Id: I202d76ba04b137926b456b1c8a4c05a5b1a01bff
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
> index 5320bb0883d8..317d80209e95 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
> @@ -300,8 +300,8 @@ void amdgpu_ring_generic_pad_ib(struct amdgpu_ring *ring, struct amdgpu_ib *ib);
> void amdgpu_ring_commit(struct amdgpu_ring *ring);
> void amdgpu_ring_undo(struct amdgpu_ring *ring);
> int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring,
> - unsigned int ring_size, struct amdgpu_irq_src *irq_src,
> - unsigned int irq_type, unsigned int prio,
> + unsigned int max_dw, struct amdgpu_irq_src *irq_src,
> + unsigned int irq_type, unsigned int hw_prio,
> atomic_t *sched_score);
> void amdgpu_ring_fini(struct amdgpu_ring *ring);
> void amdgpu_ring_emit_reg_write_reg_wait_helper(struct amdgpu_ring *ring,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init
2022-03-22 13:33 ` Christian König
@ 2022-03-23 3:02 ` Ma, Jun
2022-03-23 6:22 ` Paul Menzel
0 siblings, 1 reply; 6+ messages in thread
From: Ma, Jun @ 2022-03-23 3:02 UTC (permalink / raw)
To: Christian König, Ma Jun, amd-gfx; +Cc: alexander.deucher, Hawking.Zhang
On 3/22/2022 9:33 PM, Christian König wrote:
> Am 22.03.22 um 13:53 schrieb Ma Jun:
>> Correct the parameter name of amdgpu_ring_init() in header file.
>
> Maybe write "Sync up header and implementation to use the same parameter
> names", otherwise somebody could think that this is a real functional
> bug fix and backport it.
> ok, will fix this in v2
Regards,
Ma Jun
>>
>> Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
>
> With the commit message and subject adjusted the patch is Reviewed-by:
> Christian König <christian.koenig@amd.com>
>
>> Change-Id: I202d76ba04b137926b456b1c8a4c05a5b1a01bff
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
>> index 5320bb0883d8..317d80209e95 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
>> @@ -300,8 +300,8 @@ void amdgpu_ring_generic_pad_ib(struct amdgpu_ring *ring, struct amdgpu_ib *ib);
>> void amdgpu_ring_commit(struct amdgpu_ring *ring);
>> void amdgpu_ring_undo(struct amdgpu_ring *ring);
>> int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring,
>> - unsigned int ring_size, struct amdgpu_irq_src *irq_src,
>> - unsigned int irq_type, unsigned int prio,
>> + unsigned int max_dw, struct amdgpu_irq_src *irq_src,
>> + unsigned int irq_type, unsigned int hw_prio,
>> atomic_t *sched_score);
>> void amdgpu_ring_fini(struct amdgpu_ring *ring);
>> void amdgpu_ring_emit_reg_write_reg_wait_helper(struct amdgpu_ring *ring,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init
2022-03-23 3:02 ` Ma, Jun
@ 2022-03-23 6:22 ` Paul Menzel
2022-03-23 8:44 ` Ma, Jun
0 siblings, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2022-03-23 6:22 UTC (permalink / raw)
To: Jun Ma
Cc: alexander.deucher, Ma Jun, Christian König, amd-gfx, Hawking.Zhang
Dear Jun,
Thank you for your patch.
Am 23.03.22 um 04:02 schrieb Ma, Jun:
> On 3/22/2022 9:33 PM, Christian König wrote:
>> Am 22.03.22 um 13:53 schrieb Ma Jun:
>>> Correct the parameter name of amdgpu_ring_init() in header file.
>>
>> Maybe write "Sync up header and implementation to use the same parameter
>> names", otherwise somebody could think that this is a real functional
>> bug fix and backport it.
>> ok, will fix this in v2
(Your mailer incorrectly quoted your reply sentence, making it look like
it was written by Christian.)
If you re-roll the patch, please also mention both parameter names in
the commit message, so people do not have to search in the diff for
them, and can verify the changes match your intention. (The summary uses
singular *name* adding a little confusion.)
Kind regards,
Paul
>>> Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
>>
>> With the commit message and subject adjusted the patch is Reviewed-by:
>> Christian König <christian.koenig@amd.com>
>>
>>> Change-Id: I202d76ba04b137926b456b1c8a4c05a5b1a01bff
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
>>> index 5320bb0883d8..317d80209e95 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
>>> @@ -300,8 +300,8 @@ void amdgpu_ring_generic_pad_ib(struct amdgpu_ring *ring, struct amdgpu_ib *ib);
>>> void amdgpu_ring_commit(struct amdgpu_ring *ring);
>>> void amdgpu_ring_undo(struct amdgpu_ring *ring);
>>> int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring,
>>> - unsigned int ring_size, struct amdgpu_irq_src *irq_src,
>>> - unsigned int irq_type, unsigned int prio,
>>> + unsigned int max_dw, struct amdgpu_irq_src *irq_src,
>>> + unsigned int irq_type, unsigned int hw_prio,
>>> atomic_t *sched_score);
>>> void amdgpu_ring_fini(struct amdgpu_ring *ring);
>>> void amdgpu_ring_emit_reg_write_reg_wait_helper(struct amdgpu_ring *ring,
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init
2022-03-23 6:22 ` Paul Menzel
@ 2022-03-23 8:44 ` Ma, Jun
0 siblings, 0 replies; 6+ messages in thread
From: Ma, Jun @ 2022-03-23 8:44 UTC (permalink / raw)
To: Paul Menzel
Cc: amd-gfx, Ma Jun, alexander.deucher, Christian König, Hawking.Zhang
On 3/23/2022 2:22 PM, Paul Menzel wrote:
> Dear Jun,
>
>
> Thank you for your patch.
>
> Am 23.03.22 um 04:02 schrieb Ma, Jun:
>
>> On 3/22/2022 9:33 PM, Christian König wrote:
>>> Am 22.03.22 um 13:53 schrieb Ma Jun:
>>>> Correct the parameter name of amdgpu_ring_init() in header file.
>>>
>>> Maybe write "Sync up header and implementation to use the same parameter
>>> names", otherwise somebody could think that this is a real functional
>>> bug fix and backport it.
>>> ok, will fix this in v2
>
> (Your mailer incorrectly quoted your reply sentence, making it look like
> it was written by Christian.)
>
> If you re-roll the patch, please also mention both parameter names in
> the commit message, so people do not have to search in the diff for
> them, and can verify the changes match your intention. (The summary uses
> singular *name* adding a little confusion.)
>
Good suggestion, thank you.
Regards,
Ma Jun
>
> Kind regards,
>
> Paul
>
>
>>>> Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
>>>
>>> With the commit message and subject adjusted the patch is Reviewed-by:
>>> Christian König <christian.koenig@amd.com>
>>>
>>>> Change-Id: I202d76ba04b137926b456b1c8a4c05a5b1a01bff
>>>> ---
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
>>>> index 5320bb0883d8..317d80209e95 100644
>>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
>>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
>>>> @@ -300,8 +300,8 @@ void amdgpu_ring_generic_pad_ib(struct amdgpu_ring *ring, struct amdgpu_ib *ib);
>>>> void amdgpu_ring_commit(struct amdgpu_ring *ring);
>>>> void amdgpu_ring_undo(struct amdgpu_ring *ring);
>>>> int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring,
>>>> - unsigned int ring_size, struct amdgpu_irq_src *irq_src,
>>>> - unsigned int irq_type, unsigned int prio,
>>>> + unsigned int max_dw, struct amdgpu_irq_src *irq_src,
>>>> + unsigned int irq_type, unsigned int hw_prio,
>>>> atomic_t *sched_score);
>>>> void amdgpu_ring_fini(struct amdgpu_ring *ring);
>>>> void amdgpu_ring_emit_reg_write_reg_wait_helper(struct amdgpu_ring *ring,
>>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-23 8:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-22 12:53 [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init Ma Jun
2022-03-22 13:09 ` Chen, Guchun
2022-03-22 13:33 ` Christian König
2022-03-23 3:02 ` Ma, Jun
2022-03-23 6:22 ` Paul Menzel
2022-03-23 8:44 ` Ma, Jun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.