All of lore.kernel.org
 help / color / mirror / Atom feed
* [jarkko-tpmdd:master 27/27] drivers/char/tpm/tpm_tis_synquacer.c:89:12: warning: passing argument 1 of 'iowrite8' makes integer from pointer without a cast
@ 2022-03-22  5:40 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-03-22  5:40 UTC (permalink / raw)
  To: Johannes Holland; +Cc: kbuild-all, linux-kernel, Jarkko Sakkinen

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git master
head:   a536629ef32d127d26f3886f1fd480708fd5ac20
commit: a536629ef32d127d26f3886f1fd480708fd5ac20 [27/27] tpm: Remove read16/read32/write32 calls from tpm_tis_phy_ops
config: um-allyesconfig (https://download.01.org/0day-ci/archive/20220322/202203221316.iy9h9BnW-lkp@intel.com/config)
compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=a536629ef32d127d26f3886f1fd480708fd5ac20
        git remote add jarkko-tpmdd git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git
        git fetch --no-tags jarkko-tpmdd master
        git checkout a536629ef32d127d26f3886f1fd480708fd5ac20
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=um SHELL=/bin/bash drivers/char/tpm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/char/tpm/tpm_tis_synquacer.c: In function 'tpm_tis_synquacer_read_bytes':
   drivers/char/tpm/tpm_tis_synquacer.c:45:6: warning: unused variable 'result32' [-Wunused-variable]
      45 |  u32 result32;
         |      ^~~~~~~~
   drivers/char/tpm/tpm_tis_synquacer.c:44:6: warning: unused variable 'result16' [-Wunused-variable]
      44 |  u16 result16;
         |      ^~~~~~~~
   drivers/char/tpm/tpm_tis_synquacer.c:43:9: warning: unused variable 'result_le32' [-Wunused-variable]
      43 |  __le32 result_le32;
         |         ^~~~~~~~~~~
   drivers/char/tpm/tpm_tis_synquacer.c:42:9: warning: unused variable 'result_le16' [-Wunused-variable]
      42 |  __le16 result_le16;
         |         ^~~~~~~~~~~
   drivers/char/tpm/tpm_tis_synquacer.c: In function 'tpm_tis_synquacer_write_bytes':
>> drivers/char/tpm/tpm_tis_synquacer.c:89:12: warning: passing argument 1 of 'iowrite8' makes integer from pointer without a cast [-Wint-conversion]
      89 |   iowrite8(&value[3], phy->iobase + addr + 3);
         |            ^~~~~~~~~
         |            |
         |            const u8 * {aka const unsigned char *}
   In file included from include/asm-generic/io.h:15,
                    from arch/um/include/asm/io.h:24,
                    from include/linux/io.h:13,
                    from drivers/char/tpm/tpm.h:26,
                    from drivers/char/tpm/tpm_tis_synquacer.c:14:
   include/asm-generic/iomap.h:50:22: note: expected 'u8' {aka 'unsigned char'} but argument is of type 'const u8 *' {aka 'const unsigned char *'}
      50 | extern void iowrite8(u8, void __iomem *);
         |                      ^~
   drivers/char/tpm/tpm_tis_synquacer.c:90:12: warning: passing argument 1 of 'iowrite8' makes integer from pointer without a cast [-Wint-conversion]
      90 |   iowrite8(&value[2], phy->iobase + addr + 2);
         |            ^~~~~~~~~
         |            |
         |            const u8 * {aka const unsigned char *}
   In file included from include/asm-generic/io.h:15,
                    from arch/um/include/asm/io.h:24,
                    from include/linux/io.h:13,
                    from drivers/char/tpm/tpm.h:26,
                    from drivers/char/tpm/tpm_tis_synquacer.c:14:
   include/asm-generic/iomap.h:50:22: note: expected 'u8' {aka 'unsigned char'} but argument is of type 'const u8 *' {aka 'const unsigned char *'}
      50 | extern void iowrite8(u8, void __iomem *);
         |                      ^~
   drivers/char/tpm/tpm_tis_synquacer.c:91:12: warning: passing argument 1 of 'iowrite8' makes integer from pointer without a cast [-Wint-conversion]
      91 |   iowrite8(&value[1], phy->iobase + addr + 1);
         |            ^~~~~~~~~
         |            |
         |            const u8 * {aka const unsigned char *}
   In file included from include/asm-generic/io.h:15,
                    from arch/um/include/asm/io.h:24,
                    from include/linux/io.h:13,
                    from drivers/char/tpm/tpm.h:26,
                    from drivers/char/tpm/tpm_tis_synquacer.c:14:
   include/asm-generic/iomap.h:50:22: note: expected 'u8' {aka 'unsigned char'} but argument is of type 'const u8 *' {aka 'const unsigned char *'}
      50 | extern void iowrite8(u8, void __iomem *);
         |                      ^~
   drivers/char/tpm/tpm_tis_synquacer.c:92:12: warning: passing argument 1 of 'iowrite8' makes integer from pointer without a cast [-Wint-conversion]
      92 |   iowrite8(&value[0], phy->iobase + addr);
         |            ^~~~~~~~~
         |            |
         |            const u8 * {aka const unsigned char *}
   In file included from include/asm-generic/io.h:15,
                    from arch/um/include/asm/io.h:24,
                    from include/linux/io.h:13,
                    from drivers/char/tpm/tpm.h:26,
                    from drivers/char/tpm/tpm_tis_synquacer.c:14:
   include/asm-generic/iomap.h:50:22: note: expected 'u8' {aka 'unsigned char'} but argument is of type 'const u8 *' {aka 'const unsigned char *'}
      50 | extern void iowrite8(u8, void __iomem *);
         |                      ^~
   drivers/char/tpm/tpm_tis_synquacer.c:75:6: warning: unused variable 'result32' [-Wunused-variable]
      75 |  u32 result32;
         |      ^~~~~~~~
   drivers/char/tpm/tpm_tis_synquacer.c:74:6: warning: unused variable 'result16' [-Wunused-variable]
      74 |  u16 result16;
         |      ^~~~~~~~
   drivers/char/tpm/tpm_tis_synquacer.c:73:9: warning: unused variable 'result_le32' [-Wunused-variable]
      73 |  __le32 result_le32;
         |         ^~~~~~~~~~~
   drivers/char/tpm/tpm_tis_synquacer.c:72:9: warning: unused variable 'result_le16' [-Wunused-variable]
      72 |  __le16 result_le16;
         |         ^~~~~~~~~~~


vim +/iowrite8 +89 drivers/char/tpm/tpm_tis_synquacer.c

    66	
    67	static int tpm_tis_synquacer_write_bytes(struct tpm_tis_data *data, u32 addr,
    68						 u16 len, const u8 *value,
    69						 enum tpm_tis_io_mode io_mode)
    70	{
    71		struct tpm_tis_synquacer_phy *phy = to_tpm_tis_tcg_phy(data);
    72		__le16 result_le16;
    73		__le32 result_le32;
    74		u16 result16;
    75		u32 result32;
    76	
    77		switch (io_mode) {
    78		case TPM_TIS_PHYS_8:
    79			while (len--)
    80				iowrite8(*value++, phy->iobase + addr);
    81			break;
    82		case TPM_TIS_PHYS_16:
    83			return -EINVAL;
    84		case TPM_TIS_PHYS_32:
    85			/*
    86			 * Due to the limitation of SPI controller on SynQuacer,
    87			 * 16/32 bits access must be done in byte-wise and descending order.
    88			 */
  > 89			iowrite8(&value[3], phy->iobase + addr + 3);
    90			iowrite8(&value[2], phy->iobase + addr + 2);
    91			iowrite8(&value[1], phy->iobase + addr + 1);
    92			iowrite8(&value[0], phy->iobase + addr);
    93			break;
    94		}
    95	
    96		return 0;
    97	}
    98	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-03-22  5:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-22  5:40 [jarkko-tpmdd:master 27/27] drivers/char/tpm/tpm_tis_synquacer.c:89:12: warning: passing argument 1 of 'iowrite8' makes integer from pointer without a cast kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.