[Intel-gfx] [PATCH] [topic/core-for-CI] Revert "drm/i915/dg2: Add relocation exception"

[Intel-gfx] [PATCH] [topic/core-for-CI] Revert "drm/i915/dg2: Add relocation exception"

[Zbigniew Kempczyński]

This reverts commit 904ebf2ba89edaeba5c7c10540e43dba63541dc6.

Failures on dg2 tests were caused by invalid alignment when local memory
was in use. Changes which adopt alignment according to gen were already
merged in IGT so lets revert relocation temporary enabler for dg2. Keeping
it is a little bit problematic for IGT because on premerge we would see
results with kernel which supports relocation. To see no-relocation
results we need to send disabler (like this revert), point IGT with
"Test-with" tag what is cumbersome and time consuming so lets do this
permanently. If we will see some failures they need to be fixed instead
of keeping relocation enabler.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jason Ekstrand <jason@jlekstrand.net>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index 42a49fd2f2ab..8b0b4aeb6716 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -501,7 +501,7 @@ static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb)
 	 */
 	if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915) ||
 	    IS_ROCKETLAKE(eb->i915) || IS_ALDERLAKE_S(eb->i915) ||
-	    IS_ALDERLAKE_P(eb->i915) || IS_DG2(eb->i915))
+	    IS_ALDERLAKE_P(eb->i915))
 		return true;
 
 	return false;
-- 
2.32.0

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Revert "drm/i915/dg2: Add relocation exception"

[Patchwork]

== Series Details ==

Series: Revert "drm/i915/dg2: Add relocation exception"
URL   : https://patchwork.freedesktop.org/series/101669/
State : warning

== Summary ==

$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_enable' not found
./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_disable' not found

[Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "drm/i915/dg2: Add relocation exception"

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 5683 bytes --]

== Series Details ==

Series: Revert "drm/i915/dg2: Add relocation exception"
URL   : https://patchwork.freedesktop.org/series/101669/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11397 -> Patchwork_22652
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_22652 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_22652, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22652/index.html

Participating hosts (49 -> 41)
------------------------------

  Missing    (8): shard-tglu fi-hsw-4200u bat-adlm-1 fi-bsw-cyan fi-ctg-p8600 shard-rkl shard-dg1 fi-bdw-samus 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_22652:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@hangcheck:
    - fi-snb-2520m:       [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11397/fi-snb-2520m/igt@i915_selftest@live@hangcheck.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22652/fi-snb-2520m/igt@i915_selftest@live@hangcheck.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@gem_exec_gttfill@basic:
    - {bat-dg2-9}:        [PASS][3] -> [SKIP][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11397/bat-dg2-9/igt@gem_exec_gttfill@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22652/bat-dg2-9/igt@gem_exec_gttfill@basic.html
    - {bat-dg2-8}:        [PASS][5] -> [SKIP][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11397/bat-dg2-8/igt@gem_exec_gttfill@basic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22652/bat-dg2-8/igt@gem_exec_gttfill@basic.html

  * igt@gem_exec_parallel@engines@basic:
    - {bat-dg2-9}:        [PASS][7] -> [FAIL][8] +3 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11397/bat-dg2-9/igt@gem_exec_parallel@engines@basic.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22652/bat-dg2-9/igt@gem_exec_parallel@engines@basic.html

  * igt@gem_exec_parallel@engines@contexts:
    - {bat-dg2-8}:        [PASS][9] -> [FAIL][10] +3 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11397/bat-dg2-8/igt@gem_exec_parallel@engines@contexts.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22652/bat-dg2-8/igt@gem_exec_parallel@engines@contexts.html

  * igt@gem_exec_suspend@basic-s0@smem:
    - {bat-dg2-9}:        [DMESG-WARN][11] ([i915#5193]) -> [FAIL][12] +3 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11397/bat-dg2-9/igt@gem_exec_suspend@basic-s0@smem.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22652/bat-dg2-9/igt@gem_exec_suspend@basic-s0@smem.html

  * igt@gem_exec_suspend@basic-s3@smem:
    - {bat-dg2-8}:        [DMESG-WARN][13] ([i915#5193]) -> [FAIL][14] +3 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11397/bat-dg2-8/igt@gem_exec_suspend@basic-s3@smem.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22652/bat-dg2-8/igt@gem_exec_suspend@basic-s3@smem.html

  
Known issues
------------

  Here are the changes found in Patchwork_22652 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s0@smem:
    - fi-glk-dsi:         [DMESG-WARN][15] ([i915#2943]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11397/fi-glk-dsi/igt@gem_exec_suspend@basic-s0@smem.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22652/fi-glk-dsi/igt@gem_exec_suspend@basic-s0@smem.html

  * igt@i915_selftest@live@coherency:
    - {bat-rpls-2}:       [INCOMPLETE][17] -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11397/bat-rpls-2/igt@i915_selftest@live@coherency.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22652/bat-rpls-2/igt@i915_selftest@live@coherency.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#2943]: https://gitlab.freedesktop.org/drm/intel/issues/2943
  [i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
  [i915#4897]: https://gitlab.freedesktop.org/drm/intel/issues/4897
  [i915#5193]: https://gitlab.freedesktop.org/drm/intel/issues/5193
  [i915#5337]: https://gitlab.freedesktop.org/drm/intel/issues/5337
  [i915#5339]: https://gitlab.freedesktop.org/drm/intel/issues/5339
  [i915#5342]: https://gitlab.freedesktop.org/drm/intel/issues/5342


Build changes
-------------

  * Linux: CI_DRM_11397 -> Patchwork_22652

  CI-20190529: 20190529
  CI_DRM_11397: 056d47eaf6ea753fa2e21da31f9cbd8b721bbb7b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_6387: 04d012b18355b53798af5a55a8915afb1a421bba @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_22652: 16ec815c909fcd462eea188236dabb10e5647356 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

16ec815c909f Revert "drm/i915/dg2: Add relocation exception"

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22652/index.html

[-- Attachment #2: Type: text/html, Size: 6149 bytes --]

Re: [Intel-gfx] [PATCH] [topic/core-for-CI] Revert "drm/i915/dg2: Add relocation exception"

[Zbigniew Kempczyński]

On Wed, Apr 06, 2022 at 08:36:32AM -0700, Lucas De Marchi wrote:
> On Thu, Mar 31, 2022 at 10:16:02AM -0700, Lucas De Marchi wrote:
> > On Wed, Mar 23, 2022 at 06:46:38PM +0100, Zbigniew Kempczyński wrote:
> > > This reverts commit 904ebf2ba89edaeba5c7c10540e43dba63541dc6.
> > > 
> > > Failures on dg2 tests were caused by invalid alignment when local memory
> > > was in use. Changes which adopt alignment according to gen were already
> > > merged in IGT so lets revert relocation temporary enabler for dg2. Keeping
> > > it is a little bit problematic for IGT because on premerge we would see
> > > results with kernel which supports relocation. To see no-relocation
> > > results we need to send disabler (like this revert), point IGT with
> > > "Test-with" tag what is cumbersome and time consuming so lets do this
> > > permanently. If we will see some failures they need to be fixed instead
> > > of keeping relocation enabler.
> > > 
> > > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > > Cc: Dave Airlie <airlied@redhat.com>
> > > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > > Cc: Jason Ekstrand <jason@jlekstrand.net>
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > 
> > thanks. I double checked BAT and things seem to be equivalent now
> > without that hack. I removed it from topic/core-for-CI.
> > 
> > How are we with the igt tests executed in full run?
> 
> ping?
> 
> Also, we still have this exception for ADL-P, ADL-S and RKL. Should we
> go ahead and try removing them?
> 
> Lucas De Marchi

Yes, please drop ADL*/RKL patch in core-for-CI. 

--
Zbigniew

Re: [Intel-gfx] [PATCH] [topic/core-for-CI] Revert "drm/i915/dg2: Add relocation exception"

[Lucas De Marchi]

On Thu, Mar 31, 2022 at 10:16:02AM -0700, Lucas De Marchi wrote:
>On Wed, Mar 23, 2022 at 06:46:38PM +0100, Zbigniew Kempczyński wrote:
>>This reverts commit 904ebf2ba89edaeba5c7c10540e43dba63541dc6.
>>
>>Failures on dg2 tests were caused by invalid alignment when local memory
>>was in use. Changes which adopt alignment according to gen were already
>>merged in IGT so lets revert relocation temporary enabler for dg2. Keeping
>>it is a little bit problematic for IGT because on premerge we would see
>>results with kernel which supports relocation. To see no-relocation
>>results we need to send disabler (like this revert), point IGT with
>>"Test-with" tag what is cumbersome and time consuming so lets do this
>>permanently. If we will see some failures they need to be fixed instead
>>of keeping relocation enabler.
>>
>>Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
>>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>>Cc: Dave Airlie <airlied@redhat.com>
>>Cc: Daniel Vetter <daniel.vetter@intel.com>
>>Cc: Jason Ekstrand <jason@jlekstrand.net>
>>Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
>thanks. I double checked BAT and things seem to be equivalent now
>without that hack. I removed it from topic/core-for-CI.
>
>How are we with the igt tests executed in full run?

ping?

Also, we still have this exception for ADL-P, ADL-S and RKL. Should we
go ahead and try removing them?

Lucas De Marchi

Re: [Intel-gfx] [PATCH] [topic/core-for-CI] Revert "drm/i915/dg2: Add relocation exception"

[Lucas De Marchi]

On Wed, Mar 23, 2022 at 06:46:38PM +0100, Zbigniew Kempczyński wrote:
>This reverts commit 904ebf2ba89edaeba5c7c10540e43dba63541dc6.
>
>Failures on dg2 tests were caused by invalid alignment when local memory
>was in use. Changes which adopt alignment according to gen were already
>merged in IGT so lets revert relocation temporary enabler for dg2. Keeping
>it is a little bit problematic for IGT because on premerge we would see
>results with kernel which supports relocation. To see no-relocation
>results we need to send disabler (like this revert), point IGT with
>"Test-with" tag what is cumbersome and time consuming so lets do this
>permanently. If we will see some failures they need to be fixed instead
>of keeping relocation enabler.
>
>Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Cc: Dave Airlie <airlied@redhat.com>
>Cc: Daniel Vetter <daniel.vetter@intel.com>
>Cc: Jason Ekstrand <jason@jlekstrand.net>
>Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>

thanks. I double checked BAT and things seem to be equivalent now
without that hack. I removed it from topic/core-for-CI.

How are we with the igt tests executed in full run?

thanks
Lucas De Marchi


>---
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
>index 42a49fd2f2ab..8b0b4aeb6716 100644
>--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
>+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
>@@ -501,7 +501,7 @@ static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb)
> 	 */
> 	if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915) ||
> 	    IS_ROCKETLAKE(eb->i915) || IS_ALDERLAKE_S(eb->i915) ||
>-	    IS_ALDERLAKE_P(eb->i915) || IS_DG2(eb->i915))
>+	    IS_ALDERLAKE_P(eb->i915))
> 		return true;
>
> 	return false;
>-- 
>2.32.0
>

[Intel-gfx] [PATCH] [topic/core-for-CI] Revert "drm/i915/dg2: Add relocation exception"

[Zbigniew Kempczyński]

This reverts commit 904ebf2ba89edaeba5c7c10540e43dba63541dc6.

Failures on dg2 tests were caused by invalid alignment when local memory
was in use. Changes which adopt alignment according to gen were already
merged in IGT so lets revert relocation temporary enabler for dg2. Keeping
it is a little bit problematic for IGT because on premerge we would see
results with kernel which supports relocation. To see no-relocation
results we need to send disabler (like this revert), point IGT with
"Test-with" tag what is cumbersome and time consuming so lets do this
permanently. If we will see some failures they need to be fixed instead
of keeping relocation enabler.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jason Ekstrand <jason@jlekstrand.net>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index 42a49fd2f2ab..8b0b4aeb6716 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -501,7 +501,7 @@ static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb)
 	 */
 	if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915) ||
 	    IS_ROCKETLAKE(eb->i915) || IS_ALDERLAKE_S(eb->i915) ||
-	    IS_ALDERLAKE_P(eb->i915) || IS_DG2(eb->i915))
+	    IS_ALDERLAKE_P(eb->i915))
 		return true;
 
 	return false;
-- 
2.32.0